Launchpad itself

Merge ~cjwatson/launchpad:upgrade-type-annotations into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. upgrade-type-annotations
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 11cbee4253953a8876c934b572a259b0dbf97d66
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:upgrade-type-annotations
Merge into: launchpad:master
Diff against target: 26 lines (+2/-2)
2 files modified
lib/lp/services/feeds/browser.py (+1/-1)
lib/lp/testing/__init__.py (+1/-1)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+456427@code.launchpad.net

Commit message

Fix a couple of type annotation errors

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/services/feeds/browser.py b/lib/lp/services/feeds/browser.py
2index 7c9fba7..e1f5087 100644
3--- a/lib/lp/services/feeds/browser.py
4+++ b/lib/lp/services/feeds/browser.py
5@@ -372,7 +372,7 @@ class FeedsMixin:
6 feed_links: Returns a list of objects subclassed from FeedLinkBase.
7 """
8
9- feed_types: Tuple[Type[FeedLinkBase, ...]] = (
10+ feed_types: Tuple[Type[FeedLinkBase], ...] = (
11 AnnouncementsFeedLink,
12 BranchFeedLink,
13 BugFeedLink,
14diff --git a/lib/lp/testing/__init__.py b/lib/lp/testing/__init__.py
15index 3c5f69e..4e73ec9 100644
16--- a/lib/lp/testing/__init__.py
17+++ b/lib/lp/testing/__init__.py
18@@ -1071,7 +1071,7 @@ class WebServiceTestCase(TestCaseWithFactory):
19
20
21 class AbstractYUITestCase(TestCase):
22- layer: Optional[Type[BaseLayer]] = None
23+ layer: Optional[Type["BaseLayer"]] = None
24 suite_name = ""
25 # 30 seconds for the suite.
26 suite_timeout = 30000

Subscribers

People subscribed via source and target branches

to status/vote changes: