~cjwatson/launchpad:refactor-pgsession-queries

Branch merges

Propose for merging

Ready for review for merging into launchpad:master

Launchpad code reviewers: Pending requested 2023-02-23

Diff: 329 lines (+116/-88)

4 files modified

lib/lp/services/session/adapters.py (+2/-1)
lib/lp/services/session/model.py (+75/-3)
lib/lp/services/webapp/pgsession.py (+38/-83)
tox.ini (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

1fe67cd... by Colin Watson on 2023-02-23

Refactor PGSession queries to reduce manual SQL

Pushing the special handling for old session pickles saved by Python 2
down to the `SessionPkgData` model and adding some named function
declarations allows us to make quite effective use of Storm's query
compiler, eliminating some manually-constructed SQL and giving us better
type annotations.

It's possible that at least the dump compatibility with Python 2 can now
be removed, but I deliberately haven't attempted that in this commit:
this should be a pure refactoring with no functional change.

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

935f87a... by Colin Watson on 2023-02-23

Show built files on CIBuild:+index

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/437673

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

6a3f8f3... by Colin Watson on 2023-02-23

Add XXX comment for ProxiedLibraryFileAlias.getURL gotcha

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

d206cbe... by Guruprasad on 2023-02-23

Remove the typo leading space in the distribution widget empty values

Merged from https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/437779

bd38e5d... by Guruprasad on 2023-02-23

Remove the typo leading space in the distribution widget empty values

b826c8b... by Colin Watson on 2023-02-22

Allow making non-empty Artifactory PPAs private

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/437678

b113d76... by Colin Watson on 2023-02-22

Handle "all" in snapcraft architectures declaration

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/437624

47cbbc9... by Colin Watson on 2023-02-22

Allow making non-empty Artifactory PPAs private

The reasons why we can't change the privacy of non-empty
locally-published PPAs don't quite apply in the Artifactory case. There
are still some reasons to be careful, but we can at least give ourselves
the ability to fix the failure mode where we've forgotten to make an
archive private.

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

ae4b1b5... by Colin Watson on 2023-02-22

Show built files on CIBuild:+index

Most build types show links to their output files on their index page,
and it was odd that CI builds didn't; it also made certain kinds of
debugging more difficult.

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

43f8ff2... by Colin Watson on 2023-02-21

Handle "all" in snapcraft architectures declaration

This has apparently been supported by snapcraft for quite some time, but
we overlooked it while implementing `architectures` in Launchpad.
Reported by James Henstridge.

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last