lp:~cjwatson/launchpad/export-git-repositories-new

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:launchpad

Launchpad code reviewers: Pending requested 2019-09-26

Diff: 496 lines (+185/-80)

9 files modified

lib/lp/code/errors.py (+5/-1)
lib/lp/code/interfaces/gitnamespace.py (+6/-2)
lib/lp/code/interfaces/gitrepository.py (+15/-2)
lib/lp/code/model/githosting.py (+2/-2)
lib/lp/code/model/gitnamespace.py (+42/-2)
lib/lp/code/model/gitrepository.py (+21/-6)
lib/lp/code/model/tests/test_gitrepository.py (+66/-0)
lib/lp/code/xmlrpc/git.py (+27/-64)
lib/lp/code/xmlrpc/tests/test_git.py (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1824399: Add Git HTTPS push tokens for snapcraft experiment

High

Fix Released

Link a bug report

Related blueprints

19055. By Colin Watson on 2019-09-26

Fix GitRepositorySet.new, and export it on the webservice.

This was previously untested, and had been broken since r18222.

Now that namespace.createRepository can create the repository on the hosting
service, we can safely export this to create a bare repository via the API.
For example, this allows snapcraft to create a temporary repository, issue
an access token to it, and push code to it, all without needing to configure
an SSH key.

19054. By Colin Watson on 2019-09-26

Push Git hosting creation down from XML-RPC endpoint to model.

Having the creation of the actual repository on disk be done by the XML-RPC
endpoint makes it difficult to expose other methods of creating
repositories.

I rearranged how target and owner defaults are set. We have to create the
repository on the hosting service as the last step to avoid problems with
rolling back transactions, so pushing this part down to the model also
requires pushing down target/owner default handling, and the callback
mechanism previously in place wasn't very suited to that.

I had to adjust the permission check in
GitRepositorySet.setDefaultRepository slightly, because pushing down
target/owner default handling is easier if the Unauthorized exception
message is more accurate. setDefaultRepositoryForOwner already raised
exceptions with accurate messages.

19053. By Launchpad PQM Bot on 2019-09-16

[testfix][r=cjwatson][no-qa] Fix doctests to cope with added
 Content-Security-Policy header.

19052. By Launchpad PQM Bot on 2019-09-16

[r=bloodearnest][no-qa] Set "Content-Security-Policy: frame-ancestors
 'self';
 " as well as "X-Frame-Options: SAMEORIGIN", for improved browser
 compatibility.

19051. By Launchpad PQM Bot on 2019-09-16

[r=bloodearnest][no-qa] Remove parts of lp.code.mail.patches that are
 unmodified from bzrlib.

19050. By Launchpad PQM Bot on 2019-09-16

[r=wgrant][bug=1824399] Add and export
 IGitRepository.issueAccessToken.

19049. By Launchpad PQM Bot on 2019-09-10

[r=wgrant][bug=1824399][incr] Make the Git XML-RPC API honour user
 macaroons.

19048. By Launchpad PQM Bot on 2019-09-10

[r=wgrant][bug=1842658][incr] Add IPackageset.isSourceIncluded.

19047. By Launchpad PQM Bot on 2019-09-10

[r=wgrant][no-qa] Allow ProductReleaseFinder to use ftp:// URLs.

19046. By Launchpad PQM Bot on 2019-09-05

[r=cjwatson][bug=1842919] Remove null characters in copyright field
 of sourcepackagerelease