lp:~cjwatson/launchpad/login-interstitial

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:launchpad

Launchpad code reviewers: Pending requested 2018-05-26

Diff: 1093 lines (+537/-113)

10 files modified

lib/lp/app/browser/configure.zcml (+13/-1)
lib/lp/app/browser/launchpad.py (+4/-2)
lib/lp/services/webapp/login.py (+209/-42)
lib/lp/services/webapp/templates/login-new-account.pt (+36/-0)
lib/lp/services/webapp/templates/login-reactivate-account.pt (+43/-0)
lib/lp/services/webapp/tests/test_login.py (+153/-25)
lib/lp/testopenid/browser/server.py (+37/-25)
lib/lp/testopenid/interfaces/server.py (+7/-2)
lib/lp/testopenid/stories/logging-in.txt (+1/-0)
utilities/make-lp-user (+34/-16)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

18668. By Colin Watson on 2018-05-25

Add interstitial pages when creating or reactivating an account.

These provide an opportunity to present the user with the terms of service
and privacy policy and require that they explicitly accept them, as well as
making it harder to reactivate an account by accident.

To support testing this locally, I extended make-lp-user to be able to
create placeholder accounts, and adjusted testopenid so that it can
authenticate as an inactive account by explicitly supplying the username.

18667. By Launchpad PQM Bot on 2018-05-23

[r=maxiberta][no-qa] Add a "Data privacy" link to the site footer.

18666. By Launchpad PQM Bot on 2018-05-23

[r=wgrant][no-qa] Make updated code import emails more informative.

18665. By Launchpad PQM Bot on 2018-05-23

[r=wgrant][no-qa] Add a feature flag to disable commercial
 subscriptions.

18664. By Launchpad PQM Bot on 2018-05-22

[testfix][r=wgrant] Fix testrunner homepage_recent_posts_feed to use
 bingtestservice.

18663. By Launchpad PQM Bot on 2018-05-22

[r=wgrant][no-qa] Drop search_path and ts2 reside. All our stuff is
 now in public.

18662. By Launchpad PQM Bot on 2018-05-22

[r=wgrant][no-qa] Remove the Google search service backend.

18661. By Launchpad PQM Bot on 2018-05-19

[r=wgrant][no-qa] Upgrade to soupmatchers 0.4.

18660. By Launchpad PQM Bot on 2018-05-15

[r=cjwatson][no-qa] Update activity() for PostgreSQL 10 support,
 in addition to 9.6, 9.5 and 9.3.

18659. By Launchpad PQM Bot on 2018-05-15

[r=stub][no-qa] Drop the tsearch2 extension and ts2 schema.