lp:~cjwatson/launchpad/opt-in-zopeless-immediate-mail

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:launchpad

Launchpad code reviewers: Pending requested 2015-09-08

Diff: 421 lines (+67/-49)

14 files modified

daemons/buildd-manager.tac (+2/-8)
lib/lp/bugs/scripts/bugnotification.py (+11/-2)
lib/lp/bugs/scripts/tests/test_bugnotification.py (+1/-1)
lib/lp/bugs/tests/bugs-emailinterface.txt (+6/-11)
lib/lp/code/mail/codehandler.py (+1/-1)
lib/lp/services/job/celeryjob.py (+1/-3)
lib/lp/services/job/runner.py (+8/-7)
lib/lp/services/mail/basemailer.py (+7/-2)
lib/lp/services/mail/sendmail.py (+13/-1)
lib/lp/services/mail/tests/incomingmail.txt (+6/-2)
lib/lp/services/mail/tests/test_incoming.py (+2/-0)
lib/lp/services/scripts/base.py (+1/-6)
lib/lp/testing/layers.py (+1/-5)
scripts/mlist-import.py (+7/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #29744: In Zopeless, mails should be sent only when the transaction is committed

Low

In Progress

Link a bug report

Related blueprints

17726. By Colin Watson on 2015-09-08

Drop immediate mail delivery from LaunchpadScript and LaunchpadZopelessLayer.

17725. By Colin Watson on 2015-09-08

Drop explicit immediate mail delivery from buildd-manager; build mail all goes via BaseMailer now, which handles that.

17724. By Colin Watson on 2015-09-08

Drop immediate mail delivery from jobs, except for OOPS and user error notifications.

17723. By Colin Watson on 2015-09-08

Fix CodeHandler to abort before sending error notifications.

17722. By Colin Watson on 2015-09-08

Force immediate mail delivery for MailingListImport.

17721. By Colin Watson on 2015-09-08

Force immediate mail delivery for bug notifications and BaseMailer, which rely on this for SMTP exception handling.

17720. By Colin Watson on 2015-09-08

Adjust some tests to stop assuming immediate mail delivery.

17719. By Colin Watson on 2015-09-08

Introduce an immediate_mail_delivery context manager, allowing more fine-grained control.

17718. By Colin Watson on 2015-09-08

Use pop_notifications in more places to avoid fragile patterns with stub.test_emails, and introduce an assertEmailQueueLength helper.

17717. By Launchpad PQM Bot on 2015-09-07

[r=cjwatson][no-qa] Move "Latest upload:" onto the same row as
 "Architectures:".