Merge lp:~cjwatson/libfriends/recommend-friends-dispatcher into lp:libfriends

Proposed by Colin Watson
Status: Needs review
Proposed branch: lp:~cjwatson/libfriends/recommend-friends-dispatcher
Merge into: lp:libfriends
Diff against target: 13 lines (+2/-1)
1 file modified
debian/control (+2/-1)
To merge this branch: bzr merge lp:~cjwatson/libfriends/recommend-friends-dispatcher
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Super Friends Pending
Review via email: mp+213015@code.launchpad.net

Commit message

Drop friends-dispatcher to Recommends, to avoid pulling the run-time into cross-building chroots.

Description of the change

libfriends0 Depends: friends-dispatcher. I'm not normally a great fan of libraries declaring anything stronger than Suggests on run-time services, but I can sort of see the logic here since the dispatcher library will throw an error if it can't talk to the service. However, it causes practical problems.

The reason I care is that I'm trying to get "ubuntu-sdk-libs-dev:armhf" to be installable inside "click chroot" for the purpose of cross-building. libfriends0 is part of that set (via qtdeclarative5-friends0.2). Run-time services are unnecessary and unwanted, but they're normally harmless since we disable daemon startup inside "click chroot". However, in this case it isn't harmless, because friends-dispatcher depends on a number of gir* packages. gir* packages aren't currently multiarch-capable: the .typelib files differ across architectures but there's only one path available for their installation. This should probably be fixed, but it will take time. In the meantime, we need to be extra-careful to avoid requiring run-time services to be installed together with development packages, because that will cause an irreconcilable conflict in terms of which gir* packages should be installed.

I think a Recommends should be sufficient for all practical purposes - all the run-time packages that depend on libfriends0 already depend on friends as well anyway - and it will let us dodge this bullet.

See also: https://code.launchpad.net/~cjwatson/qml-friends/avoid-friends-dependency/+merge/213014

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Unmerged revisions

83. By Colin Watson

Drop friends-dispatcher to Recommends, to avoid pulling the run-time into cross-building chroots.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-11-07 14:47:35 +0000
3+++ debian/control 2014-03-27 10:32:25 +0000
4@@ -48,7 +48,8 @@
5 Architecture: any
6 Multi-Arch: same
7 Pre-Depends: ${misc:Pre-Depends}
8-Depends: friends-dispatcher, ${misc:Depends}, ${shlibs:Depends}
9+Depends: ${misc:Depends}, ${shlibs:Depends}
10+Recommends: friends-dispatcher
11 Description: Provides an API for accessing social networks
12 libfriends provides a library for accessing social networks via
13 friends.

Subscribers

People subscribed via source and target branches

to all changes: