~cjwatson/lp-signing:lpcraft

Last commit made on 2023-01-26
Get this branch:
git clone -b lpcraft https://git.launchpad.net/~cjwatson/lp-signing
Only Colin Watson can upload to this branch. If you are Colin Watson please log in for upload directions.

Branch merges

Branch information

Name:
lpcraft
Repository:
lp:~cjwatson/lp-signing

Recent commits

c60d867... by Colin Watson

Run tests via Launchpad CI jobs

This could be improved in a number of ways (e.g. using `tox`), but this
is enough to at least get us test runs on push.

Failed
[FAILED] test:0 (build)
11 of 1 result
9cc65a0... by Colin Watson

Reduce key validity period to 25 years

Merged from https://code.launchpad.net/~cjwatson/lp-signing/+git/lp-signing/+merge/432573

6f6c61e... by Colin Watson

Reduce key validity period to 25 years

Apparently some firmware has trouble with certificates that have 30
years of validity, but is fine with 25 years.

LP: #1995455

644896f... by Colin Watson

Avoid logging key descriptions

Merged from https://code.launchpad.net/~cjwatson/lp-signing/+git/lp-signing/+merge/416150

da478d3... by Colin Watson

Avoid logging key descriptions

Key descriptions often include PPA key names, which include
personally-identifying information (display names of users). We don't
really need to log those here - we can correlate request timestamps and
(at least in successful cases) generated/injected fingerprints with
other logs if we need to figure out which PPAs we're
generating/injecting keys for - so it's good practice to avoid logging
this PII so that we can retain logs for longer periods with clear
consciences.

7fe6d06... by Colin Watson

Log SHA-256 hashes of messages when signing them

Merged from https://code.launchpad.net/~cjwatson/lp-signing/+git/lp-signing/+merge/415561

164621c... by Jürgen Gmach

Hardcode /usr/bin/virtualenv path

Merged from https://code.launchpad.net/~jugmac00/lp-signing/+git/lp-signing/+merge/415784

da9ef3d... by Jürgen Gmach

Hardcode /usr/bin/virtualenv path

Some people may have a local virtualenv installation elsewhere on
`$PATH`, which is unlikely to work properly in a lp-signing container.

dcac01a... by Colin Watson

Log SHA-256 hashes of messages when signing them

Otherwise we have no way to trace back from logs to when a given message
was signed.

b0bf2b8... by Colin Watson

Add a basic pre-commit hook

Merged from https://code.launchpad.net/~cjwatson/lp-signing/+git/lp-signing/+merge/412314