Launchpad Dependencies

Merge lp:~cjwatson/meta-lp-deps/remove-subunit into lp:meta-lp-deps

  1. remove-subunit
  2. Merge into trunk
Proposed by Colin Watson
Status: Merged
Merged at revision: 228
Proposed branch: lp:~cjwatson/meta-lp-deps/remove-subunit
Merge into: lp:meta-lp-deps
Diff against target: 25 lines (+3/-1)
2 files modified
debian/changelog (+3/-0)
debian/control (+0/-1)
To merge this branch: bzr merge lp:~cjwatson/meta-lp-deps/remove-subunit
Reviewer Review Type Date Requested Status
Guruprasad Approve
Review via email: mp+429004@code.launchpad.net

Commit message

Remove Recommends on subunit.

Description of the change

zope.testrunner uses this from Launchpad's virtualenv, while buildbot workers use subunit-2to1 either from the system package on the worker host (currently) or the virtualenv (soon). In neither case is a Recommends from launchpad-developer-dependencies useful.

To post a comment you must log in.
Revision history for this message
Guruprasad (lgp171188) wrote :

LGTM 👍

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2022-08-25 11:54:30 +0000
3+++ debian/changelog 2022-08-26 15:40:31 +0000
4@@ -10,6 +10,9 @@
5 * Remove Recommends on pyflakes; we use pre-commit for lint checking
6 nowadays.
7 * Remove dependency on bzr.
8+ * Remove Recommends on subunit; zope.testrunner uses this from Launchpad's
9+ virtualenv, while buildbot workers use subunit-2to1 either from the
10+ system package on the worker host (currently) or the virtualenv (soon).
11
12 [ Andrey Fedoseev ]
13 * Add firefox-geckodriver to launchpad-developer-dependencies;
14
15=== modified file 'debian/control'
16--- debian/control 2022-08-25 11:54:30 +0000
17+++ debian/control 2022-08-26 15:40:31 +0000
18@@ -58,7 +58,6 @@
19 fakeroot, rsync, memcached,
20 xvfb, firefox, firefox-geckodriver, intltool,
21 ${misc:Depends}
22-Recommends: subunit
23 Suggests: apache2, libapache2-mod-wsgi
24 Description: Metapackage for development dependencies of Launchpad
25 This metapackage depends on all of the packages required to do development

Subscribers

People subscribed via source and target branches