Merge ~clinton-fung/launchpadlib:remove-indentation-parenthesis-in-url-output into launchpadlib:main
Status: | Needs review |
---|---|
Proposed branch: | ~clinton-fung/launchpadlib:remove-indentation-parenthesis-in-url-output |
Merge into: | launchpadlib:main |
Diff against target: |
13 lines (+1/-1) 1 file modified
src/launchpadlib/credentials.py (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Needs Information | ||
Review via email: mp+437567@code.launchpad.net |
Commit message
Remove indentation and parentheses when outputting URL for auth on the command-line, to make copy/paste easier and more predictable across platforms.
Description of the change
Currently, when executing `Launchpad.
This message looks something like:
```
The authorization page:
(https:/
should be opening in your browser. Use your browser to authorize
this program to access Launchpad on your behalf.
Waiting to hear from Launchpad about your decision...
```
It would be helpful if the indentation and parentheses around the URL were removed, to make copy/paste easier (and presumably to make the URL easier to read for machines in automation).
This change simply removes the indentation and parentheses.
Unmerged commits
- bf031cf... by Clinton Fung
-
lint:0 (build) tests:0 (build) 1 → 2 of 2 results First • Previous • Next • Last
I'd like to keep the indentation if possible (perhaps increased to two or four spaces), since it marks it out from the surrounding prose a bit more clearly. Both Firefox and Chromium trim leading spaces from URLs, presumably to make this sort of pattern work more easily, so I don't think that should be as much of a problem as the parentheses. Do you agree?