Ubuntu Documentation

Merge lp:~clissold345/ubuntu-docs/move-text-of-marginal-note into lp:~ubuntu-core-doc/ubuntu-docs/trunk2017-07-10

  1. move-text-of-marginal-note
  2. Merge into trunk2017-07-10
Proposed by Chris Perry
Status: Merged
Merged at revision: 557
Proposed branch: lp:~clissold345/ubuntu-docs/move-text-of-marginal-note
Merge into: lp:~ubuntu-core-doc/ubuntu-docs/trunk2017-07-10
Diff against target: 27 lines (+4/-6)
1 file modified
ubuntu-help/C/keyboard-layouts.page (+4/-6)
To merge this branch: bzr merge lp:~clissold345/ubuntu-docs/move-text-of-marginal-note
Reviewer Review Type Date Requested Status
Gunnar Hjalmarsson Approve
Review via email: mp+307913@code.launchpad.net

Description of the change

The "Add input sources" procedure was formatted to have a kind of "marginal note". I don't remember seeing any other procedures with marginal notes. I've deleted the marginal note and moved the text to immediately after the procedure. The objects in the list are sources not layouts so I changed the text to use the term "source". These are small changes but I think they make the page clearer.

I validated the Mallard files. No errors were reported.

To post a comment you must log in.
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Thanks Chris!

I hesitated as regards "source" instead of "layout", since it's actually a keyboard layout which is shown. Even if you add an IBus or Fcitx input source and click that icon, you just see a keyboard layout (typically the English (US) layout). I still decided to keep "source" as you suggested, to avoid jumping between the terms too much.

I made one small change when merging, though: The icon is available only when you have added a source, so it's actually not a preview. Hence I replaced "preview" with "view".

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-help/C/keyboard-layouts.page'
2--- ubuntu-help/C/keyboard-layouts.page 2016-03-17 16:51:18 +0000
3+++ ubuntu-help/C/keyboard-layouts.page 2016-10-07 08:01:25 +0000
4@@ -52,12 +52,6 @@
5 <section id="add">
6 <title>Add input sources</title>
7
8- <note style="sidebar">
9- <p>You can preview an image of any layout by selecting it in the list and clicking
10- <gui><media type="image" src="figures/input-keyboard-symbolic.svg" width="16" height="16">
11- preview</media></gui>.</p>
12- </note>
13-
14 <steps>
15 <item>
16 <p>Click the icon at the very right of the menu bar and select <gui>System Settings</gui>.</p>
17@@ -71,6 +65,10 @@
18 </item>
19 </steps>
20
21+ <p>You can preview an image of any source by selecting it in the list and clicking
22+ <gui><media type="image" src="figures/input-keyboard-symbolic.svg" width="16" height="16">
23+ preview</media></gui>.</p>
24+
25 <p>The default source is the source at the top of the list. Use the
26 <gui>↑</gui> and <gui>↓</gui> buttons to move sources up and down in
27 the list.</p>

Subscribers

People subscribed via source and target branches