Merge lp:~clissold345/ubuntu-docs/revision-of-volumes-and-partitions-page into lp:~ubuntu-core-doc/ubuntu-docs/trunk2017-07-10

Proposed by Chris Perry
Status: Merged
Merged at revision: 592
Proposed branch: lp:~clissold345/ubuntu-docs/revision-of-volumes-and-partitions-page
Merge into: lp:~ubuntu-core-doc/ubuntu-docs/trunk2017-07-10
Diff against target: 177 lines (+36/-65)
2 files modified
ubuntu-help/C/disk-capacity.page (+23/-53)
ubuntu-help/C/disk-partitions.page (+13/-12)
To merge this branch: bzr merge lp:~clissold345/ubuntu-docs/revision-of-volumes-and-partitions-page
Reviewer Review Type Date Requested Status
Gunnar Hjalmarsson Approve
Review via email: mp+314289@code.launchpad.net

Description of the change

I needed to revise this page because the Disks application is now used to manage volumes and partitions. In a few places the text was incorrect so I had to change it. In a few places the text was a bit verbose (in my opinion) so I made a few minor cuts. In a few places the text was a bit confusing (eg it used "tools" and "utilities" to refer to the same thing) so I made a few minor corrections.

I'll have a quick look round the desktop help to see if any other pages are impacted by the changes to the Disks gui. If I can't find any such pages I'll propose marking the bug (Bug #1651360) "Fix Committed".

To post a comment you must log in.
Revision history for this message
Chris Perry (clissold345) wrote :

Here's a new revision 592. It's got everything from the old revision 592 in it, plus I made a correction to the desc field in disk-partitions.page, plus I changed disk-capacity.page (as discussed by email with Doug yesterday).

Regarding disk-capacity.page: could we give the user some indication of what "too full" means? Over 90% full they should consider taking action?

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Thinking... Three methods to do approximately the same thing. Doesn't that give our desktop guide a bias towards disk analyzing?

They are all GNOME tools, they are all installed on Ubuntu by default, and the current wording of disk-capacity.page is similar to the GNOME equivalent:

https://help.gnome.org/users/gnome-help/stable/disk-capacity.html.en

Before adding this third way, I think it would be a good idea to ask some GNOME person if it's just a coincidence that Disks isn't mentioned on that page. Jeremy Bicha, who is deeply involved in Ubuntu GNOME, might be able to shed some light on it.

review: Needs Information
Revision history for this message
Doug Smythies (dsmythies) wrote :

For my part of it (from the e-mail thread), I thought the existing two methods looked the easiest, which is why I suggested the addition be listed third.

Revision history for this message
Chris Perry (clissold345) wrote :

I'll have a think about disk-capacity.page and probably make some suggestions about how to improve it. (I don't think it's a very good page - but I wasn't greatly concerned to improve it, I mainly just wanted Disks mentioned.)

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Maybe there is a preferred way, given the GNOME plans, in which case we should focus on that one. That's one thing which Jeremy might know. (An easy way to involve him would we to subscribe him to your branch.)

Revision history for this message
Chris Perry (clissold345) wrote :

Well I've subscribed Jeremy to the branch. I hope I've done it right.

Hi Jeremy, do you have a view on how to revise disk-capacity.html? The current released version is here:

https://help.ubuntu.com/stable/ubuntu-help/disk-capacity.html

I'll post another comment about this shortly (in about ten minutes).

Revision history for this message
Chris Perry (clissold345) wrote :

I'd like to rewrite disk-capacity.html as one procedure (and I think it would be a short procedure). This would mean that the page was similar in style to many of the other task-orientated pages in the desktop help.

If the task of the page is to check disk usage and if necessary free up space, then the procedure would be something like this: Open application XXX (I prefer Disks myself but I don't think it greatly matters which application the user uses to check disk usage) from the Dash and check disk usage, if the disk is "too full" (what does that mean?), free up space by either deleting files that you don't need any more or backing up important files and deleting them.

The procedure can be applied to any disk/volume not just a volume on a hard drive, so I think it's worth generalizing the procedure slightly to make that clear.

Revision history for this message
Jeremy Bícha (jbicha) wrote :

I don't really work on the Docs teams these days so these are just my opinions and not a formal review.

I'm not aware of plans to drop the Disks or Disk Usage Analyzer apps from the default GNOME install (although that could be done by distros if they wanted).

My opinion is that pages like this that are clearly nearly the same behavior as GNOME should be kept in near-sync with GNOME. (Replace "Open the Activities Overview" with "Open the Dash", etc.).

So, my recommendation is to submit a tweaked version of this change to the GNOME Docs team.

Other suggestions:
- Try to keep the line length short. There's not a formal 80-character line limit like some projects but the lines you add or change shouldn't be much longer than other lines.
- Use the Unicode single-character ellipsis (…) rather than three separate characters (...)
- While I liked the idea of using the same page for both Unity and GNOME with the if: conditional and submitted a bunch of that to GNOME, my changes were reverted there. I think it was because it added extra work (and some confusion) for GNOME translators and made the pages more difficult to read for those working with the Mallard source. Also, the if: conditional didn't work for page titles or for images I believe. Therefore, there still would need to be 2 Ubuntu packages: one for GNOME and one for Unity.
- I don't think a merge from gnome-user-docs has been done since I last did it a few years ago. I strongly recommend using the Meld app if someone wants to work on that large project.

Revision history for this message
Doug Smythies (dsmythies) wrote :

Jeremy wrote:

> - I don't think a merge from gnome-user-docs has been done since I last did it a few years ago.

There has been one since, led by Kevin Godby, although a lot of us helped.

Revision history for this message
Chris Perry (clissold345) wrote :

Hi guys, I take note of some of the things that Jeremy wrote (eg if I change disk-capacity.page (and it's approved) I'm fine to email the new page to the Gnome help team so they can use it if they want to).

However, I can't see that a general discussion of Gnome help/Ubuntu help affects my opinion of disk-capacity.page. The change I'm proposing seems to me an obvious (minor) improvement to the Ubuntu help. I'll do a draft (rather than again describing what I want to do). Hopefully it will then be clear that it's a minor change. Note: I'm not assuming the draft will be approved. If anyone can give strong reasons against it, I'll throw it away.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

I like the idea to make the page more task-orientated. If you change it in that direction, you'll address my concerns above.

Revision history for this message
Chris Perry (clissold345) wrote :

Here's another revision 592. I hope you weren't expecting the changes to disk-capacity.page to be very exciting!

I've written the instructions a bit more generally than before. Eg a disk may have more than one data volume on it.

I've sometimes written "disk/volume" as an attempt to remind the user that strictly speaking we're not talking about disks, we're talking about volumes.

I think the list in "What if the disk is too full?" should be a bulleted list since it's not a procedure (= steps that have to be done sequentially).

I'm thinking of adding a brief mention of Disk Usage Analyzer in "What if the disk is too full?" since it can help the user find the big files.

I'm away until Monday so I won't be doing any more drafts until then.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Ok, thanks Chris.

I must admit that I have almost no own experience of using any of the tools in question. But if I understand it correctly, both Disks and System Monitor can be used to display utilization at a high level, i.e. per partition. It's similar to the df terminal command, if I understand it correctly. Now you picked Disks over System Monitor, and that's fine with me.

Disk Usage Analyzer seems to be quite different. It allows you to pick either a whole partition or part of it and browse the disk usage per folder. Seems to be more like the du terminal command.

So yes, I think that a brief mention of Disk Usage Analyzer is motivated. Maybe something along:

"Disk Usage Analyzer, which allows you to view disk usage per folder, can be used for a more low level examination."

and then include the link to help:baobab. (I'm sure it can be better worded.)

With such an addition I think we achieve an improvement.

592. By Chris Perry

Revision of volumes and partitions page etc

Revision history for this message
Chris Perry (clissold345) wrote :

Hi Gunnar, thanks for taking the time to review this.

I've kept the mention of Disk Usage Analyzer very brief because using Disk Usage Analyzer isn't essential to the task in hand (but it could be useful).

Terminology: "back up" is the verb and "backup" is the noun.

I think the new page will be a significant improvement on the old page (though I'm not claiming it's a revolutionary improvement).

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Looks good now.

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-help/C/disk-capacity.page'
2--- ubuntu-help/C/disk-capacity.page 2016-12-16 20:44:56 +0000
3+++ ubuntu-help/C/disk-capacity.page 2017-01-17 10:27:24 +0000
4@@ -21,88 +21,58 @@
5 <revision pkgversion="3.4.3" date="2012-06-15" status="review"/>
6 <revision version="13.10" date="2013-09-07" status="review"/>
7
8- <desc>Use <gui>Disk Usage Analyzer</gui> or <gui>System Monitor</gui> to
9- check space and capacity.</desc>
10+ <desc>Use <gui>Disks</gui> to check free space on a given disk/volume.</desc>
11+
12 <include href="legal.xml" xmlns="http://www.w3.org/2001/XInclude"/>
13 </info>
14
15 <title>Check how much disk space is left</title>
16
17- <p>You can check how much disk space is left with <app>Disk Usage Analyzer</app>
18- or <app>System Monitor</app>.</p>
19-
20-<section id="disk-usage-analyzer">
21-<title>Check with Disk Usage Analyzer</title>
22-
23- <p>To check the free disk space and disk capacity using
24- <app>Disk Usage Analyzer</app>:</p>
25+
26+ <p>To check free space on a given disk/volume:</p>
27
28 <steps>
29+
30 <item>
31 <if:choose>
32 <if:when test="platform:unity">
33- <p>Open the <app>Disk Usage Analyzer</app> application from the
34- <gui>Dash</gui>. The window will display the <gui>Total file system capacity</gui>
35- and <gui>Total file system usage</gui>.</p>
36+ <p>Open the <app>Disks</app> application from the <gui>Dash</gui>.</p>
37 </if:when>
38 <p>Open the <app>Disks</app> application from the <gui>Activities</gui>
39- overview. The window will display the <gui>Total file system capacity</gui>
40- and <gui>Total file system usage</gui>.</p>
41-</if:choose>
42- </item>
43- <item>
44- <p>Click one of the toolbar buttons to choose to <gui>Scan Home</gui>,
45- <gui>Scan filesystem</gui>, <gui>Scan a folder</gui>, or <gui>Scan a remote
46- folder</gui>.</p>
47- </item>
48-</steps>
49-
50- <p>The information is displayed according to <gui>Folder</gui>, <gui>Usage</gui>,
51- <gui>Size</gui> and <gui>Contents</gui>. See more details in
52- <link href="help:baobab"><app>Disk Usage Analyzer</app></link>.</p>
53-
54-</section>
55-
56-<section id="system-monitor">
57-
58-<title>Check with System Monitor</title>
59-
60- <p>To check the free disk space and disk capacity with <app>System Monitor</app>:</p>
61-
62-<steps>
63- <item>
64-<if:choose>
65-<if:when test="platform:unity">
66- <p>Open the <app>System Monitor</app> application from the <gui>Dash</gui>.</p>
67-</if:when>
68- <p>Open the <app>System Monitor</app> application from the <gui>Activities</gui>
69 overview.</p>
70 </if:choose>
71 </item>
72- <item>
73- <p>Select the <gui>File Systems</gui> tab to view the system's partitions and
74- disk space usage. The information is displayed according to <gui>Total</gui>,
75- <gui>Free</gui>, <gui>Available</gui> and <gui>Used</gui>.</p>
76- </item>
77+
78+ <item><p>In the left pane select the disk that you want to check.</p></item>
79+
80+ <item><p>In the right pane select the volume that you want to check. The <gui>Size</gui> field
81+ displays the volume size. If the volume is a data volume, the <gui>Size</gui> field also displays the amount of free space
82+ and the percentage used.</p></item>
83+
84 </steps>
85
86-</section>
87-
88 <section id="disk-full">
89
90 <title>What if the disk is too full?</title>
91
92- <p>If the disk is too full you should:</p>
93+ <p>When a disk/volume is considered "too full" depends on various factors, including the size of the disk and how fast you're filling it up.
94+ You might want to free up space if the disk/volume is more than 90% full.</p>
95+
96+ <p>To free up space you can:</p>
97
98 <list type="disc">
99 <item>
100- <p>Delete files that aren't important or that you won't use anymore.</p>
101+ <p>Delete files that aren't important or that you won't use anymore, or</p>
102 </item>
103 <item>
104 <p>Make <link xref="backup-why">backups</link> of the important files that
105- you won't need for a while and delete them from the hard drive.</p>
106+ you won't need for a while and delete them from the disk.</p>
107 </item>
108 </list>
109+
110+<p>You can use <link href="help:baobab"><app>Disk Usage Analyzer</app></link>
111+ to help identify which files to delete or back up.</p>
112+
113 </section>
114
115 </page>
116
117=== modified file 'ubuntu-help/C/disk-partitions.page'
118--- ubuntu-help/C/disk-partitions.page 2013-10-24 03:29:17 +0000
119+++ ubuntu-help/C/disk-partitions.page 2017-01-17 10:27:24 +0000
120@@ -12,8 +12,9 @@
121
122 <revision pkgversion="3.4.0" date="2012-02-19" status="review"/>
123 <revision version="13.10" date="2013-10-23" status="review"/>
124- <desc>Understand what volumes and partitions are and use the disk utility
125- to manage them.</desc>
126+
127+ <desc>Understand what volumes and partitions are and use the Disks application to manage them.</desc>
128+
129 <include href="legal.xml" xmlns="http://www.w3.org/2001/XInclude"/>
130 </info>
131
132@@ -35,26 +36,27 @@
133 rooms” of partitions and drives.</p>
134
135 <section id="manage">
136- <title>View and manage volumes and partitions using the disk utility</title>
137+ <title>View and manage volumes and partitions</title>
138
139- <p>You can check and modify your computer's storage volumes with the disk
140- utility.</p>
141+ <p>To view and manage your computer's volumes and partitions:</p>
142
143 <steps>
144 <item>
145- <p>Open the <gui>Dash</gui> and start the <app>Disk Utility</app> application.</p>
146+ <p>Open <app>Disks</app> from the <gui>Dash</gui>.</p>
147 </item>
148 <item>
149- <p> In the pane marked <gui>Storage Devices</gui>, you will find hard disks,
150- CD/DVD drives, and other physical devices. Click the device you want to
151+ <p> In the left pane, you will find a list of hard disks,
152+ CD/DVD drives, and other physical devices. Select the device that you want to
153 inspect.</p>
154 </item>
155 <item>
156 <p> In the right pane, the area labeled <gui>Volumes</gui> provides a visual
157 breakdown of the volumes and partitions present on the selected device. It
158 also contains a variety of tools used to manage these volumes.</p>
159+
160 <p>Be careful: it is possible to completely erase the data on your disk with
161- these utilities.</p>
162+ these tools.</p>
163+
164 </item>
165 </steps>
166
167@@ -67,9 +69,8 @@
168
169 <p>One primary partition must contain information that your computer uses to
170 start up, or <em>boot</em>. For this reason it is sometimes called a boot
171- partition, or boot volume. To determine if a volume is bootable, look at its
172- <gui>Partition Flags</gui> in the disk utility. External media such as USB
173- drives and CDs may also contain a bootable volume.</p>
174+ partition, or boot volume. If a volume is bootable, the information displayed will say: "Partition Type ... (Bootable)".
175+ External media such as USB flash drives and CDs may also contain a bootable volume.</p>
176
177 </section>
178

Subscribers

People subscribed via source and target branches