Ubuntu Documentation

Merge lp:~clissold345/ubuntu-docs/small-changes-relating-to-installing-applications-and-adding-repositories into lp:~ubuntu-core-doc/ubuntu-docs/trunk2017-07-10

  1. small-changes-relating-to-installing-applications-and-adding-repositories
  2. Merge into trunk2017-07-10
Proposed by Chris Perry
Status: Merged
Merged at revision: 569
Proposed branch: lp:~clissold345/ubuntu-docs/small-changes-relating-to-installing-applications-and-adding-repositories
Merge into: lp:~ubuntu-core-doc/ubuntu-docs/trunk2017-07-10
Diff against target: 62 lines (+12/-9)
2 files modified
ubuntu-help/C/addremove-sources.page (+8/-5)
ubuntu-help/C/addremove.page (+4/-4)
To merge this branch: bzr merge lp:~clissold345/ubuntu-docs/small-changes-relating-to-installing-applications-and-adding-repositories
Reviewer Review Type Date Requested Status
Gunnar Hjalmarsson Approve
Review via email: mp+310266@code.launchpad.net

Description of the change

I've made various small changes relating to installing applications and adding repositories. None of the changes are technical changes.

Terminology: you "install" an application but you "add" a repository.

The original writer seemed to be keen to emphasise that one already has repositories before one adds any, so wrote "add additional repositories". I've simplified this.

The summary description for one of the pages had links in it, which I've removed.

One of the procedures had a title defined within it, which I've removed. I added an empty paragraph to improve the spacing between the warning and the procedure.

To post a comment you must log in.
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

I agree that "extra" or "additional" doesn't need to be repeated, and those changes look good.

But the change between <desc></desc> on addremove.page is not good. Those links appear on index.page, and are needed to maintain the 'style' compared to the other index.page groups.

review: Needs Fixing
lp:~clissold345/ubuntu-docs/small-changes-relating-to-installing-applications-and-adding-repositories updated
569. By Chris Perry

Corrected the index terms

Revision history for this message
Chris Perry (clissold345) wrote :

Sorry about that! I hadn't studied the help properly and I didn't realise that the "menu" pages don't have a summary description they have what I would call a list of index terms.

I don't think index terms "install, remove, add repositories" works, since the noun doesn't apply to all the verbs. I suggest "install applications, remove applications, add repositories".

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Looks good now; please feel free to merge it yourself. ;)

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-help/C/addremove-sources.page'
2--- ubuntu-help/C/addremove-sources.page 2016-10-17 19:21:42 +0000
3+++ ubuntu-help/C/addremove-sources.page 2016-11-08 21:09:07 +0000
4@@ -8,7 +8,7 @@
5 <name>Ubuntu Documentation Team</name>
6 </credit>
7 <desc>
8- Add other repositories to extend the software sources Ubuntu uses for
9+ Add repositories to extend the software sources Ubuntu uses for
10 installation and upgrades.
11 </desc>
12 <include href="legal.xml" xmlns="http://www.w3.org/2001/XInclude"/>
13@@ -17,7 +17,7 @@
14 </info>
15
16 <title>
17- Add additional software repositories
18+ Add software repositories
19 </title>
20
21 <p>
22@@ -38,10 +38,13 @@
23 </p>
24 </note>
25
26+<p>
27+</p>
28+ <p>
29+ To add a repository:
30+ </p>
31+
32 <steps>
33- <title>
34- Install other repositories
35- </title>
36 <item>
37 <p>
38 Click the <app>Ubuntu Software</app> icon in the <gui>Launcher</gui>, or search
39
40=== modified file 'ubuntu-help/C/addremove.page'
41--- ubuntu-help/C/addremove.page 2014-01-08 04:17:56 +0000
42+++ ubuntu-help/C/addremove.page 2016-11-08 21:09:07 +0000
43@@ -12,15 +12,15 @@
44 </credit>
45
46 <desc>
47- <link xref="addremove-install">Install</link>,
48- <link xref="addremove-remove">remove</link>,
49- <link xref="addremove-sources">extra repositories</link>…
50+ <link xref="addremove-install">Install applications</link>,
51+ <link xref="addremove-remove">remove applications</link>,
52+ <link xref="addremove-sources">add repositories</link>…
53 </desc>
54
55 <include href="legal.xml" xmlns="http://www.w3.org/2001/XInclude"/>
56 </info>
57
58- <title>Add &amp; remove software</title>
59+ <title>Install &amp; remove software</title>
60 <links type="topic" style="2column"/>
61
62 </page>

Subscribers

People subscribed via source and target branches