desktopcouch

Merge lp:~cmiller/desktopcouch/couchdb-breaks-basic-auth into lp:desktopcouch

  1. couchdb-breaks-basic-auth
  2. Merge into trunk
Proposed by Chad Miller
Status: Merged
Approved by: Chad Miller
Approved revision: 166
Merged at revision: 166
Proposed branch: lp:~cmiller/desktopcouch/couchdb-breaks-basic-auth
Merge into: lp:desktopcouch
Diff against target: 11 lines (+1/-0)
1 file modified
desktopcouch/local_files.py (+1/-0)
To merge this branch: bzr merge lp:~cmiller/desktopcouch/couchdb-breaks-basic-auth
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Needs Information
Review via email: mp+29821@code.launchpad.net

Commit message

Support new Basic auth for HTTP that our bookmark file requires. (LP: #599745)

To post a comment you must log in.
Revision history for this message
Manuel de la Peña (mandel) wrote :

Looks good to me, just one question, why are you setting the authentication realm to be administrator?

review: Needs Information
Revision history for this message
Chad Miller (cmiller) wrote :

No reason, Manuel. It has to be something. I don't think the choice is very important, since the user should never see a password dialog that mentions it.

Revision history for this message
Elliot Murphy (statik) wrote :

On Wed, Jul 14, 2010 at 10:01 AM, Chad Miller <email address hidden> wrote:
> No reason, Manuel.  It has to be something.  I don't think the choice is very important, since the user should never see a password dialog that mentions it.

How about 'unused' instead of 'administrator' in order to preemptively
answer this question for future readers of the code?
--
Elliot Murphy | https://launchpad.net/~statik/

lp:~cmiller/desktopcouch/couchdb-breaks-basic-auth updated
166. By Chad Miller

Use a more descriptive name for the HTTP Basic auth realm.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'desktopcouch/local_files.py'
2--- desktopcouch/local_files.py 2010-05-25 14:05:00 +0000
3+++ desktopcouch/local_files.py 2010-07-14 21:05:56 +0000
4@@ -75,6 +75,7 @@
5 'httpd': {
6 'bind_address': '127.0.0.1',
7 'port': '0',
8+ 'WWW-Authenticate': 'Basic realm="bookmarkable-user-auth"'
9 },
10 'log': {
11 'file': ctx.file_log,

Subscribers

People subscribed via source and target branches