Launchpad itself

Merge ~cristiangsp/launchpad:fixing-widgetsjs-linting into launchpad:master

  1. Git
  2. lp:~cristiangsp/launchpad
  3. fixing-widgetsjs-linting
  4. Merge into master
Proposed by Cristian Gonzalez
Status: Merged
Approved by: Cristian Gonzalez
Approved revision: 63b261a1ee02f1121aa1466e4b87f95f0f2b32ec
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cristiangsp/launchpad:fixing-widgetsjs-linting
Merge into: launchpad:master
Diff against target: 25 lines (+9/-5)
1 file modified
lib/lp/registry/javascript/distroseries/widgets.js (+9/-5)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+406985@code.launchpad.net

Commit message

Fixing widgets.js linting

Description of the change

Fixing widgets.js linting

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/registry/javascript/distroseries/widgets.js b/lib/lp/registry/javascript/distroseries/widgets.js
2index db4c9eb..cf22fbc 100644
3--- a/lib/lp/registry/javascript/distroseries/widgets.js
4+++ b/lib/lp/registry/javascript/distroseries/widgets.js
5@@ -436,11 +436,15 @@ Y.extend(ArchitecturesChoiceListWidget, formwidgets.ChoiceListWidget, {
6 }
7 var ds;
8 for (ds in this._archindep_tags) {
9- var arch_tag = this._archindep_tags[ds];
10- var i = 0;
11- for (i; i<choices.length; i++) {
12- if (Y.Lang.isValue(choices[i]) && choices[i] === arch_tag) {
13- return true;
14+ if (
15+ Object.prototype.hasOwnProperty.call(this._archindep_tags, ds)
16+ ) {
17+ var arch_tag = this._archindep_tags[ds];
18+ var i = 0;
19+ for (i; i<choices.length; i++) {
20+ if (Y.Lang.isValue(choices[i]) && choices[i] === arch_tag) {
21+ return true;
22+ }
23 }
24 }
25 }

Subscribers

People subscribed via source and target branches

to status/vote changes: