loggerhead

Merge lp:~cruzjbishop/loggerhead/bug-990217 into lp:loggerhead

  1. bug-990217
  2. Merge into trunk-rich
Proposed by Cruz Bishop
Status: Merged
Approved by: Richard Harding
Approved revision: 476
Merged at revision: 481
Proposed branch: lp:~cruzjbishop/loggerhead/bug-990217
Merge into: lp:loggerhead
Diff against target: 12 lines (+1/-1)
1 file modified
loggerhead/util.py (+1/-1)
To merge this branch: bzr merge lp:~cruzjbishop/loggerhead/bug-990217
Reviewer Review Type Date Requested Status
Richard Harding (community) code Approve
Review via email: mp+103966@code.launchpad.net

Description of the change

Fixes bug #990217, changing the formatting for files under 1 kilobyte.

Previously, only files up to 511 bytes in size were shows as "x bytes" - Now that is chagned to 1023 (as 1024 bytes makes a kilobyte, not 512)

Image: http://i.imgur.com/ugMNA.png

To post a comment you must log in.
Revision history for this message
Richard Harding (rharding) :
review: Approve (code)
Revision history for this message
Cruz Bishop (cruzjbishop) wrote :

Hi,

I was just wondering if there were any updates on this. I happened to be looking through my branches randomly and noticed that this was still marked as pending, so here I am, checking on it :)

Revision history for this message
Richard Harding (rharding) wrote :

> I was just wondering if there were any updates on this. I happened to be
> looking through my branches randomly and noticed that this was still marked as
> pending, so here I am, checking on it :)

Sorry, I had approved it, but didn't update the overall Status. It's approved.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loggerhead/util.py'
2--- loggerhead/util.py 2012-04-25 23:39:35 +0000
3+++ loggerhead/util.py 2012-04-28 01:01:19 +0000
4@@ -333,7 +333,7 @@
5 size = int(size)
6 if (size == 0) and (min_divisor == 0):
7 return 'Empty'
8- if (size < 512) and (min_divisor == 0):
9+ if (size < 1024) and (min_divisor == 0):
10 return str(size) + ' bytes'
11
12 if (size >= P95_GIG) or (min_divisor >= GIG):

Subscribers

People subscribed via source and target branches