loggerhead

Merge lp:~cruzjbishop/loggerhead/ui-changes into lp:loggerhead

  1. ui-changes
  2. Merge into trunk-rich
Proposed by Cruz Bishop
Status: Merged
Merged at revision: 471
Proposed branch: lp:~cruzjbishop/loggerhead/ui-changes
Merge into: lp:loggerhead
Diff against target: 27 lines (+3/-0)
1 file modified
loggerhead/static/css/diff.css (+3/-0)
To merge this branch: bzr merge lp:~cruzjbishop/loggerhead/ui-changes
Reviewer Review Type Date Requested Status
j.c.sackett (community) Approve
Richard Harding (community) code* Approve
Curtis Hovey Pending
Review via email: mp+95090@code.launchpad.net

Commit message

Some small UI changes

Extra border at the bottom of file diffs
Rounded borders

Description of the change

Some minor UI changes.

1: Rounded borders on the info box
2: Border at the bottom of each file diff, in order to properly show the end of each file when scrolled to the right / reading the right hand side
3: Rounded the borders at the top of each file diff's header

Screenshots: (Used one of my project repositories to test it)

http://imgur.com/a/C7jNL

To post a comment you must log in.
Revision history for this message
Cruz Bishop (cruzjbishop) wrote :

Please note that you may have to clear the browser's cache to see any changes.

Revision history for this message
Richard Harding (rharding) wrote :

Cruz, can you please attach a screenshot of the changes for the merge proposal? Technically the changes look ok, but I'm going to have curtis review as well as an official UI reviewer.

review: Approve (code*)
Revision history for this message
j.c.sackett (jcsackett) wrote :

I'm glad to see diffs replacing the browser-specific rounded corners with the css3 defaults, since we're finally moving to those.

Thanks.

review: Approve
Revision history for this message
Cruz Bishop (cruzjbishop) wrote :

Sure, I'll just be a few minutes

Revision history for this message
Cruz Bishop (cruzjbishop) wrote :

Hi Richard,

I added a link to a 'gallery' of screenshots. I can't see any link to directly attach them, so let's hope you can all access it! :)

Thank you both

Revision history for this message
j.c.sackett (jcsackett) wrote :

Cruz--

Curtis took a look, but since I have this open right now I'm commenting.

We would like to standardize on 5px for the rounded edges in both LP and loggerhead. Could you please set that to 5px in this branch, and then I will land it for you?

review: Needs Fixing
Revision history for this message
j.c.sackett (jcsackett) wrote :

I misread the diff earlier. We can also probably drop the -webkit and -moz properties; the official property has been adopted by mozilla and webkit.

Revision history for this message
Cruz Bishop (cruzjbishop) wrote :

Sure thing, I'll do those now

lp:~cruzjbishop/loggerhead/ui-changes updated
477. By Cruz Bishop

Fixes for Curtis and J.C.Sackett

478. By Cruz Bishop

Get rid of some white space

Revision history for this message
j.c.sackett (jcsackett) wrote :

Thanks, this looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loggerhead/static/css/diff.css'
2--- loggerhead/static/css/diff.css 2012-02-22 08:43:19 +0000
3+++ loggerhead/static/css/diff.css 2012-03-09 06:16:18 +0000
4@@ -6,6 +6,7 @@
5 color: #666;
6 background: #fcfcfc url(../images/bg_infobox.gif) repeat-y top right;
7 border: 1px solid #b7b7b7;
8+ border-radius: 5px;
9 }
10 ul#list-files {
11 float: right;
12@@ -37,6 +38,7 @@
13 background: #eef6fa;
14 border: 1px solid #d2d2d2;
15 margin: 10px 0 0 0;
16+ border-radius: 5px 5px 5px 0px;
17 }
18 .diffBox img {
19 vertical-align: middle;
20@@ -49,6 +51,7 @@
21 }
22 .diffinfo {
23 overflow: hidden;
24+ border-bottom: 1px solid #d5d5d5;
25 }
26 .lineNumber {
27 width: 2%;

Subscribers

People subscribed via source and target branches