Merge lp:~danilo/launchpad/bug-493629 into lp:launchpad

Proposed by Данило Шеган
Status: Merged
Approved by: Данило Шеган
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~danilo/launchpad/bug-493629
Merge into: lp:launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
lib/lp/translations/windmill/tests/test_productseries_templates.py (+1/-1)
To merge this branch: bzr merge lp:~danilo/launchpad/bug-493629
Reviewer Review Type Date Requested Status
Guilherme Salgado (community) code Approve
Review via email: mp+15758@code.launchpad.net

Commit message

Do not directly assert node existence in windmill tests but instead wait for them to appear.

To post a comment you must log in.
Revision history for this message
Данило Шеган (danilo) wrote :

= Bug #493629 =

Do not directly assert node existence but instead wait for them to appear. Hopefully fixes issues on 'make jscheck' buildbot.

= Tests =

bin/test -D -vv --layer=TranslationsWindmillLayer -t productseries_templates

Revision history for this message
Guilherme Salgado (salgado) wrote :

looks good

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/translations/windmill/tests/test_productseries_templates.py'
2--- lib/lp/translations/windmill/tests/test_productseries_templates.py 2009-10-30 17:09:59 +0000
3+++ lib/lp/translations/windmill/tests/test_productseries_templates.py 2009-12-07 17:45:24 +0000
4@@ -55,7 +55,7 @@
5 client.waits.forElement(id=u'templates_table', timeout=u'8000')
6 # All links are inactive to start with.
7 for row_num in range(self.MAX_ROW):
8- client.asserts.assertNode(
9+ client.waits.forElement(
10 xpath=self._xpath_action_links(row_num, active=False))
11
12 # Action links are activated when the mouse is over the row.