Merge lp:~danilo/launchpad/no-dummy-psl into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Robert Collins |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11182 |
Proposed branch: | lp:~danilo/launchpad/no-dummy-psl |
Merge into: | lp:launchpad |
Diff against target: |
409 lines (+61/-85) 7 files modified
lib/lp/translations/browser/productseries.py (+7/-7) lib/lp/translations/browser/tests/test_breadcrumbs.py (+26/-12) lib/lp/translations/configure.zcml (+1/-6) lib/lp/translations/doc/canonical_url_examples.txt (+6/-5) lib/lp/translations/interfaces/productserieslanguage.py (+2/-7) lib/lp/translations/model/productserieslanguage.py (+12/-44) lib/lp/translations/tests/test_productserieslanguage.py (+7/-4) |
To merge this branch: | bzr merge lp:~danilo/launchpad/no-dummy-psl |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins (community) | Approve | ||
Review via email: mp+30293@code.launchpad.net |
Commit message
Get rid of DummyProductSer
Description of the change
= Get rid of dummy ProductSeriesLa
When ProductSeriesLa
As part of reworking ISeriesLanguage interface to be more generic and re-usable, this is a refactoring branch that gets rid of the DummyProductSer
= Tests =
bin/test -cvvt productseriesla
(we just confirm everything works as it used to: existing tests cover all the cases where we were using dummies, and the dummy_ProductSe
= QA =
https:/
https:/
Both work in identical way to how they work today, but we've got less code for a net win.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/