Merge lp:~deryck/launchpad/fix-heat-help-link into lp:launchpad
| Status: | Merged |
|---|---|
| Approved by: | Curtis Hovey |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 11146 |
| Proposed branch: | lp:~deryck/launchpad/fix-heat-help-link |
| Merge into: | lp:launchpad |
| Diff against target: |
17 lines (+3/-3) 1 file modified
lib/lp/bugs/help/bug-heat.html (+3/-3) |
| To merge this branch: | bzr merge lp:~deryck/launchpad/fix-heat-help-link |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Curtis Hovey (community) | Approve | ||
| Matthew Revell (community) | text | Approve | |
|
Review via email:
|
|||
Commit message
The help pop-up for bug heat will now link to the stored procedure in code browse.
Description of the change
Once we moved the code to calculate bug heat from pure Python to plpython,
the link to the file in the bug heat help pop-up was broken. This small
branch fixes that link.
Since the method is buried in the large file trusted.sql and the line
numbers can change with additions to the file, I decided to change the
langauge around the link to make the link hardened against these kinds of
future changes. This does make it harder to directly link to the function,
which makes it harder for the user to find. But there's the trade off
between constantly updating this link and discoverability. I'm completely
open to other linking or language suggestions.
Current link now reads:
To view the code that calculates bug heat, look for
calculate_bug_heat in the file trusted.sql
Where trusted.sql links to:
http://
Cheers,
deryck
The text reads well to me.