Launchpad itself

Merge lp:~deryck/launchpad/show-package-hot-bugs-455995 into lp:launchpad

  1. show-package-hot-bugs-455995
  2. Merge into devel
Proposed by Deryck Hodge
Status: Merged
Approved by: Deryck Hodge
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~deryck/launchpad/show-package-hot-bugs-455995
Merge into: lp:launchpad
Diff against target: 31 lines (+10/-1)
1 file modified
lib/lp/bugs/templates/bugtarget-bugs.pt (+10/-1)
To merge this branch: bzr merge lp:~deryck/launchpad/show-package-hot-bugs-455995
Reviewer Review Type Date Requested Status
Eleanor Berger (community) Approve
Review via email: mp+17675@code.launchpad.net

Commit message

Show package name in hot bugs list for distributions.

To post a comment you must log in.
Revision history for this message
Deryck Hodge (deryck) wrote :

This branch fixes bug 455995, which notes that a hot bugs list for a
distro bugs home page doesn't show the package name. The fix for this
is to test that we should be showing the column using
view.columns_to_show and add the column if so.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/bugs/templates/bugtarget-bugs.pt

Revision history for this message
Eleanor Berger (intellectronica) wrote :

lovely!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/templates/bugtarget-bugs.pt'
2--- lib/lp/bugs/templates/bugtarget-bugs.pt 2009-12-19 19:12:34 +0000
3+++ lib/lp/bugs/templates/bugtarget-bugs.pt 2010-01-19 18:15:24 +0000
4@@ -103,10 +103,16 @@
5
6 <h2 style="margin-top: 1em">Hot bugs</h2>
7
8- <table class="listing" id="hot-bugs">
9+ <table class="listing" id="hot-bugs"
10+ tal:define="show_package python: 'packagename' in view.columns_to_show
11+ ">
12 <thead>
13 <tr>
14 <th colspan="3">Summary</th>
15+ <th
16+ tal:condition="show_package">
17+ Package
18+ </th>
19 <th>Status</th>
20 <th>Importance</th>
21 <th>Last changed</th>
22@@ -124,6 +130,9 @@
23 <a tal:attributes="href bugtask/fmt:url"
24 tal:content="bugtask/bug/title" />
25 </td>
26+ <td tal:content="structure bugtask/sourcepackagename/name|default"
27+ tal:condition="show_package"
28+ >&mdash;</td>
29 <td tal:attributes="class string:status${bugtask/status/name}"
30 tal:content="bugtask/status/title" />
31 <td tal:attributes="