Launchpad itself

Merge lp:~deryck/launchpad/subscriber-unit-test-fix-491453 into lp:launchpad/db-devel

  1. subscriber-unit-test-fix-491453
  2. Merge into db-devel
Proposed by Deryck Hodge
Status: Rejected
Rejected by: Deryck Hodge
Proposed branch: lp:~deryck/launchpad/subscriber-unit-test-fix-491453
Merge into: lp:launchpad/db-devel
Diff against target: 12 lines (+2/-0)
1 file modified
lib/canonical/launchpad/javascript/bugs/tests/subscriber.html (+2/-0)
To merge this branch: bzr merge lp:~deryck/launchpad/subscriber-unit-test-fix-491453
Reviewer Review Type Date Requested Status
Michael Nelson (community) code Approve
Review via email: mp+15609@code.launchpad.net

Commit message

Fix the bug subscriber JavaScript unit test by linking up the LP client JavaScript.

To post a comment you must log in.
Revision history for this message
Deryck Hodge (deryck) wrote :

This branch fixes the bug subscriber unit test. This is bug 491453.

The test was broken with an update to subscriber.js that requires the LP js client. The fix is just to link the script in the html for running the unit test.

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Thanks deryck.

review: Approve (code)

Unmerged revisions

8745. By Deryck Hodge

Fix the subscribe JS unit test by linking up the client script.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/javascript/bugs/tests/subscriber.html'
2--- lib/canonical/launchpad/javascript/bugs/tests/subscriber.html 2009-07-08 13:46:23 +0000
3+++ lib/canonical/launchpad/javascript/bugs/tests/subscriber.html 2009-12-03 15:45:25 +0000
4@@ -18,6 +18,8 @@
5
6 <!-- The module under test -->
7 <script type="text/javascript"
8+ src="../../client/client.js"></script>
9+ <script type="text/javascript"
10 src="../subscriber.js"></script>
11
12 <!-- The test suite -->

Subscribers

People subscribed via source and target branches

to status/vote changes: