Merge lp:~didrocks/ubiquity/copy_wallpaper_cache into lp:ubiquity
Proposed by
Didier Roche-Tolomelli
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | not available | ||||
Proposed branch: | lp:~didrocks/ubiquity/copy_wallpaper_cache | ||||
Merge into: | lp:ubiquity | ||||
Diff against target: |
82 lines (+53/-1) (has conflicts) 2 files modified
debian/changelog (+9/-0) scripts/install.py (+44/-1) Text conflict in debian/changelog |
||||
To merge this branch: | bzr merge lp:~didrocks/ubiquity/copy_wallpaper_cache | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Review via email: mp+20527@code.launchpad.net |
This proposal supersedes a proposal from 2010-03-02.
To post a comment you must log in.
Just some minor comments; this mostly looks OK.
Typo: "ureadheaded" -> "ureadahead".
Please be consistent with the existing copy_network_config method in how you get the casper user's home directory. (If you wanted to move this to a common method in the process, that would be OK.)
You don't need those two unsightly backslash- continuations; line continuations are automatic within brackets of any kind.
There's no need to say 'return' at the end.