Merge lp:~dobey/gwibber/gwibber-keyring-unthreaded into lp:gwibber
Proposed by
dobey
Status: | Rejected |
---|---|
Rejected by: | Ken VanDine |
Proposed branch: | lp:~dobey/gwibber/gwibber-keyring-unthreaded |
Merge into: | lp:gwibber |
Diff against target: |
50 lines (+3/-8) 2 files modified
bin/gwibber-service (+0/-2) gwibber/microblog/dispatcher.py (+3/-6) |
To merge this branch: | bzr merge lp:~dobey/gwibber/gwibber-keyring-unthreaded |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ken VanDine | Disapprove | ||
Review via email: mp+22704@code.launchpad.net |
This proposal supersedes a proposal from 2010-03-31.
To post a comment you must log in.
It appears that the association to gnome-keyring for this issue in gwibber is only somewhat incidental. The Dispatcher class in gwibber was mixing Threads and the gobject main loop with out mutex locking or any means of protecting against thread locks. There's really no good reason to derive the Dispatcher class from threading.Thread anyway, so I've just removed it instead.
If you want to re-introduce the use of threading.Thread here though, you should implement proper entry/exit to the main loop for calling gobject things (like idle_add/ timeout_ add*). And you should probably do it via a more generic class which all your dbus.Object implementations derive from (so that they are all separate threads).