Merge lp:~dobey/indicator-network/lib-recommends into lp:indicator-network/15.10

Proposed by dobey
Status: Merged
Approved by: Pete Woods
Approved revision: 557
Merged at revision: 560
Proposed branch: lp:~dobey/indicator-network/lib-recommends
Merge into: lp:indicator-network/15.10
Diff against target: 11 lines (+1/-1)
1 file modified
debian/control (+1/-1)
To merge this branch: bzr merge lp:~dobey/indicator-network/lib-recommends
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Michał Sawicz conceptual Approve
Review via email: mp+283213@code.launchpad.net

Commit message

Change the dependency on indicator-network to a Recommends.

To post a comment you must log in.
Revision history for this message
Michał Sawicz (saviq) wrote :

WFM, what will happen if it's not there, though? Will the lib "work" without the indicator?

review: Approve (conceptual)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
dobey (dobey) wrote :

> WFM, what will happen if it's not there, though? Will the lib "work" without
> the indicator?

If it doesn't return appropriate error conditions without, it's a bug in the library. Recommends still pulls it in by default in the default apt config on Ubuntu though. And it pulls it into seeds, if anything seeded Recommends something. But it's obviously not necessary to be running the indicator during builds. If you do need to actually run the indicator, then you should be also installing the native indicator package in cross-compiles (but you can't run any built test binaries in that situation anyway, without emulation).

Revision history for this message
Michał Sawicz (saviq) wrote :

W dniu 19.01.2016 o 17:06, Rodney Dawes pisze:
> If it doesn't return appropriate error conditions without, it's a bug in the library. Recommends still pulls it in by default in the default apt config on Ubuntu though. And it pulls it into seeds, if anything seeded Recommends something. But it's obviously not necessary to be running the indicator during builds. If you do need to actually run the indicator, then you should be also installing the native indicator package in cross-compiles (but you can't run any built test binaries in that situation anyway, without emulation).

Oh yeah, sure, we're not relying on it in builds/tests, just asking.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2015-12-15 12:23:53 +0000
3+++ debian/control 2016-01-19 20:34:03 +0000
4@@ -88,7 +88,7 @@
5 Multi-Arch: same
6 Depends: ${misc:Depends},
7 ${shlibs:Depends},
8- indicator-network (>= ${source:Version}),
9+Recommends: indicator-network (>= ${source:Version}),
10 Description: Ubuntu Connectivity Qt API
11 Ubuntu Connectivity API - Qt bindings
12

Subscribers

People subscribed via source and target branches