Merge lp:~dobey/libubuntuone/srcdir-signing into lp:libubuntuone
Proposed by
dobey
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | dobey | ||||
Approved revision: | 113 | ||||
Merged at revision: | 112 | ||||
Proposed branch: | lp:~dobey/libubuntuone/srcdir-signing | ||||
Merge into: | lp:libubuntuone | ||||
Diff against target: |
92 lines (+25/-13) 4 files modified
.bzrignore (+1/-1) bindings/mono/AssemblyInfo.cs.in (+1/-1) bindings/mono/Makefile.am (+19/-11) configure.ac (+4/-0) |
||||
To merge this branch: | bzr merge lp:~dobey/libubuntuone/srcdir-signing | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alejandro J. Cura (community) | Approve | ||
Natalia Bidart (community) | Approve | ||
Review via email: mp+43668@code.launchpad.net |
Commit message
Generate the AssemblyInfo.cs file by replacing @ASSEMBLY_KEYFILE@
Require the sn program and use it to check the signature on the built dll
To post a comment you must log in.
That seems fine; some minor comments:
* you might want to call sn under LC_ALL=C in case the output is localized at some point -- or test exit code if that's an option, not sure it reports this in the exit code though
* you might want to send errors to stderr
* instead of sn | sed + test, you could just grep? e.g.:
if LC_ALL=C $(MONO_SN) -T $< | grep -q '^Public Key Token: '; then \
echo "Assembly was not properly signed." >&2; \
exit 1; \
fi
* I guess it's a personal taste question, but I think sed s/[@]FOO[@]/bar/ is slightly more common in Makefile.am than s/\@FOO\@/bar/
* the Makefile dependency is weird: /AssemblyInfo. cs.in $(srcdir)/mono.snk Makefile
+AssemblyInfo.cs: $(srcdir)
I don't think any other generated file depends on Makefile
* I'm not actually sure why AssemblyInfo.cs depends on mono.snk; I think only the dll needs to do that
* thanks to VPATH, I think you can actually just depend on the plain simple filenames:
AssemblyInfo.cs: AssemblyInfo.cs.in