Merge lp:~dobey/ubuntuone-client/fix-657850 into lp:ubuntuone-client

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 779
Merged at revision: 790
Proposed branch: lp:~dobey/ubuntuone-client/fix-657850
Merge into: lp:ubuntuone-client
Diff against target: 47 lines (+15/-6)
1 file modified
bin/ubuntuone-preferences (+15/-6)
To merge this branch: bzr merge lp:~dobey/ubuntuone-client/fix-657850
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
Roman Yepishev (community) fieldtest Approve
Review via email: mp+43976@code.launchpad.net

Commit message

Disable the couch checkboxes when replication is not available

To post a comment you must log in.
Revision history for this message
Roman Yepishev (rye) wrote :

Works great!

review: Approve (fieldtest)
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Code looks good.

review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :
Download full text (27.5 KiB)

The attempt to merge lp:~dobey/ubuntuone-client/fix-657850 into lp:ubuntuone-client failed. Below is the output from the failed tests.

/usr/bin/gnome-autogen.sh
checking for autoconf >= 2.53...
  testing autoconf2.50... not found.
  testing autoconf... found 2.67
checking for automake >= 1.10...
  testing automake-1.11... found 1.11.1
checking for libtool >= 1.5...
  testing libtoolize... found 2.2.6b
checking for intltool >= 0.30...
  testing intltoolize... found 0.41.1
checking for pkg-config >= 0.14.0...
  testing pkg-config... found 0.25
checking for gtk-doc >= 1.0...
  testing gtkdocize... found 1.15
Checking for required M4 macros...
Checking for forbidden M4 macros...
Processing ./configure.ac
Running libtoolize...
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
libtoolize: copying file `m4/libtool.m4'
libtoolize: copying file `m4/ltoptions.m4'
libtoolize: copying file `m4/ltsugar.m4'
libtoolize: copying file `m4/ltversion.m4'
libtoolize: copying file `m4/lt~obsolete.m4'
Running intltoolize...
Running gtkdocize...
Running aclocal-1.11...
Running autoconf...
Running autoheader...
Running automake-1.11...
Running ./configure --enable-gtk-doc --enable-debug ...
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for library containing strerror... none required
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking build system type... i686-pc-linux-gnu
checking host system type... i686-pc-linux-gnu
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries.....

779. By dobey

Fix lint issue and log the ValueError

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/ubuntuone-preferences'
2--- bin/ubuntuone-preferences 2010-12-10 19:41:58 +0000
3+++ bin/ubuntuone-preferences 2011-01-05 20:47:27 +0000
4@@ -66,7 +66,8 @@
5 dcouch = None
6 # Try importing the Ubuntu One desktopcouch enablement api
7 try:
8- from desktopcouch.replication_services import ubuntuone as dcouch
9+ from desktopcouch.application.replication_services import (
10+ ubuntuone as dcouch)
11 except ImportError:
12 logger.error("DesktopCouch replication API not found")
13
14@@ -709,9 +710,14 @@
15 def connect_desktopcouch_exclusion(self):
16 """Hook up to desktopcouch enablement API, or disable the UI."""
17 # Hook up to desktopcouch, or die trying
18- if dcouch:
19+ try:
20+ if not dcouch:
21+ raise ValueError('Replication service not available.')
22+
23+ # Check bindwood availability
24 Thread(target=self.__check_for_bindwood).start()
25
26+ # Get the exclusion settings
27 self.dcouch = dcouch.ReplicationExclusion()
28 exclusions = self.dcouch.all_exclusions()
29 for check in [self.bookmarks_check,
30@@ -721,10 +727,13 @@
31 check.set_active(False)
32 else:
33 check.set_active(True)
34- else:
35- self.bookmarks_check.set_sensitive(False)
36- self.abook_check.set_sensitive(False)
37- self.gwib_check.set_sensitive(False)
38+ except ValueError, e:
39+ # Replication is not avaialble, so disable the UI
40+ for check in [self.bookmarks_check,
41+ self.abook_check,
42+ self.gwib_check]:
43+ check.set_sensitive(False)
44+ logger.warning(e)
45
46 def toggle_db_sync(self, dbname, disable=False):
47 """

Subscribers

People subscribed via source and target branches