Merge lp:~dpm/gwibber/bug-1068126 into lp:gwibber

Proposed by David Planella
Status: Merged
Merged at revision: 1445
Proposed branch: lp:~dpm/gwibber/bug-1068126
Merge into: lp:gwibber
Diff against target: 11 lines (+1/-0)
1 file modified
data/gwibber.application.in (+1/-0)
To merge this branch: bzr merge lp:~dpm/gwibber/bug-1068126
Reviewer Review Type Date Requested Status
Robert Bruce Park Needs Information
Review via email: mp+130349@code.launchpad.net

Description of the change

Fix for bug 1068126: specify the gettext domain to load translations.

To post a comment you must log in.
Revision history for this message
Robert Bruce Park (robru) wrote :

David, I don't understand this bug. Is it really true that all of Gwibber fails to be translated with just this one line missing? If so I will merge it, but please just explain some more details about this. Gwibber has had translations for a long time, they can't all be lies, can they? ;-)

review: Needs Information
Revision history for this message
David Planella (dpm) wrote :

Hey Robert,

Thanks for looking at this merge proposal, I had already forgotten about it :-)

The linked bug provides all of the detail: it's not the whole translations in Gwibber that are prevented from loading, I'd have certainly escalated the bug if it were the case. This fix is concerned with translations coming from Gwibber on the Online Accounts dialog not loading.

Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/gwibber.application.in'
2--- data/gwibber.application.in 2012-09-20 04:45:22 +0000
3+++ data/gwibber.application.in 2012-10-18 13:31:49 +0000
4@@ -1,6 +1,7 @@
5 <?xml version="1.0" encoding="UTF-8" ?>
6 <application id="gwibber">
7 <description>Gwibber</description>
8+ <translations>gwibber</translations>
9 <desktop-entry>gwibber.desktop</desktop-entry>
10
11 <service-types>