telephony-service

Merge lp:~dpm/telephony-service/no-calls-string into lp:telephony-service

Proposed by David Planella on 2015-08-03

Status:

Needs review

Proposed branch:

Merge into:

Diff against target:

1 file modified

indicator/metrics.cpp (+1/-1)

To merge this branch:

bzr merge lp:~dpm/telephony-service/no-calls-string

Undecided

New

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Approve on 2015-08-03
Ubuntu Phablet Team		2015-08-03	Pending
Review via email: mp+266690@code.launchpad.net

Fix duplicated string for no calls received today on the greeter.

Fix duplicated string for no calls received today on the greeter.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-08-03:

review: Approve (continuous-integration)

1108. By David Planella on 2015-08-03: Fixed greeter string for no calls today

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

People subscribed via source and target branches

to all changes:

1	=== modified file 'indicator/metrics.cpp'
2	--- indicator/metrics.cpp 2014-08-20 09:35:55 +0000
3	+++ indicator/metrics.cpp 2015-08-03 08:37:26 +0000
4	@@ -48,7 +48,7 @@
5	mMetrics[OutgoingCalls] = mMetricManager->add(MetricParameters(DIALER_OUTGOING_STATISTICS_ID).formatString(GettextMarkExtraction("<b>%1</b> calls made today"))
6	.emptyDataString(GettextMarkExtraction("No calls made today")).textDomain(APP_ID).minimum(0.0));
7	mMetrics[CallDurations] = mMetricManager->add(MetricParameters(DIALER_CALL_DURATION_STATISTICS_ID).formatString(GettextMarkExtraction("Spent <b>%1</b> minutes in calls today"))
8	- .emptyDataString(GettextMarkExtraction("No calls made today")).textDomain(APP_ID).minimum(0.0));
9	+ .emptyDataString(GettextMarkExtraction("No time spent on calls today")).textDomain(APP_ID).minimum(0.0));
10	} catch(std::exception &e) {
11	qWarning() << "Error connecting to metrics service:" << e.what();
12	}