Launchpad itself

Merge lp:~edwin-grubbs/launchpad/broken_test_do_not_copy_disabled_dases into lp:launchpad/db-devel

  1. broken_test_do_not_copy_disabled_dases
  2. Merge into db-devel
Proposed by Edwin Grubbs
Status: Rejected
Rejected by: Edwin Grubbs
Proposed branch: lp:~edwin-grubbs/launchpad/broken_test_do_not_copy_disabled_dases
Merge into: lp:launchpad/db-devel
Diff against target: 19 lines (+3/-3)
1 file modified
lib/lp/soyuz/scripts/tests/test_initialise_distroseries.py (+3/-3)
To merge this branch: bzr merge lp:~edwin-grubbs/launchpad/broken_test_do_not_copy_disabled_dases
Reviewer Review Type Date Requested Status
Launchpad code reviewers Pending
Review via email: mp+37815@code.launchpad.net

Description of the change

This is a fix for this error on db-devel caused by revision 9871, which was actually revision 11682 from devel. The branch passed the tests on devel, so it must be a new test in db-devel that is using the _create_distroseries() method that was eliminated.

Error in test lp.soyuz.scripts.tests.test_initialise_distroseries.TestInitialiseDistroSeries.test_do_not_copy_disabled_dases
Traceback (most recent call last):
_StringException: Text attachment: traceback
------------
Traceback (most recent call last):
  File "/srv/buildbot/slaves/launchpad/lucid-db-devel/build/orig_sourcecode/eggs/testtools-0.9.6-py2.6.egg/testtools/runtest.py", line 144, in _run_user
    return fn(*args)
  File "/srv/buildbot/slaves/launchpad/lucid-db-devel/build/orig_sourcecode/eggs/testtools-0.9.6-py2.6.egg/testtools/testcase.py", line 465, in _run_test_method
    testMethod()
  File "/srv/buildbot/slaves/launchpad/lucid-db-devel/build/lib/lp/soyuz/scripts/tests/test_initialise_distroseries.py", line 256, in test_do_not_copy_disabled_dases
    foobuntu = self._create_distroseries(parent)
AttributeError: 'TestInitialiseDistroSeries' object has no attribute '_create_distroseries'
------------

To post a comment you must log in.
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Steve Kowalik is fixing this.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/soyuz/scripts/tests/test_initialise_distroseries.py'
2--- lib/lp/soyuz/scripts/tests/test_initialise_distroseries.py 2010-10-06 20:34:27 +0000
3+++ lib/lp/soyuz/scripts/tests/test_initialise_distroseries.py 2010-10-07 04:24:52 +0000
4@@ -253,12 +253,12 @@
5 distroseries=parent, processorfamily=ppc)
6 ppc_das.enabled = False
7 parent.nominatedarchindep = i386_das
8- foobuntu = self._create_distroseries(parent)
9- ids = InitialiseDistroSeries(foobuntu)
10+ series = self.factory.makeDistroSeries(parent_series=parent)
11+ ids = InitialiseDistroSeries(series)
12 ids.check()
13 ids.initialise()
14 das = list(IStore(DistroArchSeries).find(
15- DistroArchSeries, distroseries = foobuntu))
16+ DistroArchSeries, distroseries=series))
17 self.assertEqual(len(das), 1)
18 self.assertEqual(
19 das[0].architecturetag, i386_das.architecturetag)

Subscribers

People subscribed via source and target branches

to status/vote changes: