Merge lp:~edwin-grubbs/launchpad/bug-234051-bug-project-info into lp:launchpad/db-devel

Summary
-------

In the "Assigned bugs" portlet (person-portlet-currentfocus.pt), I added
a table to display the badges like other portlets do. I also added an
additional line that lists all the pillars that a given bug affects.

I also removed the $distribution/+allpackages page as decided in bug
196322.

I removed the italics from the "registered" css class as requested
in bug 465524 to fix the "Latest memberships" portlet.

Here is a screenshot for the UI review.
https://chinstrap.canonical.com/~egrubbs/bugs_with_pillar_info_and_latest_memberships_without_italics.png

Implementation details
----------------------

I converted the bugtask-listing-detailed.pt page into a macro so that
the show_extra_details variable could be passed in.
    lib/lp/bugs/templates/bugtask-macros-listing.pt

Tests
-----

The only test changes that were necessary were to remove some for
the deleted +allpackages page.

Demo and Q/A
------------

* Open http://launchpad.dev/~name16

> In the "Assigned bugs" portlet (person-portlet-currentfocus.pt), I added
> a table to display the badges like other portlets do. I also added an
> additional line that lists all the pillars that a given bug affects.

This looks great. The one question I have is why all the pillars are not
linked? Looking at the screenshot I see that e.g. for bug #9 Ubuntu is
linked, but not alsa-utils, Evolution, or Mozilla Thunderbird. How hard would
it be to link all of those?

> I also removed the $distribution/+allpackages page as decided in bug
> 196322.
>
> I removed the italics from the "registered" css class as requested
> in bug 465524 to fix the "Latest memberships" portlet.

Yay!

=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
--- lib/canonical/launchpad/icing/style-3-0.css 2009-11-04 17:35:50 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css 2009-11-06 17:30:56 +0000
> @@ -424,10 +424,6 @@
> .registered {
> font-size: 85%;
> color: #666;
> - font-style: italic;
> - }
> -li .registered {
> - font-style: normal;

There's a subtle change here. Not only are you deleting the italics style
from .registered (good) but you're also adding the font-size and color styles
to li.registered. That might be okay, but is it what you intended?

> }
> .description {
> clear: both;

=== renamed file 'lib/lp/bugs/templates/bugtask-listing-detailed.pt' => 'lib/lp/bugs/templates/bugtask-macros-listing.pt'
--- lib/lp/bugs/templates/bugtask-listing-detailed.pt 2009-07-17 17:59:07 +0000
+++ lib/lp/bugs/templates/bugtask-macros-listing.pt 2009-11-06 17:30:56 +0000
> @@ -1,28 +1,38 @@
> -<tr xmlns:tal="http://xml.zope.org/namespaces/tal">
> - <td class="icon left" tal:content="structure context/image:icon" />
> - <td>
> - <div>
> - #<span tal:replace="context/bug/id">4</span>
> - <a tal:attributes="href context/fmt:url"
> - tal:content="context/bug/title">Bug Title Here
> - </a>
> - <tal:badges replace="structure context/image:badges" />
> - </div>
> - <div class="lesser" tal:condition="hide_extra_details|nothing">
> - <tal:affected_pillars define="also_in context/other_affected_pillars"
> - condition="also_in">
> - also in
> - <tal:per_pillar repeat="pillar also_in">
> - <b tal:content="pillar/displayname" />,
> - </tal:per_pillar>
> - </tal:affected_pillars>
> - reported
> - <span
> - tal:attributes="title context/datecreated/fmt:datetime"
> - tal:content="context/datecreated/fmt:displaydate">2005-10-05</span>
> - by
> - <a tal:attributes="href context/owner/fmt:url"
> - tal:content="context/owner/displayname">Foo Bar</a>
> - </div>
> - </td>
> -</tr>
> +<metal:header
> + xmlns:metal="http://xml.zope.org/namespaces/metal"
> + xmlns:tal="http://xml.zope.org/namespaces/tal"
> + define-macro="detailed">
> + <tal:comment replace="nothing">
> + Variables to be defined for this macro.
> + :bugtask: (Required) BugTask that will be displayed.
> + :show_extra_details: (Optional) Boolean determining whether
> + to display a second line of in...

+1 on barry's comments, and I would also add some bottom padding to after each item (not a lot, maybe 0.5-1em).

Hi Edwin.

I looked at the screenshot. I think alignment of the badges is hard to scan. I know that badges are often aligned to the right and playout in a fixed order so that the milestone badges always align. Consider your own profile page where most bugs will have a milestone, and a few will have branches.

Hi Barry,

Thanks for the review. In addition to your comments that I addressed
below, I added the padding that Martin asked for and the change in
badge alignment that Curtis asked for.

On Fri, Nov 6, 2009 at 12:45 PM, Barry Warsaw <email address hidden> wrote:
> Review: Approve code ui*
>> In the "Assigned bugs" portlet (person-portlet-currentfocus.pt), I added
>> a table to display the badges like other portlets do. I also added an
>> additional line that lists all the pillars that a given bug affects.
>
> This looks great.  The one question I have is why all the pillars are not
> linked?  Looking at the screenshot I see that e.g. for bug #9 Ubuntu is
> linked, but not alsa-utils, Evolution, or Mozilla Thunderbird.  How hard would
> it be to link all of those?

Not hard. I'll do that.

>> I also removed the $distribution/+allpackages page as decided in bug
>> 196322.
>>
>> I removed the italics from the "registered" css class as requested
>> in bug 465524 to fix the "Latest memberships" portlet.
>
> Yay!
>
> === modified file 'lib/canonical/launchpad/icing/style-3-0.css'
> --- lib/canonical/launchpad/icing/style-3-0.css 2009-11-04 17:35:50 +0000
> +++ lib/canonical/launchpad/icing/style-3-0.css 2009-11-06 17:30:56 +0000
>> @@ -424,10 +424,6 @@
>>  .registered {
>>      font-size: 85%;
>>      color: #666;
>> -    font-style: italic;
>> -    }
>> -li .registered {
>> -    font-style: normal;
>
> There's a subtle change here.  Not only are you deleting the italics style
> from .registered (good) but you're also adding the font-size and color styles
> to li.registered.  That might be okay, but is it what you intended?

The "li .registered" selector doesn't eliminate all the styles from
the ".registered", just the ones that are explicitely overridden
(font-style), so elements with the "registered" class inside an <li>
were already getting their font-size and color set as it is now.

>>      }
>>  .description {
>>      clear: both;
>
> === renamed file 'lib/lp/bugs/templates/bugtask-listing-detailed.pt' => 'lib/lp/bugs/templates/bugtask-macros-listing.pt'
> --- lib/lp/bugs/templates/bugtask-listing-detailed.pt   2009-07-17 17:59:07 +0000
> +++ lib/lp/bugs/templates/bugtask-macros-listing.pt     2009-11-06 17:30:56 +0000
>> @@ -1,28 +1,38 @@
>> -<tr xmlns:tal="http://xml.zope.org/namespaces/tal">
>> -  <td class="icon left" tal:content="structure context/image:icon" />
>> -  <td>
>> -    <div>
>> -      #<span tal:replace="context/bug/id">4</span>
>> -      <a tal:attributes="href context/fmt:url"
>> -         tal:content="context/bug/title">Bug Title Here
>> -      </a>
>> -      <tal:badges replace="structure context/image:badges" />
>> -    </div>
>> -    <div class="lesser" tal:condition="hide_extra_details|nothing">
>> -      <tal:affected_pillars define="also_in context/other_affected_pillars"
>> -                           condition="also_in">
>> -        also in
>> -          <tal:per_pillar repeat="pillar also_in">
>> -            <b tal:content="pillar/displayname" />,
>> -          </tal:per_pillar>
>> -        </tal:affected_pillars>
>> -      reported
>> -      <span
>> -        tal:attributes="title context/datecreated/fmt:datet...

Thank you very much for fixing some many irksome problems. I know it was trying to reconcile all these little issues. I really appreciate this fix.