Merge lp:~edwin-grubbs/launchpad/bug-482176-add-team-member-ajax-part1 into lp:launchpad

Summary
-------

This is the first branch on the way to adding a picker
to add members to a team with a link on its index page.

Salgado started this branch. I did a little bit of cleanup, but
the following things should be done in a followup branch.

 * Add windmill test.
 * Handle adding teams, which will go into a PROPOSED or INVITED status.

Implementation details
----------------------

The picker widget now clears the search term by default when
the SAVE event is processed (when an item is selected from the results).
The picker widget will also add an onclick handler for you.
    lib/canonical/launchpad/javascript/bugs/bugtask-index.js
    lib/canonical/launchpad/javascript/code/codereview.js

The main part of this feature:
    lib/canonical/launchpad/javascript/registry/team.js
    lib/lp/app/templates/base-layout-macros.pt
    lib/lp/registry/browser/configure.zcml
    lib/lp/registry/browser/person.py
    lib/lp/registry/templates/team-index.pt
    lib/lp/registry/browser/tests/test_person_webservice.py
    lib/lp/registry/templates/team-portlet-membership.pt

Change affecting existing tests:
    lib/lp/registry/model/person.py
    lib/lp/registry/model/teammembership.py
    lib/lp/registry/browser/tests/teammembership-views.txt
    lib/lp/registry/doc/teammembership-email-notification.txt
    lib/lp/registry/doc/teammembership.txt

Tests
-----

./bin/test -vv -t 'test_person_webservice|teammembership-views.txt|teammembership-email-notification.txt|/teammembership.txt'

Demo and Q/A
------------

* Open http://launchpad.dev/~guadamen
  * The "Add member" link should be green, click on it to show the picker.
  * When you click on a person in the picker, the progress spinner
    should display where the (+) icon was.
  * Then there should be a green flash where the person is added to the
    "Latest members" list.

Hi Edwin,

I've put a lot of comments in the diff below, but none of them are
critical, and a lot of them are suggestions. This is a nice new
feature that works well :)

 review approve code
 merge approve

Gavin.

> === modified file 'lib/canonical/launchpad/javascript/bugs/bugtask-index.js'
> --- lib/canonical/launchpad/javascript/bugs/bugtask-index.js 2009-12-14 15:49:13 +0000
> +++ lib/canonical/launchpad/javascript/bugs/bugtask-index.js 2009-12-16 15:51:58 +0000
> @@ -239,21 +239,6 @@
>
>
> /*
> - * Clear the subscribe someone else picker.
> - *
> - * @method clear_picker
> - * @param e {Object} The event object.
> - */
> -function clear_picker(e) {
> - var input = Y.one('.yui-picker-search-box input');
> - input.set('value', '');
> - this.set('error', '');
> - this.set('results', [{}]);
> - this._results_box.set('innerHTML', '');
> - this.set('batches', []);
> -}
> -
> -/*
> * Initialize click handler for the subscribe someone else link.
> *
> * @method setup_subscribe_someone_else_handler
> @@ -262,23 +247,14 @@
> function setup_subscribe_someone_else_handler(subscription) {
> var config = {
> header: 'Subscribe someone else',
> - step_title: 'Search'
> + step_title: 'Search',
> + picker_activator: '.menu-link-addsubscriber'
> };
>
> var picker = Y.lp.picker.create(
> 'ValidPersonOrTeam',
> function(result) { subscribe_someone_else(result, subscription); },
> config);
> - // Clear results and search terms on cancel or save.
> - picker.on('save', clear_picker, picker);
> - picker.on('cancel', clear_picker, picker);
> -
> - var subscription_link_someone_else = Y.one('.menu-link-addsubscriber');
> - subscription_link_someone_else.on('click', function(e) {
> - e.halt();
> - picker.show();
> - });
> - subscription_link_someone_else.addClass('js-action');
> }
>
> /*
> @@ -626,21 +602,12 @@
> if (Y.Lang.isValue(link_branch_link)) {
> var config = {
> header: 'Link a related branch',
> - step_title: 'Search'
> + step_title: 'Search',
> + picker_activator: '.menu-link-addbranch'
> };
>
> var picker = Y.lp.picker.create(
> 'Branch', get_branch_and_link_to_bug, config);
> -
> - // Clear results and search terms on cancel or save.
> - picker.on('save', clear_picker, picker);
> - picker.on('cancel', clear_picker, picker);
> -
> - link_branch_link.on('click', function(e) {
> - e.halt();
> - picker.show();
> - });
> - link_branch_link.addClass('js-action');
> }
> }

Thanks for fixing this up.

>
>
> === modified file 'lib/canonical/launchpad/javascript/code/codereview.js'
> --- lib/canonical/launchpad/javascript/code/codereview.js 2009-11-30 23:51:34 +0000
> +++ lib/canonical/launchpad/javascript/code/codereview.js 2009-12-16 15:51:58 +0000
> @@ -22,6 +22,14 @@
> var link = Y.one('#request-review');
> if (link !== null) {
> link.addClass('js-action');
> + /* XXX: salgado, 2009-11-11: This will cause the picker to be
> + * rec...