Hi Edwin.

I really appreciate your effort to solve this usability issue.

UI/Usability
------------

! As the owner of thunderbird, I saw that the "Report a bug" was disabled. I
  used "Configure Launchpad bugs" and choose The Mozilla.org bug tracker and
  provided the remove project.
  * I still see "Report a bug" (This service needs configuration). This is
    wrong. I provided the real information that should satisfy other
    contributors. I expect to see the warning disappear.

! As the owner of Firefox and thunderbird, I expect to see a warning that
  "Development focus branch has not been specified" which I can see in the
  Project information portlet.
  * I think this is a case where official_codehosting is a bogus attribute.
    We know if the project officially uses code if the branch is neither a
    mirror or import. I expect the Involvement portlet to tell me that this
    is a problem.
  * As an anonymous user I should see a warning that the development focus is
    missing a branch in the Involvement portlet.
  * May be call for action should also be repeated on the series page since
    that is the object that is being edited.

! As the user of evolution, a project that has a link to a package with
  I expect to see a warning that translation syncing should be setup.
  The owner certainly can set official/unofficial usage, but any user
  can enable series sync, and should if Ubuntu has translations for it.
  * This is a unique case were any user can set this. This information
    must be shown on the series overview for any user to act on.
  * We may want alternate configuration link or tool tips about the
    problem.
  * This is case is harder than the others because the official_translations
    attribute is legitimate.

! I think the message for all these services is wrong. We want the user
  to tell Launchpad where the service is and maybe configure it if the
  service is Launchpad's. In the bug tracker example. we need to know the
  bug tracker, and the owner wants to tell every one about the official
  tracker; no one is asking users to enable Launchpad Bugs.
  

* I noticed that as an anonymous user or no-priv that the Involvement portlet
  has about 1em extra padding in the bottom. Oh. The markup has an empty
  <ul>; this is invalid HTML.

* I Think the "Uses Launchpad for" item in the Project information portlet
  may be redundant. We can discuss removing it after we are certain that this
  change is all the information needed. I suspect we need to disable answers
  and blueprints first since they are effectively on and it is not clear
  that the involvement portlet is 100% related to official uses. Of course,
  the involvement portlet is not just about official uses anymore either.

* Think the "Development focus branch has not been specified" link in
  the Project information portlet may be removable if we solve the Involvement
  portlet issues.

* Note to self, we may want to remove official_translations from distros.
  Only Ubuntu can use translations. I recall there was a complaint from a
  user that we cannot set a distro bug tracker.

I see your configuration for the bug tracker is similar to my branch and I
can drop some of my proposed changes. I think the sprint was very helpful
in getting us in sync.


Lint
----

lib/lp/registry/browser/product.py
    9: undefined name 'ProductInvolvementView' in __all__

I have a few thoughts about the implementation. I think these are minor
compared to the usability concerns.

...

> === modified file 'lib/lp/registry/browser/pillar.py'
> --- lib/lp/registry/browser/pillar.py	2010-02-17 11:19:42 +0000
> +++ lib/lp/registry/browser/pillar.py	2010-03-17 16:31:13 +0000

...

> @@ -131,3 +134,43 @@
>  
>  provideAdapter(
>      InvolvedMenu, [IInvolved], INavigationMenu, name="overview")
> +
> +
> +# This class can't be moved into the browser/product.py file, since
> +# the pillar-views.txt test will fail due to the MenuAPI adapter
> +# for PillarView.enabled_links not working.
> +class ProductInvolvementView(PillarView):
> +    """Encourage configuration of involvement links for projects."""

I also think this view should be supporting ProductSeries or we need
another subclass to provide that.


> === modified file 'lib/lp/registry/browser/product.py'
> --- lib/lp/registry/browser/product.py	2010-03-09 00:46:37 +0000
> +++ lib/lp/registry/browser/product.py	2010-03-17 16:31:13 +0000

...

> @@ -331,6 +337,31 @@
>          return Link('+edit', text, icon='edit')
>  
>      @enabled_with_permission('launchpad.Edit')
> +    def configure_bugtracker(self):
> +        text = 'Configure Launchpad Bugs'
> +        return Link('+configure-bugtracker', text, icon='edit')
> +
> +    @enabled_with_permission('launchpad.Edit')
> +    def configure_branches(self):
> +        text = 'Configure Launchpad Branches'
> +        return Link('+configure-branches', text, icon='edit')
> +
> +    @enabled_with_permission('launchpad.Edit')
> +    def configure_translations(self):
> +        text = 'Configure Launchpad Translations'
> +        return Link('+configure-translations', text, icon='edit')
> +
> +    @enabled_with_permission('launchpad.Edit')
> +    def configure_answers(self):
> +        text = 'Configure Launchpad Answers'
> +        return Link('+configure-answers', text, icon='edit')
> +
> +    @enabled_with_permission('launchpad.Edit')
> +    def configure_blueprints(self):
> +        text = 'Configure Launchpad Blueprints'
> +        return Link('+configure-blueprints', text, icon='edit')

I do not think "Launchpad" is relevant to the action. I think the summary
attribute (tooltip) is need to elaborate on what the user can do.

...

> @@ -473,11 +509,12 @@
>          return Link('+securitycontact', text, icon='edit')
>  
>  
> -class ProductSpecificationsMenu(NavigationMenu,
> +class ProductSpecificationsMenu(NavigationMenu, ProductEditLinksMixin,
>                                  HasSpecificationsMenuMixin):
>      usedfor = IProduct
>      facet = 'specifications'
> -    links = ['listall', 'doc', 'assignments', 'new', 'register_sprint']
> +    links = ['configure_blueprints', 'listall', 'doc', 'assignments', 'new',
> +             'register_sprint']
>  
>  
>  def _cmp_distros(a, b):
> @@ -1128,6 +1165,79 @@
>          return canonical_url(self.context)
>  
>  
> +class ProductConfigureBase(ReturnToReferrerMixin, LaunchpadEditFormView):
> +    implements(IProductEditMenu)
> +    schema = IProduct
> +
> +    @property
> +    def page_title(self):
> +        return self.label
> +
> +    @action("Change", name='change')
> +    def change_action(self, action, data):
> +        self.updateContextFromData(data)
> +
> +
> +class ProductConfigureBugTrackerView(ProductConfigureBase):
> +    """View class to configure the bug tracker for a project."""
> +
> +    label = "Configure bug tracker"
> +    field_names = [
> +        "bugtracker",
> +        "enable_bug_expiration",
> +        "remote_product",
> +        "bug_reporting_guidelines",
> +        ]
> +    custom_widget('bugtracker', ProductBugTrackerWidget)
> +
> +    def validate(self, data):
> +        """Constrain bug expiration to Launchpad Bugs tracker."""
> +        # enable_bug_expiration is disabled by JavaScript when bugtracker
> +        # is not 'In Launchpad'. The contraint is enforced here in case the
> +        # JavaScript fails to activate or run. Note that the bugtracker
> +        # name : values are {'In Launchpad' : object, 'Somewhere else' : None
> +        # 'In a registered bug tracker' : IBugTracker}.
> +        bugtracker = data.get('bugtracker', None)
> +        if bugtracker is None or IBugTracker.providedBy(bugtracker):
> +            data['enable_bug_expiration'] = False

grammar: s/contraint/constraint/

/me thinks he misspelled the word 2.5 years ago.

> +class ProductConfigureBranchesView(ProductConfigureBase):
> +    """View class to configure the Launchpad Branches for a project."""
> +
> +    label = "Configure Launchpad Branches"
> +    field_names = [
> +        "official_codehosting",
> +        ]

This is a problem. We want this to go to series/+setbranch. Brad's branch
will provide an alternate name to configure code. I think we need to
reconcile this link and what we actually need users to do.

...

> +class ProductConfigureTranslationsView(ProductConfigureBase):
> +    """View class to configure the Launchpad Translations for a project."""
> +
> +    label = "Configure Launchpad Translations"
> +    field_names = [
> +        "official_rosetta",
> +        ]

This does not actually configure translations, but it improves the existing
behaviour. I think we need to work with the translations team to understand
how we can get the required information into a single form.

...

> === modified file 'lib/lp/registry/templates/pillar-involvement-portlet.pt'
> --- lib/lp/registry/templates/pillar-involvement-portlet.pt	2009-08-15 05:35:13 +0000
> +++ lib/lp/registry/templates/pillar-involvement-portlet.pt	2010-03-17 16:31:13 +0000
> @@ -1,13 +1,40 @@
>  <div
>    xmlns:tal="http://xml.zope.org/namespaces/tal"
>    xmlns:i18n="http://xml.zope.org/namespaces/i18n"
> -  id="involvement" class="portlet involvement"
> -  tal:condition="view/has_involvement">
> +  id="involvement" class="portlet"
> +  tal:condition="view/has_involvement"
> +  >
>    <h2>Get Involved</h2>
>  
> -  <ul>
> +  <ul class="involvement">
>      <li tal:repeat="link view/enabled_links">
>        <a tal:replace="structure link/fmt:link" />
>      </li>
> +
> +    <tal:disabled repeat="link view/visible_disabled_links">
> +      <li tal:condition="not: link/enabled"
> +          title="This service needs to be configured."
> +          class="disabled">
> +        <div style="padding: 0.3em 0 0.3em 0.3em">
> +          <div style="display: inline-block"
> +               class="sprite icon-only warning-icon"></div>
> +
> +          <div style="height: 1.2em; float: right">
> +            <img src="/@@/gray-arrow-right.png"
> +                style="top: 50%; bottom: 50%; margin-top: -5px;
> +                       position: relative;
> +                       height: 9px; width: 14px; padding: 0"/>
> +          </div>
> +
> +          <span tal:content="link/text"/>
> +        </div>
> +      </li>
> +    </tal:disabled>
> +  </ul>
> +
> +  <ul style="padding-top: 1em">
> +    <li tal:repeat="link view/configuration_links">
> +      <a tal:replace="structure link/fmt:link" />
> +    </li>
>    </ul>
>  </div>

I think this last url needs something like:
    tal:condition="view/configuration_links"