Merge lp:~edwin-grubbs/launchpad/bug-521934-missing-sprites into lp:launchpad
Proposed by
Edwin Grubbs
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Tim Penhey | ||||
Approved revision: | not available | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~edwin-grubbs/launchpad/bug-521934-missing-sprites | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
622 lines (+120/-101) 3 files modified
lib/canonical/launchpad/icing/icon-sprites.positioning (+104/-100) lib/canonical/launchpad/icing/style-3-0.css.in (+6/-0) lib/lp/services/spriteutils.py (+10/-1) |
||||
To merge this branch: | bzr merge lp:~edwin-grubbs/launchpad/bug-521934-missing-sprites | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey (community) | Approve | ||
Review via email: mp+19454@code.launchpad.net |
To post a comment you must log in.
Summary
-------
Re-added .branch and .cves css rules that were accidentally removed when
switching to automatic generation of the combined sprite image.
Implementation details ------- ------- -
-------
Re-added the .branch css rule and the .cves css rule. canonical/ launchpad/ icing/style- 3-0.css. in
lib/
Added some error handling. lp/services/ spriteutils. py
lib/
New sprite image and positioning file for generating the combo.css canonical/ launchpad/ icing/icon- sprites canonical/ launchpad/ icing/icon- sprites. positioning
from the style-3-0.css.in.
lib/
lib/
Tests
-----
./bin/test -vv -t sprites.txt
Demo and Q/A
------------
* Open https:/ /code.launchpad .dev/~mark/ firefox/ release- -0.9.1/ +merge/ 1 /bugs.launchpad .dev/debian/ +source/ mozilla- firefox/ +bug/3
* The branch icon should appear after "Proposed branch:" and "Merge into:".
* Open https:/
* The cves should float to the right.