Merge lp:~edwin-grubbs/launchpad/bug-663857-product-packages-timeout-part2 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Curtis Hovey | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 12252 | ||||
Proposed branch: | lp:~edwin-grubbs/launchpad/bug-663857-product-packages-timeout-part2 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
106 lines (+32/-16) 4 files modified
lib/lp/registry/browser/product.py (+9/-13) lib/lp/registry/interfaces/product.py (+2/-0) lib/lp/registry/model/product.py (+16/-0) lib/lp/registry/templates/product-packages.pt (+5/-3) |
||||
To merge this branch: | bzr merge lp:~edwin-grubbs/launchpad/bug-663857-product-packages-timeout-part2 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey (community) | code | Approve | |
Curtis Hovey (community) | code | Approve | |
Steve Kowalik (community) | code* | Approve | |
Review via email: mp+46985@code.launchpad.net |
Commit message
[r=sinzui,
Description of the change
Summary
-------
The $product/+packages still times out because the
ProductPackages
product's series in order to find the product's packages.
Implementation details
-------
Decorated the series in series_batch so that series/packagings in the
template doesn't execute a query for storm's __nonzero__() method
repeatedly. Switched distro_packaging to use the new Product.packaging
property.
lib/
lib/
lib/
Cut in half the number of queries for the currentrelease.
lib/
Tests
-----
./bin/test -vv -t 'xx-product-
Demo and Q/A
------------
* Open https:/
* It should not timeout.
Lint
----
Not going to fix this.
./lib/lp/
983: E301 expected 1 blank line, found 2
This change looks good to me, thanks!