Merge lp:~edwin-grubbs/launchpad/bug-669724-projectgroup-milestones-timeout into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Curtis Hovey | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 12238 | ||||
Proposed branch: | lp:~edwin-grubbs/launchpad/bug-669724-projectgroup-milestones-timeout | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
271 lines (+46/-31) 7 files modified
lib/lp/bugs/doc/official-bug-tags.txt (+10/-5) lib/lp/registry/browser/configure.zcml (+2/-2) lib/lp/registry/browser/milestone.py (+10/-6) lib/lp/registry/browser/project.py (+9/-5) lib/lp/registry/model/projectgroup.py (+9/-6) lib/lp/registry/stories/milestone/object-milestones.txt (+1/-2) lib/lp/registry/templates/object-milestones.pt (+5/-5) |
||||
To merge this branch: | bzr merge lp:~edwin-grubbs/launchpad/bug-669724-projectgroup-milestones-timeout | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+46837@code.launchpad.net |
Commit message
[r=sinzui]
Description of the change
Summary
-------
This branch fixes timeouts on the $projectgroup/
removing the counts for bugs and blueprints, since that information has
already been removed for projects and distributions.
It would be possible to re-add the bug and blueprints counts by writing
a query that gets the counts for all the milestones at once. However,
this will require rewriting the templates or adding a decorator on the
milestone object with count data for the various types of milestone
targets.
Implementation details
-------
The +pillar-table-row for IProjectGroupMi
instead of MilestonesView, which has show_series_
caused should_
distributions, but not for project groups. I made this more explicit. I
renamed MilestonesView to avoid confusing it with MilestoneView, and it
also wasn't a very accurate name. Cache the milestones as a list so
that it can be referenced multiple times in the template without
evaluating the storm result set multiple times.
lib/
lib/
lib/
lib/
Reduced the number of queries in the page by preventing the menu from
querying whether the project group has projects for each menu item.
lib/
Instead of one query per project, use one query to get all bug tags for
the project group.
lib/
Fixed test for attribute that now returns storm result set.
lib/
Tests
-----
./bin/test -vv -t 'official-
Demo and Q/A
------------
* Open https:/
* It should not timeout.
Lint
----
No lint.
Thank you for discovering my typo. The renaming and clean ups are very appreciated.