Ubuntu
twisted package

Merge ~eole-team/ubuntu/+source/twisted:fix/twisted.web.twcgi-url-params-python3 into ubuntu/+source/twisted:applied/ubuntu/focal-proposed

Proposed by EOLE team on 2020-09-03

Status:	Needs review
Proposed branch:	~eole-team/ubuntu/+source/twisted:fix/twisted.web.twcgi-url-params-python3
Merge into:	ubuntu/+source/twisted:applied/ubuntu/focal-proposed
Diff against target:	17 lines (+2/-2) 1 file modified src/twisted/web/twcgi.py (+2/-2)
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Ubuntu Sponsors	2022-07-05	Pending
git-ubuntu developers	2020-09-03	Pending
Review via email: mp+390233@code.launchpad.net

twisted.web.twcgi can now handle url parameters in python 3.

Under Python3, the query string is in bytes and the unquote is no more directly under urllib but under urllib.parse.

Revision history for this message

EOLE team (eole-team) wrote on 2020-09-03:

e6c5d29... by Daniel Dehennin <email address hidden> on 2020-09-03

[PATCH] twisted.web.twcgi can now handle url parameters in python 3

Gbp-Pq: twisted.web.twcgi-handle-url-parameters-python3.patch

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

People subscribed via source and target branches

to all changes:

1	diff --git a/src/twisted/web/twcgi.py b/src/twisted/web/twcgi.py
2	index 1c92960..699e5f2 100644
3	--- a/src/twisted/web/twcgi.py
4	+++ b/src/twisted/web/twcgi.py
5	@@ -109,10 +109,10 @@ class CGIScript(resource.Resource):
6	qargs = []
7	else:
8	qs = env['QUERY_STRING'] = request.uri[qindex+1:]
9	- if '=' in qs:
10	+ if b'=' in qs:
11	qargs = []
12	else:
13	- qargs = [urllib.unquote(x) for x in qs.split('+')]
14	+ qargs = [urllib.parse.unquote(x.decode()) for x in qs.split(b'+')]
15
16	# Propagate HTTP headers
17	for title, header in request.getAllHeaders().items():