charm-haproxy

Merge lp:~erik-lonroth/charm-haproxy/charmcraft_build into lp:charm-haproxy

  1. charmcraft_build
  2. Merge into trunk
Proposed by Erik Lönroth
Status: Rejected
Rejected by: Haw Loeung
Proposed branch: lp:~erik-lonroth/charm-haproxy/charmcraft_build
Merge into: lp:charm-haproxy
Diff against target: 47 lines (+31/-1)
2 files modified
README.md (+1/-1)
charmcraft.yaml (+30/-0)
To merge this branch: bzr merge lp:~erik-lonroth/charm-haproxy/charmcraft_build
Reviewer Review Type Date Requested Status
Tom Haddon Needs Information
Canonical IS Reviewers Pending
Review via email: mp+415151@code.launchpad.net

Commit message

Added charmcraft.yaml which allows building with charmcraft

Description of the change

This will build the charm with charmcraft.

I've tested it with focal, bionic, xenial and trusty.

It seems that all except trusty works. Not sure why. Might be worth dropping support for trusty...

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Tom Haddon (mthaddon) wrote :

I don't think we should be progressing with this if it doesn't work on trusty as is, since trusty is still covered under ESM. Sounds like this will need some further testing to confirm why it's failing on trusty, if this can be fixed, or is not supported with charmcraft and then a decision made about what to do from there. Marking "Needs Fixing" for now.

review: Needs Fixing
Revision history for this message
Tom Haddon (mthaddon) wrote :

I've just tested this on trusty and it seems to work fine. Can you clarify how this was failing for you?

The test I did was:

juju deploy haproxy --series trusty
juju deploy apache2
juju relate haproxy:reverseproxy apache2:website

And then verify if I hit the IP address of the HAProxy instance I get the Apache2 Ubuntu Default Page.

I tried this both with the released version of the HAProxy charm and with a locally built version using this branch and they worked in the same way.

Revision history for this message
Tom Haddon (mthaddon) :
review: Needs Information

Unmerged revisions

152. By Erik Lönroth

Builds with charmcraft v.1.4+

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README.md'
2--- README.md 2021-10-01 16:02:00 +0000
3+++ README.md 2022-02-04 23:56:56 +0000
4@@ -131,7 +131,7 @@
5 relation-set "services=
6 - { service_name: my_web_app,
7 service_options: [mode http, balance leastconn],
8- crts: [DEFAULT]
9+ crts: [DEFAULT],
10 servers: [[my_web_app_1, $host, $port, option httpchk GET / HTTP/1.0],
11 [... optionally more servers here ...]]}
12 - { ... optionally more services here ... }
13
14=== added file 'charmcraft.yaml'
15--- charmcraft.yaml 1970-01-01 00:00:00 +0000
16+++ charmcraft.yaml 2022-02-04 23:56:56 +0000
17@@ -0,0 +1,30 @@
18+type: charm
19+
20+bases:
21+ - build-on:
22+ - name: "ubuntu"
23+ channel: "20.04"
24+ run-on:
25+ - name: "ubuntu"
26+ channel: "14.04"
27+ - name: ubuntu
28+ channel: "16.04"
29+ - name: ubuntu
30+ channel: "18.04"
31+ - name: ubuntu
32+ channel: "20.04"
33+
34+parts:
35+ haproxy:
36+ plugin: dump
37+ source: .
38+ prime:
39+ - README.md
40+ - config.yaml
41+ - copyright
42+ - hooks
43+ - files
44+ - data
45+ - icon.svg
46+ - metadata.yaml
47+ - charm-helpers.yaml

Subscribers

People subscribed via source and target branches

to all changes: