QtMir

CMakeLists.txt (+3/-3)
demos/qml-demo-shell/qml-demo-shell.qml (+19/-0)
src/modules/Unity/Application/mirbuffersgtexture.cpp (+5/-0)
src/modules/Unity/Application/mirbuffersgtexture.h (+1/-0)
src/modules/Unity/Application/mirsurface.cpp (+3/-1)
src/modules/Unity/CMakeLists.txt (+1/-0)
src/modules/Unity/Screens/CMakeLists.txt (+24/-0)
src/modules/Unity/Screens/plugin.cpp (+41/-0)
src/modules/Unity/Screens/qmldir (+2/-0)
src/modules/Unity/Screens/screens.cpp (+107/-0)
src/modules/Unity/Screens/screens.h (+82/-0)
src/platforms/mirserver/CMakeLists.txt (+5/-2)
src/platforms/mirserver/display.cpp (+0/-44)
src/platforms/mirserver/display.h (+0/-37)
src/platforms/mirserver/logging.h (+1/-0)
src/platforms/mirserver/miropenglcontext.cpp (+25/-10)
src/platforms/mirserver/miropenglcontext.h (+1/-0)
src/platforms/mirserver/mirserver.cpp (+32/-4)
src/platforms/mirserver/mirserver.h (+8/-2)
src/platforms/mirserver/mirserverintegration.cpp (+51/-40)
src/platforms/mirserver/mirserverintegration.h (+4/-7)
src/platforms/mirserver/offscreensurface.cpp (+61/-0)
src/platforms/mirserver/offscreensurface.h (+43/-0)
src/platforms/mirserver/qmirserver.cpp (+12/-2)
src/platforms/mirserver/qmirserver.h (+3/-0)
src/platforms/mirserver/qmirserver_p.h (+2/-0)
src/platforms/mirserver/qtcompositor.cpp (+9/-34)
src/platforms/mirserver/qtcompositor.h (+13/-5)
src/platforms/mirserver/qteventfeeder.cpp (+104/-85)
src/platforms/mirserver/qteventfeeder.h (+11/-8)
src/platforms/mirserver/screen.cpp (+109/-7)
src/platforms/mirserver/screen.h (+33/-3)
src/platforms/mirserver/screencontroller.cpp (+258/-0)
src/platforms/mirserver/screencontroller.h (+96/-0)
src/platforms/mirserver/screenwindow.cpp (+71/-92)
src/platforms/mirserver/screenwindow.h (+13/-24)
src/platforms/mirserver/tileddisplayconfigurationpolicy.cpp (+44/-0)
src/platforms/mirserver/tileddisplayconfigurationpolicy.h (+35/-0)
tests/common/fake_displayconfigurationoutput.h (+77/-0)
tests/common/gmock_fixes.h (+124/-0)
tests/common/mock_display.h (+53/-0)
tests/common/mock_display_configuration.h (+35/-0)
tests/common/mock_gl_display_buffer.h (+49/-0)
tests/common/mock_main_loop.h (+53/-0)
tests/mirserver/CMakeLists.txt (+1/-0)
tests/mirserver/QtEventFeeder/mock_qtwindowsystem.h (+16/-9)
tests/mirserver/QtEventFeeder/qteventfeeder_test.cpp (+27/-16)
tests/mirserver/Screen/CMakeLists.txt (+1/-0)
tests/mirserver/Screen/screen_test.cpp (+38/-26)
tests/mirserver/ScreenController/CMakeLists.txt (+29/-0)
tests/mirserver/ScreenController/screencontroller_test.cpp (+189/-0)
tests/mirserver/ScreenController/stub_display.h (+96/-0)
tests/mirserver/ScreenController/stub_screen.h (+31/-0)
tests/mirserver/ScreenController/testable_screencontroller.h (+37/-0)
tests/modules/common/qtmir_test.h (+1/-1)

To merge this branch:

bzr merge lp:~gerboland/qtmir/multimonitor

Related bugs:

Bug #1436735: /usr/bin/unity8:11:DisplayWindow::makeCurrent:MirOpenGLContext::makeCurrent:QOpenGLContext::makeCurrent:QSGRenderThread::invalidateOpenGL:QSGRenderThread::event	Undecided	Invalid
Bug #1488831: booting with slimport connected to nexus4 seems to be an issue	High	Fix Released
Bug #1488863: nexus4 & nexus7 hotplug survival	Critical	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Michał Sawicz			Abstain on 2015-10-21
PS Jenkins bot (community)	continuous-integration	2015-09-30	Needs Fixing on 2015-10-20
Daniel d'Andrada (community)		2015-09-30	Approve on 2015-09-30
Review via email: mp+272912@code.launchpad.net

This proposal supersedes a proposal from 2015-09-02.

Commit message

Initial multimonitor support - react correctly to Mir DisplayConfiguration changes.

On Mir DisplayConfiguration changes, QtMir now correctly:
1. blocks Mir until it has stopped all renderers and has their GL contexts released
2. reads the new DisplayConfiguration, matches any existing ScreenWindows to new DisplayBuffers should they change (as Mir may destroy and create it on us)
3. restarts all renderers

This also solves shutdown crash issues due to raciness of mir destroying the GL context backing the shell's QWindow before its renderer had stopped.

Add Unity.Screens qml module to advertise current screen state to QML.

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.
N
* Did you perform an exploratory manual test run of your code change and any related functionality?
Y
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

Revision history for this message

Gerry Boland (gerboland) wrote on 2015-07-22: Posted in a previous version of this proposal

The QML demo is pretty lame, but I'm holding on until your demo work in the mirSurface is approved.

Also there are FIXMEs related to input, which I would prefer to address later. This MR is big enough.

Revision history for this message

Gerry Boland (gerboland) wrote on 2015-07-22: Posted in a previous version of this proposal

Gah, input on second display not working

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-07-22: Posted in a previous version of this proposal

PASSED: Continuous integration, rev:338
http://jenkins.qa.ubuntu.com/job/qtmir-ci/320/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/53
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/53
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/53/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/320/rebuild

review: Approve (continuous-integration)

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-07-24: Posted in a previous version of this proposal

Download full text (8.2 KiB)

src/modules/Unity/Screens/screens.h:

"""
public Q_SLOTS:
void onScreenAdded(QScreen *screen);
void onScreenRemoved(QScreen *screen);
"""

Shouldn't they be private?

--------------------------------

src/platforms/mirserver/miropenglcontext.h

"""
EGLDisplay m_eglDisplay;
EGLContext m_eglContext;
"""

You store them as member variables but they are still only used in the constructor.

----------------------------------

In MirServerIntegration::createPlatformWindow:

"""
qDebug() << "createPlatformWindow" << window;
"""

A leftover.

"""
// If Screen was not specified, just grab an unused one, if available
"""

I don't get the first "if". This method doesn't seem to handle the case where a screen *is* specified. It doesn't even seem possible.

"""
    if (!screens) {
        qDebug() << "Screens are not initialized, unable to create a new QWindow/ScreenWindow";
        return nullptr;
    }
    [...]
    if (!screen) {
        qDebug() << "No available Screens to create a new QWindow/ScreenWindow for";
        return nullptr;
    }
"""

I think these should be turned into criticals (and also use the logging category API).

"""
qDebug() << "New" << window << "with geom" << window->geometry()
<< "is backed by a" << screen << "with geometry" << screen->geometry();
"""

You might want to keep this, but using the logging category API.

--------------------------

In MirServerIntegration::initialize()

"""
qDebug() << "ScreenController not initialized";
"""

More qDebug. Maybe this should be a qFatal?

-----------------------------

In src/platforms/mirserver/offscreensurface.cpp

"""
#include <QDebug>
"""

You don't need that.

----------------------------

In src/platforms/mirserver/qmirserver.h:

"""
QWeakPointer<ScreenController> screenController() const;
"""

Why return a weak pointer if all users of it do "screenController().lock()"?. So why not make it return a shared pointer already (making for cleaner code)?

------------------------------

QtEventFeeder::QtEventFeeder

I think it would be cleaner to have two constructors instead:

QtEventFeeder::QtEventFeeder(QSharedPointer<ScreenController> screenController)
: QtEventFeeder(new QtWindowSystem(screenController))
{
}

QtEventFeeder::QtEventFeeder(QtEventFeeder::QtWindowSystemInterface *windowSystem)
{
- if (windowSystem) {
- mQtWindowSystem = windowSystem;
- } else {
- mQtWindowSystem = new QtWindowSystem;
- }
}

And remove the "= nullptr" from the signature of the second one.

--------------------------

"""
void QtEventFeeder::dispatch(MirEvent const& event)
{
- auto type = mir_event_get_type(&event);
- if (type != mir_event_type_input)
- return;
"""

Why remove it?

----------------------

"""
void QtEventFeeder::sendActiveTouchRelease(ulong timestamp, int id)
{
[...]
+ mQtWindowSystem->handleTouchEvent(mQtWindowSystem->focusedWindow(), timestamp, mTouchDevice, touchPoints);
}
"""

You have to pass the window chosen in QtEventFeeder::dispatchTouch to validateTouches() as well, so that the function above send the event to the correct window.

----------------------------

Please update...

src/modules/Unity/Screens/screens.h:

"""
public Q_SLOTS:
    void onScreenAdded(QScreen *screen);
    void onScreenRemoved(QScreen *screen);
"""

Shouldn't they be private?

--------------------------------

src/platforms/mirserver/miropenglcontext.h

"""
    EGLDisplay m_eglDisplay;
    EGLContext m_eglContext;
"""

You store them as member variables but they are still only used in the constructor.

----------------------------------

In MirServerIntegration::createPlatformWindow:

"""
    qDebug() << "createPlatformWindow" << window;
"""

A leftover.

"""
    // If Screen was not specified, just grab an unused one, if available
"""

I don't get the first "if". This method doesn't seem to handle the case where a screen *is* specified. It doesn't even seem possible.

I think these should be turned into criticals (and also use the logging category API).

"""
    qDebug() << "New" << window << "with geom" << window->geometry()
             << "is backed by a" << screen << "with geometry" << screen->geometry();
"""

You might want to keep this, but using the logging category API.

--------------------------

In MirServerIntegration::initialize()

"""
        qDebug() << "ScreenController not initialized";
"""

More qDebug. Maybe this should be a qFatal?

-----------------------------

In src/platforms/mirserver/offscreensurface.cpp

"""
#include <QDebug>
"""

You don't need that.

----------------------------

In src/platforms/mirserver/qmirserver.h:

"""
    QWeakPointer<ScreenController> screenController() const;
"""

Why return a weak pointer if all users of it do "screenController().lock()"?. So why not make it return a shared pointer already (making for cleaner code)?

------------------------------

QtEventFeeder::QtEventFeeder

I think it would be cleaner to have two constructors instead:

QtEventFeeder::QtEventFeeder(QSharedPointer<ScreenController> screenController)
    : QtEventFeeder(new QtWindowSystem(screenController))
{
}

QtEventFeeder::QtEventFeeder(QtEventFeeder::QtWindowSystemInterface *windowSystem)
{
-    if (windowSystem) {
-        mQtWindowSystem = windowSystem;
-    } else {
-        mQtWindowSystem = new QtWindowSystem;
-    }
}

And remove the "= nullptr" from the signature of the second one.

--------------------------

"""
void QtEventFeeder::dispatch(MirEvent const& event)
{
-    auto type = mir_event_get_type(&event);
-    if (type != mir_event_type_input)
-        return;
"""

Why remove it?

----------------------

"""
void QtEventFeeder::sendActiveTouchRelease(ulong timestamp, int id)
{
    [...]
+    mQtWindowSystem->handleTouchEvent(mQtWindowSystem->focusedWindow(), timestamp, mTouchDevice, touchPoints);
}
"""

You have to pass the window chosen in QtEventFeeder::dispatchTouch to validateTouches() as well, so that the function above send the event to the correct window.

----------------------------

Please update copyright header of src/platforms/mirserver/screen.*

----------------------------

src/platforms/mirserver/screencontroller.*

I thought we dropped use of "Authors" field in copyright headers.

----------------------------

src/platforms/mirserver/screencontroller.cpp

I think it would be better to have the class documentation in the header instead of in the .cpp.

"""
        if (window && window->window()) { qDebug() << "SHOW" << window;
[...]
        if (window && window->window()) { qDebug() << "HIDE" << window;
"""

Do you want to keep these debug messages?

"""
            //window->setVisible(false);
"""

Old code to be removed?

"""
    auto displayConfig = display->configuration();
"""

I think you're abusing the use of "auto" here. I would prefer to know the class of this object.

"""
        // The screen is automatically removed from Qt's internal list by the QPlatformScreen deconstructor.
        auto window = static_cast<ScreenWindow *>(screen->window());
        if (window && window->window() && window->isExposed()) { qDebug() << "HIDE!" << window;
            //window->setVisible(false);
            window->window()->hide();
        }
"""

s/deconstructor/destructor ?

Again, do you intend to keep this debug message and the commented-out code?

"""
    qCDebug(QTMIR_SCREENS) << "ScreenController::getUnusedScreen";
"""

Is this message useful in general?

-------------------------------

src/platforms/mirserver/screencontroller.h

"""
// local
#include "mirserver.h"
"""

Is this include really needed?

"""
    virtual Screen *screenFactory(const mir::graphics::DisplayConfigurationOutput &output) const;
"""

I would prefer to be straightforward and name it "createScreen".

"""
    friend class MirServer;
"""

I don't like this design of making methods protected/private and adding the consumer of them as a friend class. It just obfuscates the interface this class exposes to consumers. Now the friend class also has direct access to all member variables etc and I'm sure you don't mean it to.

I vote for removing the friendship and making the relevant methods public. In the header you could group methods by consumer and document them (e.g "// Used by MirServer"). Like lightweight interfaces.

If you're really paranoid about controlling access you can go all the way and do like mir, defining an actual interface for each kind of consumer and making ScreenController implement them all.

---------------------------

src/platforms/mirserver/screenwindow.h

"""
 * Copyright (C) 2013 Canonical, Ltd.
"""

Please update.

"""
    //bool isExposed() const override;
"""

Please delete it.

-----------------------------

src/platforms/mirserver/screenwindow.cpp

"""
 * Copyright (C) 2013,2014 Canonical, Ltd.
"""

Please update.

"""
    qDebug() << "ScreenWindow::ScreenWindow" << this;
"""

This is a good oportunity to update this class to use categorized logging.

"""
    auto windowscreen = static_cast<Screen *>(screen());
    Q_ASSERT(windowscreen);
    windowscreen->setWindow(this);
"""

A windowScreen inside a screenWindow... Calling it simply "screen" would help keeping my sanity.

"""
//bool ScreenWindow::isExposed() const
//{
//    return m_isExposed;
//}
"""

Please delete it.

"""
    // Intercept Hide event and convert to Expose event, as Hide causes Qt to release GL
    // resources, which we don't want. Must intercept Show to un-do hide.
    if (event->type() == QEvent::Hide) {
        qDebug() << "ScreenWindow::event got QEvent::Hide";
        m_isExposed = false;
        //QWindowSystemInterface::handleExposeEvent(window(), QRect());
        //QWindowSystemInterface::flushWindowSystemEvents();
        //return true;
    } else if (event->type() == QEvent::Show) {
        qDebug() << "ScreenWindow::event got QEvent::Show";
        m_isExposed = true;
        //QRect rect(QPoint(), geometry().size());
        //QWindowSystemInterface::handleExposeEvent(window(), rect);
        //QWindowSystemInterface::flushWindowSystemEvents();
        //return true;
    }
"""

And all this commented-out code too.

By the way, does the comment above this if{}else{} still hold? You're no longer converting them to expose events here.

Now that this class no longer has a isExposed() getter, is this m_isExposed variable being used for anything?

If not, I guess you could even get rid of the entire ScreenWindow::event() method?

"""
    qDebug() << "ScreenWindow::doneCurrent";
"""

Do we want to keep this?

----------------------------------

src/platforms/mirserver/tileddisplayconfigurationpolicy.h

"""
 * Copyright (C) 2014 Canonical, Ltd.
"""

Time has passed.

------------------------------------

src/platforms/mirserver/tileddisplayconfigurationpolicy.cpp

"""
 * Copyright (C) 2014 Canonical, Ltd.
"""

Same here.

-------------------------------------

tests/common/fake_displayconfigurationoutput.h

"""
const mg::DisplayConfigurationOutput fake_output1
"""

We use camelCase.

-------------------------------------

tests/mirserver/ScreenController/screencontroller_test.cpp

"""
    ScreenController *sc;
"""

I don't think this two-letters name helps with readability.

review: Needs Fixing

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-07-24: Posted in a previous version of this proposal

As for testing: When I connected my monitor to the micro hdmi port of my yoga 2 laptop, qtmir detected the new display and reacted accordingly. So I saw the unity logo on a green background in the external monitor.

But when I disconnected it, nothing happened on qtmir side. Connected back again and that was when I got the screen disconnected info in qtmir, it seems. Restarted the qml mirserver and now it wouldn't detect the external monitor at all.

Rebooted the laptop.

Run the mirserver again. Connected the external monitor. All fine. Disconnected and reconnected and boom. Laptop shuts itself down.

Despite the somewhat bad results, since this is just the first step in the multi-monitor story I'm still ok with having it merged.

Revision history for this message

Gerry Boland (gerboland) wrote on 2015-07-27: Posted in a previous version of this proposal

I'll be addressing your code comments soon.

On your testing, please watch the console output carefully. ScreenController::update() prints the list of displays each time Mir notifies it something changed. When you unplug, does this list get updated correctly?

Also, can you have the shell animating on both screens before you unplug?

Can you compare with mir_proving_server too?

I'm just trying to figure out if it is a QtMir bug, or a Mir one.
Thanks for the review!

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-07-27: Posted in a previous version of this proposal

PASSED: Continuous integration, rev:354
http://jenkins.qa.ubuntu.com/job/qtmir-ci/327/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/60
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/60
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/60/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/327/rebuild

review: Approve (continuous-integration)

Revision history for this message

Gerry Boland (gerboland) wrote on 2015-08-06: Posted in a previous version of this proposal

I think I've followed all the recommendations you've made. I've only a couple of replies:

> """
> // If Screen was not specified, just grab an unused one, if available
> """
>
> I don't get the first "if". This method doesn't seem to handle the case where
> a screen *is* specified. It doesn't even seem possible.

You're right, it was terribly phrased. Have updated it to make sense now

> qDebug() << "Screens are not initialized, unable to create a new
> QWindow/ScreenWindow";
<snip>
> qDebug() << "No available Screens to create a new QWindow/ScreenWindow
>
> I think these should be turned into criticals (and also use the logging
> category API).

I did make them critical, but I always want those errors to print so didn't make them part of a category.

> In src/platforms/mirserver/qmirserver.h:
>
> """
> QWeakPointer<ScreenController> screenController() const;
> """
>
> Why return a weak pointer if all users of it do "screenController().lock()"?.
> So why not make it return a shared pointer already (making for cleaner code)?

Because the QMirServer has ownership of the ScreenController, and manages its lifetime. A ScreenController will only exist after the mir server is started, and must be deleted before mir shuts down. I can't have API users keeping it around longer than it should.

This may be exposing an API problem which can be resolved, but I didn't see any obvious solution. So this will have to do.

> src/platforms/mirserver/screencontroller.cpp
> """
> auto displayConfig = display->configuration();
> """
>
> I think you're abusing the use of "auto" here. I would prefer to know the
> class of this object.

You really want to know is it std::unique_ptr<mg::DisplayConfiguration> ? I don't, the variable name is enough for me.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-08-06: Posted in a previous version of this proposal

PASSED: Continuous integration, rev:366
http://jenkins.qa.ubuntu.com/job/qtmir-ci/346/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/79
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/79
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/79/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/346/rebuild

review: Approve (continuous-integration)

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-08-06: Posted in a previous version of this proposal

On 06/08/15 08:49, Gerry Boland wrote:
>> qDebug() << "Screens are not initialized, unable to create a new
>> > QWindow/ScreenWindow";
> <snip>
>> > qDebug() << "No available Screens to create a new QWindow/ScreenWindow
>> >
>> > I think these should be turned into criticals (and also use the logging
>> > category API).
> I did make them critical, but I always want those errors to print so didn't make them part of a category.
>

This doesn't stop you from using logging categories. You can configure
logging categories to print by severity. Eg: only from warnings and
upwards, or only criticals.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-08-06: Posted in a previous version of this proposal

PASSED: Continuous integration, rev:367
http://jenkins.qa.ubuntu.com/job/qtmir-ci/347/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/80
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/80
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/80/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/347/rebuild

review: Approve (continuous-integration)

Revision history for this message

Gerry Boland (gerboland) wrote on 2015-08-06: Posted in a previous version of this proposal

> On 06/08/15 08:49, Gerry Boland wrote:
> > I did make them critical, but I always want those errors to print so didn't
> make them part of a category.
> >
>
> This doesn't stop you from using logging categories. You can configure
> logging categories to print by severity. Eg: only from warnings and
> upwards, or only criticals.

I know that. But IMO this error should always print if that codepath hit, as it's an error path which I see no reason to be filter-able.

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-08-06: Posted in a previous version of this proposal

"""
qtmir (0.4.6) vivid; urgency=medium

"""

nitpick: Shouldn't it be UNRELEASED instead of vivid?

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-08-06: Posted in a previous version of this proposal

Good clean up! Only a couple of minor issues left:

----------------------

Please update copyright year of src/platforms/mirserver/miropenglcontext.cpp

---------------------

src/platforms/mirserver/screencontroller.cpp

It still has some qDebug() messages and commented-out code.

"""
if (window && window->window()) { qDebug() << "HIDE" << window;
"""

"""
//window->setVisible(false);
"""

NB: the stuff above appears in two separate locations in the file

----------------------------------

In tests/mirserver/ScreenController/screencontroller_test.cpp

"""
ASSERT_EQ(screenController->screens().count(), 1);
"""

Google test format for assertions is as follows: ASSERT_EQ(expected, actual)

But in this file you're doing the other way around, which will make for confusing messages in case of failure.

Same goes for EXPECT_EQ() and friends.

review: Needs Fixing

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-08-06: Posted in a previous version of this proposal

Ah, and the qml-demo-shell changes, naturally. You probably gonna rebase this branch on top of lp:~dandrader/qtmir/mousePointer or lp:~dandrader/qtmir/mirSurface, right?

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-08-07: Posted in a previous version of this proposal

PASSED: Continuous integration, rev:371
http://jenkins.qa.ubuntu.com/job/qtmir-ci/349/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/82
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/82
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/82/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/349/rebuild

review: Approve (continuous-integration)

Revision history for this message

Gerry Boland (gerboland) wrote on 2015-09-02: Posted in a previous version of this proposal

Ways to test:
1. on N4/N7, install the packages and reboot. Plug in external display with slimport cable - you should see part of unity8 on the external display. (unity8 crashed before)

2. on N4/N7/desktop, stop lightdm, and run the qml-demo-shell demo at root (QT_QPA_PLATFORM=mirserver qmlscene qml-demo-shell.qml). Try plugging/unplugging displays - you should see independent shells on each connected display.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-02: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:373
http://jenkins.qa.ubuntu.com/job/qtmir-ci/388/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/121/console
FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/121/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/388/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-02: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:376
http://jenkins.qa.ubuntu.com/job/qtmir-ci/389/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/122/console
FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/122/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/389/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-02: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:377
http://jenkins.qa.ubuntu.com/job/qtmir-ci/390/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/123/console
FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/123/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/390/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-09-02: Posted in a previous version of this proposal

Code looks ok.

Tested on a N7 with unity8 and it works. Connecting an external monitor shows the cloned image there (albeit cut off) and disconnecting it doesn't crash unity8.

qml-demo-shell on the N7 freezes. Don't know if it's related to this MP.

Also could not test on my laptop as its flimsy micro-HDMI port seems to be broken, or preferably, my "HDMI to micro-HDMI" adaptor. :(

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-03: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:378
http://jenkins.qa.ubuntu.com/job/qtmir-ci/394/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/127/console
FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/127/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/394/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Gerry Boland (gerboland) wrote on 2015-09-03: Posted in a previous version of this proposal

Testing this as a nested server, I have found
https://bugs.launchpad.net/mir/+bug/1491816
which needs the Mir team to investigate.

Which means this is unreliable to test as a nested server while adding/removing monitors and trying to draw on them all.

So the only things you can reliably test are
1. phone/tablet - testing a nested QtMir server (i.e. unity8) does not crash on plug/unplug of external monitor
2. desktop - running QtMir as host server - here plug/unplug of monitor will succeed.

Revision history for this message

Gerry Boland (gerboland) wrote on 2015-09-03: Posted in a previous version of this proposal

Have resolved the issue I reported in the Mir bug above. I was using an API I wasn't supposed to. Now nested servers work reliably.

So in testing, the only situation where QtMir will not work reliably is:
- android, host server
mainly because of the buffer post thing.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-03: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:379
http://jenkins.qa.ubuntu.com/job/qtmir-ci/395/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/128/console
FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/128/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/395/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michael Terry (mterry) wrote on 2015-09-04: Posted in a previous version of this proposal

tests/mirserver/ScreenController/stub_display.h needs an "#include <chrono>"

Revision history for this message

Michael Terry (mterry) wrote on 2015-09-04: Posted in a previous version of this proposal

Using just this branch on top of rc-proposed, I don't see any changes when I plug in an external monitor. Nothing crashes, but nothing changes either. And I don't see any obvious screen-list dumps in the log, like you mentioned I might see.

So I'm guessing I need another branch?

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-09-10: Posted in a previous version of this proposal

ScreenController test fails.

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-10: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:380
http://jenkins.qa.ubuntu.com/job/qtmir-ci/410/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/143/console
FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/143/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/410/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-14: Posted in a previous version of this proposal

PASSED: Continuous integration, rev:386
http://jenkins.qa.ubuntu.com/job/qtmir-ci/415/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/148
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/148
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/148/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/415/rebuild

review: Approve (continuous-integration)

Revision history for this message

Gerry Boland (gerboland) wrote on 2015-09-18: Posted in a previous version of this proposal

I declare this is ready for a final review pass. There are issues remaining, which appear to be USC/Mir-based:
https://bugs.launchpad.net/mir/+bug/1496069
But I'd prefer to land this and then work on those after.

Revision history for this message

Gerry Boland (gerboland) wrote on 2015-09-18: Posted in a previous version of this proposal

Ways to test:
1. desktop - as root user:
    systemctl stop lightdm
    export QT_QPA_PLATFORM=mirserver
    qmlscene qml-demo-shell.qml
and then plug/unplug external monitor. You should see the simple shell appear on all screens.

2. phone, with unity8 up
plug/unplug monitor, verify shell does not crash.
Depending on USC's mood, you might see unity8 on the external display, or you might not. Touch input unreliable, due to USC we think.

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-09-21: Posted in a previous version of this proposal

Code still looks ok and tests pass again.

Proceeding with manual tests now...

review: Approve (code & tests)

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-09-21: Posted in a previous version of this proposal

> 2. phone, with unity8 up
> plug/unplug monitor, verify shell does not crash.
> Depending on USC's mood, you might see unity8 on the external display, or you
> might not. Touch input unreliable, due to USC we think.

Tried that on my Nexus 7.
When I plug in the external monitor, the UI on the device flashes for a split second. Then I unplug the monitor (I think it flashes again, not sure now). But then it doesn't to input anymore and eventually crashes. :(

Revision history for this message

Daniel d'Andrada (dandrader) on 2015-09-21: Posted in a previous version of this proposal

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-28: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/442/rebuild

review: Approve (continuous-integration)

Revision history for this message

Gerry Boland (gerboland) wrote on 2015-09-28: Posted in a previous version of this proposal

> > 2. phone, with unity8 up
> > plug/unplug monitor, verify shell does not crash.
> > Depending on USC's mood, you might see unity8 on the external display, or
> you
> > might not. Touch input unreliable, due to USC we think.
>
> Tried that on my Nexus 7.
> When I plug in the external monitor, the UI on the device flashes for a split
> second. Then I unplug the monitor (I think it flashes again, not sure now).
> But then it doesn't to input anymore and eventually crashes. :(

Something to watch carefully is if unity8 crashes alone, or USC crashes which brings unity8 down with it. There are some input handling bugs in Mir/USC with multimonitor which are things we need the Mir team to fix.

Revision history for this message

Gerry Boland (gerboland) wrote on 2015-09-28: Posted in a previous version of this proposal

https://bugs.launchpad.net/mir/+bug/1496069 contains the issue in Mir you may be experiencing

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-09-28: Posted in a previous version of this proposal

Tested with a fresh image (no multimonitor branch).

Plugging in an external monitor makes unity8 restart, and so does unplugging it.

Therefore this branch doesn't make matters worse. It just makes it crash in a different way.

review: Approve

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-09-28: Posted in a previous version of this proposal

But it still feels odd to land a branch that doesn't get us anywhere... As it still crashes, I can't be confident that it's indeed doing the right thing...

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-09-28: Posted in a previous version of this proposal

Running unity8 + qtmir/multimonitor on a wily laptop (tried with both mir 0.16 and mir 0.17), once I connect an external monitor it crashes.

Should it work? or is the crash expected?

review: Needs Information

Revision history for this message

Gerry Boland (gerboland) wrote on 2015-09-29: Posted in a previous version of this proposal

No crashes are expected. I've just tested on Wily, and I can't reproduce a crash.

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-09-29: Posted in a previous version of this proposal

Not getting a crash anymore... Don't know what happened.

Since mousePointer is gonna land before this branch, I've it rebased on top of mousePointer here: lp:~dandrader/qtmir/mousePointer-multimonitor. Should make your rebase painless.

review: Approve

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-09-30:

LGTM

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-30:

FAILED: Continuous integration, rev:388
http://jenkins.qa.ubuntu.com/job/qtmir-ci/459/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-amd64-ci/155/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/155/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-i386-ci/37/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/192/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/192/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-i386-ci/37/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/459/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michał Sawicz (saviq) wrote on 2015-10-20:

This merge breaks unity8's autopilot panel tests:

$ autopilot3 run unity8.indicators.tests.test_indicators.IndicatorPageTitleMatchesWidgetTestCase.test_indicator_page_title_matches_widget

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/unity8/indicators/tests/test_indicators.py", line 79, in test_indicator_page_title_matches_widget
    self.indicator_name)
  File "/usr/lib/python3/dist-packages/autopilot/logging.py", line 46, in inner
    return f(instance, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/unity8/shell/__init__.py", line 146, in open_indicator_page
    self.wait_select_single('IndicatorsMenu', fullyOpened=True)
  File "/usr/lib/python3/dist-packages/autopilot/introspection/dbus.py", line 295, in wait_select_single
    return self.select_single(type_name, **kwargs)
  File "/usr/lib/python3/dist-packages/autopilot/introspection/dbus.py", line 244, in select_single
    raise StateNotFoundError(type_name_str, **kwargs)
autopilot.exceptions.StateNotFoundError: Object not found with name 'IndicatorsMenu' and properties {'fullyOpened': True}.

You can reproduce with unity8 trunk by installing unity8-fake-env along with qtmir from silo 22. The problem appears to be that when the panel drag gesture reaches the bottom, about 50% of the time the touch isn't ended, which results in the panel getting stuck a few pixels above the bottom edge, never completing the gesture.

I'll be providing some debugging output from DirectionalDragArea and TouchRegistry soon.

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-20:

FAILED: Continuous integration, rev:391
http://jenkins.qa.ubuntu.com/job/qtmir-ci/528/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-amd64-ci/224/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/224/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-i386-ci/106/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/261/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/261/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-i386-ci/106/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/528/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michał Sawicz (saviq) wrote on 2015-10-20:

http://paste.ubuntu.com/12878612/ shows that there's no TouchEnd delivered to the DirectionalDragArea, compared to working example before this MP: http://paste.ubuntu.com/12878646/

review: Needs Fixing

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-10-20:

On 20/10/2015 16:24, Michał Sawicz wrote:
> Review: Needs Fixing
>
> http://paste.ubuntu.com/12878612/ shows that there's no TouchEnd delivered to the DirectionalDragArea, compared to working example before this MP: http://paste.ubuntu.com/12878646/

There's no TouchEnd delivered to the QQuickWindow at all. Maybe qtmir's
QtEventFeeder discarded it somehow?

Revision history for this message

Gerry Boland (gerboland) wrote on 2015-10-21:

MirTouchEvent((id=1,action=change,x=1048.09,y=1920.35))
qtmir.mir.input: REJECTING INPUT EVENT, no matching window
qtmir.mir.input: Received MirTouchEvent((id=1,action=up,x=1048.09,y=1920.35))
qtmir.mir.input: REJECTING INPUT EVENT, no matching window

Position technically beyond bottom edge of window, but will workaround

Revision history for this message

Gerry Boland (gerboland) wrote on 2015-10-21:

Workaround fix proposed in https://code.launchpad.net/~gerboland/qtmir/multimonitorAPfix/+merge/275170

Revision history for this message

Michał Sawicz (saviq) on 2015-10-21:

review: Abstain

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

Subscribers

People subscribed via source and target branches

to all changes:

Daniel d'Andrada

Gerry Boland

Mir development team

 === modified file 'CMakeLists.txt'
 --- CMakeLists.txt	2015-10-14 23:14:58 +0000
 +++ CMakeLists.txt	2015-10-14 23:14:58 +0000
@@ -60,9 +60,9 @@
  find_package(Threads REQUIRED)
--pkg_check_modules(MIRSERVER mirserver>=0.16 REQUIRED)
--pkg_check_modules(MIRCLIENT mirclient>=0.16 REQUIRED)
--pkg_check_modules(MIRRENDERERGLDEV mir-renderer-gl-dev>=0.16 REQUIRED)
++pkg_check_modules(MIRSERVER mirserver>=0.17 REQUIRED)
++pkg_check_modules(MIRCLIENT mirclient>=0.17 REQUIRED)
++pkg_check_modules(MIRRENDERERGLDEV mir-renderer-gl-dev>=0.17 REQUIRED)
  pkg_check_modules(GLIB glib-2.0 REQUIRED)
  pkg_check_modules(PROCESS_CPP process-cpp REQUIRED)
 === renamed file 'demos/qml-demo-shell/qml-demo-shell.qml' => 'demos/qml-demo-shell/Shell.qml'
 === added file 'demos/qml-demo-shell/qml-demo-shell.qml'
 --- demos/qml-demo-shell/qml-demo-shell.qml	1970-01-01 00:00:00 +0000
 +++ demos/qml-demo-shell/qml-demo-shell.qml	2015-10-14 23:14:58 +0000
@@ -0,0 +1,19 @@
++import QtQuick 2.3
++import QtQuick.Window 2.2 as QQW
++import Unity.Screens 0.1
++
++Instantiator {
++    id: root
++
++    property var screens: Screens{}
++
++    model: screens
++    QQW.Window {
++        id: window
++        visible: true
++        Shell{ anchors.fill: parent }
++        Component.onCompleted: {
++            print("HEY", screen, screen.geometry, outputType, Screens.HDMIA)
++        }
++    }
++}
 === modified file 'src/modules/Unity/Application/mirbuffersgtexture.cpp'
 --- src/modules/Unity/Application/mirbuffersgtexture.cpp	2015-09-17 16:46:37 +0000
 +++ src/modules/Unity/Application/mirbuffersgtexture.cpp	2015-10-14 23:14:58 +0000
@@ -59,6 +59,11 @@
      m_width = size.width.as_int();
+ }
++bool MirBufferSGTexture::hasBuffer() const
++{
++    return !!m_mirBuffer;
++}
++
  int MirBufferSGTexture::textureId() const
+ {
      return m_textureId;
 === modified file 'src/modules/Unity/Application/mirbuffersgtexture.h'
 --- src/modules/Unity/Application/mirbuffersgtexture.h	2015-08-31 09:51:28 +0000
 +++ src/modules/Unity/Application/mirbuffersgtexture.h	2015-10-14 23:14:58 +0000
@@ -34,6 +34,7 @@
      void setBuffer(std::shared_ptr<mir::graphics::Buffer> buffer);
      void freeBuffer();
++    bool hasBuffer() const;
      int textureId() const override;
      QSize textureSize() const override;
 === modified file 'src/modules/Unity/Application/mirsurface.cpp'
 --- src/modules/Unity/Application/mirsurface.cpp	2015-09-18 16:33:06 +0000
 +++ src/modules/Unity/Application/mirsurface.cpp	2015-10-14 23:14:58 +0000
@@ -323,7 +323,9 @@
      const void* const userId = (void*)123;
      auto renderables = m_surface->generate_renderables(userId);
--    if (m_surface->buffers_ready_for_compositor(userId) > 0 && renderables.size() > 0) {
++    if (renderables.size() > 0 &&
++            (m_surface->buffers_ready_for_compositor(userId) > 0 || !texture->hasBuffer())
++        ) {
          // Avoid holding two buffers for the compositor at the same time. Thus free the current
          // before acquiring the next
          texture->freeBuffer();
 === modified file 'src/modules/Unity/CMakeLists.txt'
 --- src/modules/Unity/CMakeLists.txt	2014-09-22 18:06:58 +0000
 +++ src/modules/Unity/CMakeLists.txt	2015-10-14 23:14:58 +0000
@@ -1,1 +1,2 @@
  add_subdirectory(Application)
++add_subdirectory(Screens)
 === added directory 'src/modules/Unity/Screens'
 === added file 'src/modules/Unity/Screens/CMakeLists.txt'
 --- src/modules/Unity/Screens/CMakeLists.txt	1970-01-01 00:00:00 +0000
 +++ src/modules/Unity/Screens/CMakeLists.txt	2015-10-14 23:14:58 +0000
@@ -0,0 +1,24 @@
++include_directories(
++    ${CMAKE_SOURCE_DIR}/src/platforms/mirserver
++    ${Qt5Gui_PRIVATE_INCLUDE_DIRS}
++    ${MIRSERVER_INCLUDE_DIRS}
++    )
++
++set(SCREENSPLUGIN_SRC
++    plugin.cpp
++    screens.cpp
++    )
++
++add_library(unityscreensplugin SHARED
++    ${SCREENSPLUGIN_SRC}
++)
++
++target_link_libraries(
++    unityscreensplugin
++
++    Qt5::Gui
++    Qt5::Qml
++)
++
++# install
++add_qml_plugin(Unity.Screens 0.1 Unity/Screens TARGETS unityscreensplugin)
 === added file 'src/modules/Unity/Screens/plugin.cpp'
 --- src/modules/Unity/Screens/plugin.cpp	1970-01-01 00:00:00 +0000
 +++ src/modules/Unity/Screens/plugin.cpp	2015-10-14 23:14:58 +0000
@@ -0,0 +1,41 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++// Qt
++#include <QQmlExtensionPlugin>
++#include <QtQml/qqml.h>
++#include <QScreen>
++
++// local
++#include "screens.h"
++
++using namespace qtmir;
++
++class UnityScreensPlugin : public QQmlExtensionPlugin {
++    Q_OBJECT
++    Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface/1.0")
++
++    virtual void registerTypes(const char* uri)
++    {
++        Q_ASSERT(QLatin1String(uri) == QLatin1String("Unity.Screens"));
++
++        qRegisterMetaType<QScreen*>("QScreen*");
++
++        qmlRegisterType<qtmir::Screens>(uri, 0, 1, "Screens");
++    }
++};
++
++#include "plugin.moc"
 === added file 'src/modules/Unity/Screens/qmldir'
 --- src/modules/Unity/Screens/qmldir	1970-01-01 00:00:00 +0000
 +++ src/modules/Unity/Screens/qmldir	2015-10-14 23:14:58 +0000
@@ -0,0 +1,2 @@
++module Unity.Screens
++plugin unityscreensplugin
 === added file 'src/modules/Unity/Screens/screens.cpp'
 --- src/modules/Unity/Screens/screens.cpp	1970-01-01 00:00:00 +0000
 +++ src/modules/Unity/Screens/screens.cpp	2015-10-14 23:14:58 +0000
@@ -0,0 +1,107 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#include "screens.h"
++
++// mirserver
++#include "screen.h"
++
++// Qt
++#include <QGuiApplication>
++#include <QScreen>
++
++Q_DECLARE_METATYPE(QScreen*)
++
++namespace qtmir {
++
++Screens::Screens(QObject *parent) :
++    QAbstractListModel(parent)
++{
++    auto app = static_cast<QGuiApplication *>(QGuiApplication::instance());
++    if (!app) {
++        return;
++    }
++    connect(app, &QGuiApplication::screenAdded, this, &Screens::onScreenAdded);
++    connect(app, &QGuiApplication::screenRemoved, this, &Screens::onScreenRemoved);
++
++    m_screenList = QGuiApplication::screens();
++}
++
++QHash<int, QByteArray> Screens::roleNames() const
++{
++    QHash<int, QByteArray> roles;
++    roles[ScreenRole] = "screen";
++    roles[OutputTypeRole] = "outputType";
++    return roles;
++}
++
++QVariant Screens::data(const QModelIndex &index, int role) const
++{
++    if (!index.isValid() || index.row() >= m_screenList.size()) {
++        return QVariant();
++    }
++
++    switch(role) {
++    case ScreenRole:
++        return QVariant::fromValue(m_screenList.at(index.row()));
++    case OutputTypeRole:
++        auto screen = static_cast<Screen*>(m_screenList.at(index.row())->handle());
++        if (screen) {
++            return QVariant(static_cast<OutputTypes>(screen->outputType())); //FIXME: cheeky
++        } else
++            return OutputTypes::Unknown;
++    }
++
++    return QVariant();
++}
++
++int Screens::rowCount(const QModelIndex &) const
++{
++    return count();
++}
++
++int Screens::count() const
++{
++    return m_screenList.size();
++}
++
++void Screens::onScreenAdded(QScreen *screen)
++{
++    if (m_screenList.contains(screen))
++        return;
++
++    beginInsertRows(QModelIndex(), count(), count());
++    m_screenList.push_back(screen);
++    endInsertRows();
++    Q_EMIT screenAdded(screen);
++    Q_EMIT countChanged();
++}
++
++void Screens::onScreenRemoved(QScreen *screen)
++{
++    int index = m_screenList.indexOf(screen);
++    if (index < 0)
++        return;
++
++    beginRemoveRows(QModelIndex(), index, index);
++    m_screenList.removeAt(index);
++    endRemoveRows();
++    Q_EMIT screenRemoved(screen);
++    Q_EMIT countChanged();
++}
++
++
++} // namespace qtmir
 === added file 'src/modules/Unity/Screens/screens.h'
 --- src/modules/Unity/Screens/screens.h	1970-01-01 00:00:00 +0000
 +++ src/modules/Unity/Screens/screens.h	2015-10-14 23:14:58 +0000
@@ -0,0 +1,82 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#ifndef SCREENS_H
++#define SCREENS_H
++
++#include <QAbstractListModel>
++
++class QScreen;
++
++namespace qtmir {
++
++class Screens : public QAbstractListModel
++{
++    Q_OBJECT
++    Q_ENUMS(OutputTypes)
++
++    Q_PROPERTY(int count READ count NOTIFY countChanged)
++
++public:
++    enum ItemRoles {
++        ScreenRole = Qt::UserRole + 1,
++        OutputTypeRole
++    };
++
++    enum OutputTypes {
++        Unknown,
++        VGA,
++        DVII,
++        DVID,
++        DVIA,
++        Composite,
++        SVideo,
++        LVDS,
++        Component,
++        NinePinDIN,
++        DisplayPort,
++        HDMIA,
++        HDMIB,
++        TV,
++        EDP
++    };
++
++    explicit Screens(QObject *parent = 0);
++    virtual ~Screens() noexcept = default;
++
++    /* QAbstractItemModel */
++    QHash<int, QByteArray> roleNames() const override;
++    QVariant data(const QModelIndex &index, int role = ScreenRole) const override;
++    int rowCount(const QModelIndex &parent = QModelIndex()) const override;
++
++    int count() const;
++
++Q_SIGNALS:
++    void countChanged();
++    void screenAdded(QScreen *screen);
++    void screenRemoved(QScreen *screen);
++
++private Q_SLOTS:
++    void onScreenAdded(QScreen *screen);
++    void onScreenRemoved(QScreen *screen);
++
++private:
++    QList<QScreen *> m_screenList;
++};
++
++} // namespace qtmir
++
++#endif // SCREENS_H
 === modified file 'src/platforms/mirserver/CMakeLists.txt'
 --- src/platforms/mirserver/CMakeLists.txt	2015-10-14 23:14:58 +0000
 +++ src/platforms/mirserver/CMakeLists.txt	2015-10-14 23:14:58 +0000
@@ -31,6 +31,7 @@
      ${QT5PLATFORM_SUPPORT_INCLUDE_DIRS}
      ${Qt5Gui_PRIVATE_INCLUDE_DIRS}
      ${QT5_PLATFORMSUPPORT_INCLUDE_DIRS}
++    ${Qt5Quick_PRIVATE_INCLUDE_DIRS}
      ${APPLICATION_API_INCLUDE_DIRS}
+ )
@@ -55,16 +56,18 @@
      promptsessionlistener.cpp
      mirserver.cpp
      mirserverstatuslistener.cpp
--    display.cpp
      screen.cpp
--    displaywindow.cpp
++    screencontroller.cpp
++    screenwindow.cpp
      mirserverintegration.cpp
      miropenglcontext.cpp
      nativeinterface.cpp
++    offscreensurface.cpp
      qtcompositor.cpp
      services.cpp
      ubuntutheme.cpp
      clipboard.cpp
++    tileddisplayconfigurationpolicy.cpp
      tracepoints.c
  # We need to run moc on these headers
      ${APPLICATION_API_INCLUDEDIR}/unity/shell/application/Mir.h
 === removed file 'src/platforms/mirserver/display.cpp'
 --- src/platforms/mirserver/display.cpp	2015-08-11 12:08:32 +0000
 +++ src/platforms/mirserver/display.cpp	1970-01-01 00:00:00 +0000
@@ -1,44 +0,0 @@
--/*
-- * Copyright (C) 2013-2015 Canonical, Ltd.
-- *
-- * This program is free software: you can redistribute it and/or modify it under
-- * the terms of the GNU Lesser General Public License version 3, as published by
-- * the Free Software Foundation.
-- *
-- * This program is distributed in the hope that it will be useful, but WITHOUT
-- * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
-- * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-- * Lesser General Public License for more details.
-- *
-- * You should have received a copy of the GNU Lesser General Public License
-- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
-- */
--
--#include "display.h"
--
--#include "screen.h"
--#include "mirserver.h"
--
--#include <mir/graphics/display.h>
--#include <mir/graphics/display_configuration.h>
--
--namespace mg = mir::graphics;
--
--// TODO: Listen for display changes and update the list accordingly
--
--Display::Display(const std::shared_ptr<mir::graphics::DisplayConfiguration> &displayConfig)
--{
--    displayConfig->for_each_output([this](mg::DisplayConfigurationOutput const& output) {
--        if (output.used) {
--            auto screen = new Screen(output);
--            m_screens.push_back(screen);
--        }
--    });
--}
--
--Display::~Display()
--{
--    for (auto screen : m_screens)
--        delete screen;
--    m_screens.clear();
--}
 === removed file 'src/platforms/mirserver/display.h'
 --- src/platforms/mirserver/display.h	2015-08-11 12:08:32 +0000
 +++ src/platforms/mirserver/display.h	1970-01-01 00:00:00 +0000
@@ -1,37 +0,0 @@
--/*
-- * Copyright (C) 2013-2015 Canonical, Ltd.
-- *
-- * This program is free software: you can redistribute it and/or modify it under
-- * the terms of the GNU Lesser General Public License version 3, as published by
-- * the Free Software Foundation.
-- *
-- * This program is distributed in the hope that it will be useful, but WITHOUT
-- * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
-- * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-- * Lesser General Public License for more details.
-- *
-- * You should have received a copy of the GNU Lesser General Public License
-- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
-- */
--
--#ifndef DISPLAY_H
--#define DISPLAY_H
--
--#include <qpa/qplatformscreen.h>
--#include <memory>
--
--namespace mir { namespace graphics { class DisplayConfiguration; }}
--
--class Display
--{
--public:
--    Display(const std::shared_ptr<mir::graphics::DisplayConfiguration> &displayConfig);
--    virtual ~Display();
--
--    QList<QPlatformScreen *> screens() const { return m_screens; }
--
--private:
--    QList<QPlatformScreen *> m_screens;
--};
--
--#endif // DISPLAY_H
 === modified file 'src/platforms/mirserver/logging.h'
 --- src/platforms/mirserver/logging.h	2014-10-01 18:42:26 +0000
 +++ src/platforms/mirserver/logging.h	2015-10-14 23:14:58 +0000
@@ -25,5 +25,6 @@
  Q_DECLARE_LOGGING_CATEGORY(QTMIR_SENSOR_MESSAGES)
  Q_DECLARE_LOGGING_CATEGORY(QTMIR_MIR_INPUT)
  Q_DECLARE_LOGGING_CATEGORY(QTMIR_CLIPBOARD)
++Q_DECLARE_LOGGING_CATEGORY(QTMIR_SCREENS)
  #endif // UBUNTU_APPLICATION_PLUGIN_LOGGING_H
 === modified file 'src/platforms/mirserver/miropenglcontext.cpp'
 --- src/platforms/mirserver/miropenglcontext.cpp	2015-08-11 12:08:32 +0000
 +++ src/platforms/mirserver/miropenglcontext.cpp	2015-10-14 23:14:58 +0000
@@ -16,12 +16,14 @@
  #include "miropenglcontext.h"
--#include "displaywindow.h"
++#include "offscreensurface.h"
++#include "mirglconfig.h"
  #include "mirserver.h"
--#include "mirglconfig.h"
++#include "screenwindow.h"
  #include <QDebug>
++#include <QOpenGLFramebufferObject>
  #include <QSurfaceFormat>
  #include <QtPlatformSupport/private/qeglconvenience_p.h>
@@ -38,7 +40,7 @@
      : m_logger(new QOpenGLDebugLogger(this))
  #endif
+ {
--    std::shared_ptr<mir::graphics::Display> display = server->the_display();
++    auto display = server->the_display();
      // create a temporary GL context to fetch the EGL display and config, so Qt can determine the surface format
      std::unique_ptr<mir::graphics::GLContext> mirContext = display->create_gl_context();
@@ -106,17 +108,30 @@
  void MirOpenGLContext::swapBuffers(QPlatformSurface *surface)
+ {
--    // ultimately calls Mir's DisplayBuffer::post_update()
--    DisplayWindow *displayBuffer = static_cast<DisplayWindow*>(surface);
--    displayBuffer->swapBuffers(); //blocks for vsync
++    if (surface->surface()->surfaceClass() == QSurface::Offscreen) {
++        // NOOP
++    } else {
++        // ultimately calls Mir's DisplayBuffer::post_update()
++        ScreenWindow *screenWindow = static_cast<ScreenWindow*>(surface);
++        screenWindow->swapBuffers(); //blocks for vsync
++    }
+ }
  bool MirOpenGLContext::makeCurrent(QPlatformSurface *surface)
+ {
++    if (surface->surface()->surfaceClass() == QSurface::Offscreen) {
++        auto offscreen = static_cast<OffscreenSurface *>(surface);
++        if (!offscreen->buffer()) {
++            auto buffer = new QOpenGLFramebufferObject(surface->surface()->size());
++            offscreen->setBuffer(buffer);
++        }
++        return offscreen->buffer()->bind();
++    }
++
      // ultimately calls Mir's DisplayBuffer::make_current()
--    DisplayWindow *displayBuffer = static_cast<DisplayWindow*>(surface);
--    if (displayBuffer) {
--        displayBuffer->makeCurrent();
++    ScreenWindow *screenWindow = static_cast<ScreenWindow*>(surface);
++    if (screenWindow) {
++        screenWindow->makeCurrent();
  #ifndef QT_NO_DEBUG
          if (!m_logger->isLogging() && m_logger->initialize()) {
@@ -133,7 +148,7 @@
  void MirOpenGLContext::doneCurrent()
+ {
--    // could call Mir's DisplayBuffer::release_current(), but for what DisplayBuffer?
++    // FIXME: create a temporary GL context just to release? Would be better to get existing one.
+ }
  QFunctionPointer MirOpenGLContext::getProcAddress(const QByteArray &procName)
 === modified file 'src/platforms/mirserver/miropenglcontext.h'
 --- src/platforms/mirserver/miropenglcontext.h	2015-08-11 12:08:32 +0000
 +++ src/platforms/mirserver/miropenglcontext.h	2015-10-14 23:14:58 +0000
@@ -23,6 +23,7 @@
  #include <QOpenGLDebugLogger>
  #endif
++
  class MirServer;
  class MirOpenGLContext : public QObject, public QPlatformOpenGLContext
 === modified file 'src/platforms/mirserver/mirserver.cpp'
 --- src/platforms/mirserver/mirserver.cpp	2015-10-14 23:14:58 +0000
 +++ src/platforms/mirserver/mirserver.cpp	2015-10-14 23:14:58 +0000
@@ -23,18 +23,25 @@
  #include "mirglconfig.h"
  #include "mirserverstatuslistener.h"
  #include "promptsessionlistener.h"
++#include "screencontroller.h"
  #include "sessionlistener.h"
  #include "sessionauthorizer.h"
  #include "qtcompositor.h"
  #include "qteventfeeder.h"
++#include "tileddisplayconfigurationpolicy.h"
  #include "logging.h"
++// std
++#include <memory>
++
  // egl
++#define MESA_EGL_NO_X11_HEADERS
  #include <EGL/egl.h>
  // mir
  #include <mir/graphics/cursor.h>
++namespace mg = mir::graphics;
  namespace mo  = mir::options;
  namespace msh = mir::shell;
  namespace ms = mir::scene;
@@ -48,8 +55,10 @@
  Q_LOGGING_CATEGORY(QTMIR_MIR_MESSAGES, "qtmir.mir")
--MirServer::MirServer(int argc, char const* argv[], QObject* parent)
++MirServer::MirServer(int argc, char const* argv[],
++                     const QSharedPointer<ScreenController> &screenController, QObject* parent)
      : QObject(parent)
++    , m_screenController(screenController)
+ {
      set_command_line_handler(&ignore_unparsed_arguments);
      set_command_line(argc, argv);
@@ -74,9 +83,9 @@
              return std::make_shared<QtCompositor>();
          });
--    override_the_input_dispatcher([]
++    override_the_input_dispatcher([&screenController]
+         {
--            return std::make_shared<QtEventFeeder>();
++            return std::make_shared<QtEventFeeder>(screenController);
          });
      override_the_gl_config([]
@@ -95,12 +104,23 @@
              return std::make_shared<MirWindowManager>(the_shell_display_layout());
          });
--    set_terminator([&](int)
++    wrap_display_configuration_policy(
++        [](const std::shared_ptr<mg::DisplayConfigurationPolicy> &wrapped)
++            -> std::shared_ptr<mg::DisplayConfigurationPolicy>
++        {
++            return std::make_shared<TiledDisplayConfigurationPolicy>(wrapped);
++        });
++
++    set_terminator([](int)
+         {
              qDebug() << "Signal caught by Mir, stopping Mir server..";
              QCoreApplication::quit();
          });
++    add_init_callback([this, &screenController] {
++        screenController->init(the_display(), the_compositor());
++    });
++
      apply_settings();
      // We will draw our own cursor.
@@ -109,6 +129,14 @@
      qCDebug(QTMIR_MIR_MESSAGES) << "MirServer created";
+ }
++// Override default implementation to ensure we terminate the ScreenController first.
++// Code path followed when Qt tries to shutdown the server.
++void MirServer::stop()
++{
++    m_screenController->terminate();
++    mir::Server::stop();
++}
++
  /************************************ Shell side ************************************/
 === modified file 'src/platforms/mirserver/mirserver.h'
 --- src/platforms/mirserver/mirserver.h	2015-08-11 12:08:32 +0000
 +++ src/platforms/mirserver/mirserver.h	2015-10-14 23:14:58 +0000
@@ -18,6 +18,7 @@
  #define MIRSERVER_H
  #include <QObject>
++#include <QSharedPointer>
  #include <mir/server.h>
  class QtEventFeeder;
@@ -25,6 +26,7 @@
  class SessionAuthorizer;
  using MirShell = mir::shell::Shell;
  class PromptSessionListener;
++class ScreenController;
  // We use virtual inheritance of mir::Server to facilitate derived classes (e.g. testing)
  // calling initialization functions before MirServer is constructed.
@@ -38,12 +40,12 @@
      Q_PROPERTY(PromptSessionListener* promptSessionListener READ promptSessionListener CONSTANT)
  public:
--    MirServer(int argc, char const* argv[], QObject* parent = 0);
++    MirServer(int argc, char const* argv[], const QSharedPointer<ScreenController> &, QObject* parent = 0);
      ~MirServer() = default;
      /* mir specific */
      using mir::Server::run;
--    using mir::Server::stop;
++    using mir::Server::the_compositor;
      using mir::Server::the_display;
      using mir::Server::the_gl_config;
      using mir::Server::the_main_loop;
@@ -52,6 +54,8 @@
      using mir::Server::the_session_authorizer;
      using mir::Server::the_session_listener;
++    void stop();
++
      /* qt specific */
      // getters
      SessionAuthorizer *sessionAuthorizer();
@@ -60,7 +64,9 @@
      MirShell *shell();
  private:
++    std::weak_ptr<MirShell> m_shell;
      std::shared_ptr<QtEventFeeder> m_qtEventFeeder;
++    const QSharedPointer<ScreenController> m_screenController;
  };
  #endif // MIRSERVER_H
 === modified file 'src/platforms/mirserver/mirserverintegration.cpp'
 --- src/platforms/mirserver/mirserverintegration.cpp	2015-08-11 12:08:32 +0000
 +++ src/platforms/mirserver/mirserverintegration.cpp	2015-10-14 23:14:58 +0000
@@ -26,7 +26,8 @@
  #include <qpa/qplatforminputcontextfactory_p.h>
  #include <qpa/qwindowsysteminterface.h>
--#include <QCoreApplication>
++#include <QGuiApplication>
++#include <QStringList>
  #include <QOpenGLContext>
  #include <QDebug>
@@ -36,13 +37,16 @@
  // local
  #include "clipboard.h"
--#include "display.h"
--#include "displaywindow.h"
  #include "miropenglcontext.h"
  #include "nativeinterface.h"
++#include "offscreensurface.h"
  #include "qmirserver.h"
++#include "screen.h"
++#include "screencontroller.h"
++#include "screenwindow.h"
  #include "services.h"
  #include "ubuntutheme.h"
++#include "logging.h"
  namespace mg = mir::graphics;
  using qtmir::Clipboard;
@@ -52,7 +56,6 @@
      , m_fontDb(new QGenericUnixFontDatabase())
      , m_services(new Services)
      , m_mirServer(new QMirServer(QCoreApplication::arguments()))
--    , m_display(nullptr)
      , m_nativeInterface(nullptr)
      , m_clipboard(new Clipboard)
+ {
@@ -72,12 +75,14 @@
                       QCoreApplication::instance(), &QCoreApplication::quit);
      m_inputContext = QPlatformInputContextFactory::create();
++
++    // Default Qt behaviour doesn't match a shell's intentions, so customize:
++    qGuiApp->setQuitOnLastWindowClosed(false);
+ }
  MirServerIntegration::~MirServerIntegration()
+ {
      delete m_nativeInterface;
--    delete m_display;
+ }
  bool MirServerIntegration::hasCapability(QPlatformIntegration::Capability cap) const
@@ -87,7 +92,7 @@
      case OpenGL: return true;
      case ThreadedOpenGL: return true;
      case BufferQueueingOpenGL: return true;
--    case MultipleWindows: return false; // multi-monitor support
++    case MultipleWindows: return true; // multi-monitor support
      case WindowManagement: return false; // platform has no WM, as this implements the WM!
      case NonFullScreenWindows: return false;
      default: return QPlatformIntegration::hasCapability(cap);
@@ -98,44 +103,38 @@
+ {
      QWindowSystemInterface::flushWindowSystemEvents();
--    DisplayWindow* displayWindow = nullptr;
--
--    auto const mirServer = m_mirServer->mirServer().lock();
--    mg::DisplayBuffer* first_buffer{nullptr};
--    mg::DisplaySyncGroup* first_group{nullptr};
--    if (mirServer) {
--        mirServer->the_display()->for_each_display_sync_group([&](mg::DisplaySyncGroup &group) {
--            if (!first_group) {
--                first_group = &group;
--            }
--            group.for_each_display_buffer([&](mg::DisplayBuffer &buffer) {
--                if (!first_buffer) {
--                    first_buffer = &buffer;
--                }
--            });
--        });
--    }
--
--    // FIXME(gerry) this will go very bad for >1 display buffer
--    if (first_group && first_buffer)
--        displayWindow = new DisplayWindow(window, first_group, first_buffer);
--
--    if (!displayWindow)
--        return nullptr;
--
--    //displayWindow->requestActivateWindow();
--    return displayWindow;
++    // FIXME: QWindow can be created specifying a destination QScreen. For now we
++    // will ignore it and just associate any unused Screen, if available.
++    auto screens = m_mirServer->screenController().lock();
++    if (!screens) {
++        qCritical("Screens are not initialized, unable to create a new QWindow/ScreenWindow");
++        return nullptr;
++    }
++    Screen *screen = screens->getUnusedScreen();
++    if (!screen) {
++        qCritical("No available Screens to create a new QWindow/ScreenWindow for");
++        return nullptr;
++    }
++    QScreen *qscreen = screen->screen();
++    window->setScreen(qscreen);
++
++    auto platformWindow = new ScreenWindow(window);
++    if (screens->compositing()) {
++        platformWindow->setExposed(true);
++    }
++
++    qCDebug(QTMIR_SCREENS) << "New" << window << "with geom" << window->geometry()
++                           << "is backed by a" << screen << "with geometry" << screen->geometry();
++    return platformWindow;
+ }
--QPlatformBackingStore *MirServerIntegration::createPlatformBackingStore(QWindow *window) const
++QPlatformBackingStore *MirServerIntegration::createPlatformBackingStore(QWindow */*window*/) const
+ {
--    qDebug() << "createPlatformBackingStore" << window;
      return nullptr;
+ }
  QPlatformOpenGLContext *MirServerIntegration::createPlatformOpenGLContext(QOpenGLContext *context) const
+ {
--    qDebug() << "createPlatformOpenGLContext" << context;
      return new MirOpenGLContext(m_mirServer->mirServer(), context->format());
+ }
@@ -151,12 +150,18 @@
          exit(2);
+     }
--    m_display = new Display(m_mirServer->mirServer().data()->the_display()->configuration());
++    auto screens = m_mirServer->screenController().lock();
++    if (!screens) {
++        qFatal("ScreenController not initialized");
++    }
++    QObject::connect(screens.data(), &ScreenController::screenAdded,
++            [this](Screen *screen) { this->screenAdded(screen); });
++    Q_FOREACH(auto screen, screens->screens()) {
++        screenAdded(screen);
++    }
++
      m_nativeInterface = new NativeInterface(m_mirServer->mirServer());
--    for (QPlatformScreen *screen : m_display->screens())
--        screenAdded(screen);
--
      m_clipboard->setupDBusService();
+ }
@@ -195,3 +200,9 @@
+ {
      return m_clipboard.data();
+ }
++
++QPlatformOffscreenSurface *MirServerIntegration::createPlatformOffscreenSurface(
++        QOffscreenSurface *surface) const
++{
++    return new OffscreenSurface(surface);
++}
 === modified file 'src/platforms/mirserver/mirserverintegration.h'
 --- src/platforms/mirserver/mirserverintegration.h	2015-08-11 12:08:32 +0000
 +++ src/platforms/mirserver/mirserverintegration.h	2015-10-14 23:14:58 +0000
@@ -19,13 +19,9 @@
  // qt
  #include <qpa/qplatformintegration.h>
--
--// local
--#include "mirserver.h"
--
--class Display;
++#include <QScopedPointer>
++
  class NativeInterface;
--class MirServer;
  class QMirServer;
  namespace qtmir {
@@ -60,6 +56,8 @@
      QPlatformNativeInterface *nativeInterface() const override;
++    QPlatformOffscreenSurface *createPlatformOffscreenSurface(QOffscreenSurface *surface) const override;
++
  private:
      QScopedPointer<QPlatformAccessibility> m_accessibility;
      QScopedPointer<QPlatformFontDatabase> m_fontDb;
@@ -67,7 +65,6 @@
      QScopedPointer<QMirServer> m_mirServer;
--    Display *m_display;
      NativeInterface *m_nativeInterface;
      QPlatformInputContext* m_inputContext;
      QScopedPointer<qtmir::Clipboard> m_clipboard;
 === added file 'src/platforms/mirserver/offscreensurface.cpp'
 --- src/platforms/mirserver/offscreensurface.cpp	1970-01-01 00:00:00 +0000
 +++ src/platforms/mirserver/offscreensurface.cpp	2015-10-14 23:14:58 +0000
@@ -0,0 +1,61 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#include "offscreensurface.h"
++
++#include "mirserver.h"
++
++// Mir
++#include <mir/graphics/display.h>
++#include <mir/graphics/gl_context.h>
++
++//Qt
++#include <QOffscreenSurface>
++#include <QOpenGLFramebufferObject>
++#include <QSurfaceFormat>
++#include <QtPlatformSupport/private/qeglconvenience_p.h>
++
++namespace mg = mir::graphics;
++
++OffscreenSurface::OffscreenSurface(QOffscreenSurface *offscreenSurface)
++    : QPlatformOffscreenSurface(offscreenSurface)
++    , m_buffer(nullptr)
++    , m_format(offscreenSurface->requestedFormat())
++{
++}
++
++QSurfaceFormat OffscreenSurface::format() const
++{
++    return m_format;
++}
++
++bool OffscreenSurface::isValid() const
++{
++    if (m_buffer) {
++        return m_buffer->isValid();
++    }
++    return false;
++}
++
++QOpenGLFramebufferObject* OffscreenSurface::buffer() const
++{
++    return m_buffer;
++}
++
++void OffscreenSurface::setBuffer(QOpenGLFramebufferObject *buffer)
++{
++    m_buffer = buffer;
++}
 === added file 'src/platforms/mirserver/offscreensurface.h'
 --- src/platforms/mirserver/offscreensurface.h	1970-01-01 00:00:00 +0000
 +++ src/platforms/mirserver/offscreensurface.h	2015-10-14 23:14:58 +0000
@@ -0,0 +1,43 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#ifndef OFFSCREENSURFACE_H
++#define OFFSCREENSURFACE_H
++
++#include <qpa/qplatformoffscreensurface.h>
++#include <QSurfaceFormat>
++#include <QSharedPointer>
++
++class MirServer;
++class QOpenGLFramebufferObject;
++
++class OffscreenSurface : public QPlatformOffscreenSurface
++{
++public:
++    OffscreenSurface(QOffscreenSurface *offscreenSurface);
++
++    QSurfaceFormat format() const override;
++    bool isValid() const override;
++
++    QOpenGLFramebufferObject* buffer() const;
++    void setBuffer(QOpenGLFramebufferObject *buffer);
++
++private:
++    QOpenGLFramebufferObject *m_buffer;
++    QSurfaceFormat m_format;
++};
++
++#endif // OFFSCREENSURFACE_H
 === modified file 'src/platforms/mirserver/qmirserver.cpp'
 --- src/platforms/mirserver/qmirserver.cpp	2015-05-19 15:36:17 +0000
 +++ src/platforms/mirserver/qmirserver.cpp	2015-10-14 23:14:58 +0000
@@ -23,7 +23,8 @@
  #include "mirserver.h"
  #include "qmirserver.h"
  #include "qmirserver_p.h"
--
++#include "screencontroller.h"
++#include "screen.h"
  QMirServer::QMirServer(const QStringList &arguments, QObject *parent)
      : QObject(parent)
@@ -40,7 +41,9 @@
+     }
      argv[argc] = '\0';
--    d->server = QSharedPointer<MirServer>(new MirServer(argc, const_cast<const char**>(argv)));
++    d->screenController = QSharedPointer<ScreenController>(new ScreenController());
++
++    d->server = QSharedPointer<MirServer>(new MirServer(argc, const_cast<const char**>(argv), d->screenController));
      d->serverThread = new MirServerThread(d->server);
@@ -63,6 +66,7 @@
          qCritical() << "ERROR: QMirServer - Mir failed to start";
          return false;
+     }
++    d->screenController->update();
      Q_EMIT started();
      return true;
@@ -93,3 +97,9 @@
      Q_D(const QMirServer);
      return d->server.toWeakRef();
+ }
++
++QWeakPointer<ScreenController> QMirServer::screenController() const
++{
++    Q_D(const QMirServer);
++    return d->screenController;
++}
 === modified file 'src/platforms/mirserver/qmirserver.h'
 --- src/platforms/mirserver/qmirserver.h	2015-05-18 20:39:09 +0000
 +++ src/platforms/mirserver/qmirserver.h	2015-10-14 23:14:58 +0000
@@ -23,6 +23,7 @@
  class QMirServerPrivate;
  class MirServer;
++class ScreenController;
  class QMirServer: public QObject
+ {
@@ -38,6 +39,8 @@
      QWeakPointer<MirServer> mirServer() const;
++    QWeakPointer<ScreenController> screenController() const;
++
  Q_SIGNALS:
      void started();
      void stopped();
 === modified file 'src/platforms/mirserver/qmirserver_p.h'
 --- src/platforms/mirserver/qmirserver_p.h	2015-05-18 18:30:33 +0000
 +++ src/platforms/mirserver/qmirserver_p.h	2015-10-14 23:14:58 +0000
@@ -27,6 +27,7 @@
  // local
  #include "mirserver.h"
++#include "screencontroller.h"
  class QMirServer;
  class MirServerThread;
@@ -34,6 +35,7 @@
  struct QMirServerPrivate
+ {
      QSharedPointer<MirServer> server;
++    QSharedPointer<ScreenController> screenController;
      MirServerThread *serverThread;
  };
 === modified file 'src/platforms/mirserver/qtcompositor.cpp'
 --- src/platforms/mirserver/qtcompositor.cpp	2015-08-11 12:08:32 +0000
 +++ src/platforms/mirserver/qtcompositor.cpp	2015-10-14 23:14:58 +0000
@@ -15,44 +15,19 @@
   */
  #include "qtcompositor.h"
--#include "displaywindow.h"
--
--#include <QGuiApplication>
--#include <QWindow>
--
--#include <QDebug>
--
--QtCompositor::QtCompositor()
--{
--
--}
--
++#include "logging.h"
++
++// Lives in a Mir thread
  void QtCompositor::start()
+ {
--    // (Re)Start Qt's render thread by setting all its windows to exposed
--    setAllWindowsExposed(true);
++    qCDebug(QTMIR_SCREENS) << "QtCompositor::start";
++
++    Q_EMIT starting(); // blocks
+ }
  void QtCompositor::stop()
+ {
--    // Stop Qt's render threads by setting all its windows it obscured
--    setAllWindowsExposed(false);
--}
--
--void QtCompositor::setAllWindowsExposed(const bool exposed)
--{
--    qDebug() << "QtCompositor::setAllWindowsExposed" << exposed;
--    QList<QWindow *> windowList = QGuiApplication::allWindows();
--
--    // manipulate Qt object's indirectly via posted events as we're not in Qt's GUI thread
--    auto iterator = windowList.constBegin();
--    while (iterator != windowList.constEnd()) {
--        QWindow *window = *iterator;
--        DisplayWindow *displayWindow = static_cast<DisplayWindow*>(window->handle());
--        if (displayWindow) {
--            QCoreApplication::postEvent(displayWindow,
--                                        new QEvent( (exposed) ? QEvent::Show : QEvent::Hide));
--        }
--        iterator++;
--    }
++    qCDebug(QTMIR_SCREENS) << "QtCompositor::stop";
++
++    Q_EMIT stopping(); // blocks
+ }
 === modified file 'src/platforms/mirserver/qtcompositor.h'
 --- src/platforms/mirserver/qtcompositor.h	2015-08-11 12:08:32 +0000
 +++ src/platforms/mirserver/qtcompositor.h	2015-10-14 23:14:58 +0000
@@ -17,18 +17,26 @@
  #ifndef QTCOMPOSITOR_H
  #define QTCOMPOSITOR_H
--#include "mir/compositor/compositor.h"
--
--class QtCompositor : public mir::compositor::Compositor
++#include <mir/compositor/compositor.h>
++
++// Qt
++#include <QObject>
++
++class QtCompositor : public QObject, public mir::compositor::Compositor
+ {
++    Q_OBJECT
  public:
--    QtCompositor();
++    QtCompositor() = default;
++    virtual ~QtCompositor() noexcept = default;
      void start();
      void stop();
++Q_SIGNALS:
++    void starting();
++    void stopping();
++
  private:
--    void setAllWindowsExposed(const bool exposed);
  };
  #endif // QTCOMPOSITOR_H
 === modified file 'src/platforms/mirserver/qteventfeeder.cpp'
 --- src/platforms/mirserver/qteventfeeder.cpp	2015-10-14 23:14:58 +0000
 +++ src/platforms/mirserver/qteventfeeder.cpp	2015-10-14 23:14:58 +0000
@@ -17,7 +17,8 @@
  #include "qteventfeeder.h"
  #include "cursor.h"
  #include "logging.h"
--#include "screen.h"
++#include "screen.h" // NEEDED?
++#include "screencontroller.h"
  #include <qpa/qplatforminputcontext.h>
  #include <qpa/qplatformintegration.h>
@@ -367,7 +368,8 @@
  namespace {
--class QtWindowSystem : public QtEventFeeder::QtWindowSystemInterface {
++class QtWindowSystem : public QtEventFeeder::QtWindowSystemInterface
++{
  public:
      QtWindowSystem()
+     {
@@ -376,18 +378,19 @@
          qRegisterMetaType<Qt::MouseButtons>("Qt::MouseButtons");
+     }
--    bool hasTargetWindow() override
--    {
--        if (mTopLevelWindow.isNull() && !QGuiApplication::topLevelWindows().isEmpty()) {
--            mTopLevelWindow = QGuiApplication::topLevelWindows().first();
--        }
--        return !mTopLevelWindow.isNull();
--    }
--
--    QRect targetWindowGeometry() override
--    {
--        Q_ASSERT(!mTopLevelWindow.isNull());
--        return mTopLevelWindow->geometry();
++    void setScreenController(const QSharedPointer<ScreenController> &sc) override
++    {
++        m_screenController = sc;
++    }
++
++    virtual QWindow* focusedWindow() override
++    {
++        return QGuiApplication::focusWindow();
++    }
++
++    QWindow* getWindowForTouchPoint(const QPoint &point) override //FIXME: not efficient, not updating focused window
++    {
++        return m_screenController->getWindowForPoint(point);
+     }
      void registerTouchDevice(QTouchDevice *device) override
@@ -395,47 +398,55 @@
          QWindowSystemInterface::registerTouchDevice(device);
+     }
--    void handleExtendedKeyEvent(ulong timestamp, QEvent::Type type, int key,
++    void handleExtendedKeyEvent(QWindow *window, ulong timestamp, QEvent::Type type, int key,
                  Qt::KeyboardModifiers modifiers,
                  quint32 nativeScanCode, quint32 nativeVirtualKey,
                  quint32 nativeModifiers,
                  const QString& text, bool autorep, ushort count) override
+     {
--        Q_ASSERT(!mTopLevelWindow.isNull());
--        QWindowSystemInterface::handleExtendedKeyEvent(mTopLevelWindow.data(), timestamp, type, key, modifiers,
++        QWindowSystemInterface::handleExtendedKeyEvent(window, timestamp, type, key, modifiers,
                  nativeScanCode, nativeVirtualKey, nativeModifiers, text, autorep, count);
+     }
--    void handleTouchEvent(ulong timestamp, QTouchDevice *device,
++    void handleTouchEvent(QWindow *window, ulong timestamp, QTouchDevice *device,
              const QList<struct QWindowSystemInterface::TouchPoint> &points, Qt::KeyboardModifiers mods) override
+     {
--        Q_ASSERT(!mTopLevelWindow.isNull());
--        QWindowSystemInterface::handleTouchEvent(mTopLevelWindow.data(), timestamp, device, points, mods);
--    }
++        QWindowSystemInterface::handleTouchEvent(window, timestamp, device, points, mods);
++    }
      void handleMouseEvent(ulong timestamp, QPointF movement, Qt::MouseButtons buttons, Qt::KeyboardModifiers modifiers) override
+     {
--        Q_ASSERT(!mTopLevelWindow.isNull());
--        auto platformCursor = static_cast<qtmir::Cursor*>(mTopLevelWindow->screen()->handle()->cursor());
--        platformCursor->handleMouseEvent(timestamp, movement, buttons, modifiers);
++        // Send to the first screen that handles the mouse event
++        // TODO: Have a mechanism to tell which screen currently has the logical mouse pointer
++        //       (because they all might have their own separate graphical mouse pointer item)
++        //       This will probably come once we implement the feature of having the mouse pointer
++        //       crossing adjacent screens.
++
++        QList<Screen*> screens = m_screenController->screens();
++        bool eventHandled = false;
++        int i = 0;
++        while (i < screens.count() && !eventHandled) {
++            auto platformCursor = static_cast<qtmir::Cursor*>(screens[i]->cursor());
++            eventHandled = platformCursor->handleMouseEvent(timestamp, movement, buttons, modifiers);
++            ++i;
++        }
+     }
--
  private:
--    QPointer<QWindow> mTopLevelWindow;
++    QSharedPointer<ScreenController> m_screenController;
  };
  } // anonymous namespace
--
--QtEventFeeder::QtEventFeeder(QtEventFeeder::QtWindowSystemInterface *windowSystem)
--{
--    if (windowSystem) {
--        mQtWindowSystem = windowSystem;
--    } else {
--        mQtWindowSystem = new QtWindowSystem;
--    }
--
++QtEventFeeder::QtEventFeeder(const QSharedPointer<ScreenController> &screenController)
++    : QtEventFeeder(screenController, new QtWindowSystem)
++{
++}
++
++QtEventFeeder::QtEventFeeder(const QSharedPointer<ScreenController> &screenController,
++                             QtEventFeeder::QtWindowSystemInterface *windowSystem)
++    : mQtWindowSystem(windowSystem)
++{
      // Initialize touch device. Hardcoded just like in qtubuntu
      // TODO: Create them from info gathered from Mir and store things like device id and source
      //       in a QTouchDevice-derived class created by us. So that we can properly assemble back
@@ -445,6 +456,7 @@
      mTouchDevice->setCapabilities(
              QTouchDevice::Position | QTouchDevice::Area | QTouchDevice::Pressure |
              QTouchDevice::NormalizedPosition);
++    mQtWindowSystem->setScreenController(screenController);
      mQtWindowSystem->registerTouchDevice(mTouchDevice);
+ }
@@ -458,6 +470,7 @@
      auto type = mir_event_get_type(&event);
      if (type != mir_event_type_input)
          return false;
++
      auto iev = mir_event_get_input_event(&event);
      switch (mir_input_event_get_type(iev)) {
@@ -517,9 +530,6 @@
  void QtEventFeeder::dispatchPointer(MirInputEvent const* ev)
+ {
--    if (!mQtWindowSystem->hasTargetWindow())
--        return;
--
      auto timestamp = mir_input_event_get_event_time(ev) / 1000000;
      auto pev = mir_input_event_get_pointer_event(ev);
@@ -527,6 +537,7 @@
      auto modifiers = getQtModifiersFromMir(mir_pointer_event_modifiers(pev));
      auto buttons = getQtMouseButtonsfromMirPointerEvent(pev);
++
      auto movement = QPointF(mir_pointer_event_axis_value(pev, mir_pointer_axis_relative_x),
                              mir_pointer_event_axis_value(pev, mir_pointer_axis_relative_y));
@@ -535,9 +546,6 @@
  void QtEventFeeder::dispatchKey(MirInputEvent const* event)
+ {
--    if (!mQtWindowSystem->hasTargetWindow())
--        return;
--
      ulong timestamp = mir_input_event_get_event_time(event) / 1000000;
      auto kev = mir_input_event_get_keyboard_event(event);
@@ -584,7 +592,8 @@
+         }
+     }
--    mQtWindowSystem->handleExtendedKeyEvent(timestamp, keyType, keyCode, modifiers,
++    mQtWindowSystem->handleExtendedKeyEvent(mQtWindowSystem->focusedWindow(),
++        timestamp, keyType, keyCode, modifiers,
          mir_keyboard_event_scan_code(kev),
          mir_keyboard_event_key_code(kev),
          mir_keyboard_event_modifiers(kev), text, is_auto_rep);
@@ -592,59 +601,69 @@
  void QtEventFeeder::dispatchTouch(MirInputEvent const* event)
+ {
--    if (!mQtWindowSystem->hasTargetWindow())
--        return;
--
      auto tev = mir_input_event_get_touch_event(event);
      qCDebug(QTMIR_MIR_INPUT) << "Received" << qPrintable(mirTouchEventToString(tev));
      // FIXME(loicm) Max pressure is device specific. That one is for the Samsung Galaxy Nexus. That
      //     needs to be fixed as soon as the compat input lib adds query support.
      const float kMaxPressure = 1.28;
--    const QRect kWindowGeometry = mQtWindowSystem->targetWindowGeometry();
++    const int kPointerCount = mir_touch_event_point_count(tev);
      QList<QWindowSystemInterface::TouchPoint> touchPoints;
--
--    // TODO: Is it worth setting the Qt::TouchPointStationary ones? Currently they are left
--    //       as Qt::TouchPointMoved
--    const int kPointerCount = mir_touch_event_point_count(tev);
--    for (int i = 0; i < kPointerCount; ++i) {
--        QWindowSystemInterface::TouchPoint touchPoint;
--
--        const float kX = mir_touch_event_axis_value(tev, i, mir_touch_axis_x);
--        const float kY = mir_touch_event_axis_value(tev, i, mir_touch_axis_y);
--        const float kW = mir_touch_event_axis_value(tev, i, mir_touch_axis_touch_major);
--        const float kH = mir_touch_event_axis_value(tev, i, mir_touch_axis_touch_minor);
--        const float kP = mir_touch_event_axis_value(tev, i, mir_touch_axis_pressure);
--        touchPoint.id = mir_touch_event_id(tev, i);
--
--        touchPoint.normalPosition = QPointF(kX / kWindowGeometry.width(), kY / kWindowGeometry.height());
--        touchPoint.area = QRectF(kX - (kW / 2.0), kY - (kH / 2.0), kW, kH);
--        touchPoint.pressure = kP / kMaxPressure;
--        switch (mir_touch_event_action(tev, i))
--        {
--        case mir_touch_action_up:
--            touchPoint.state = Qt::TouchPointReleased;
--            break;
--        case mir_touch_action_down:
--            touchPoint.state = Qt::TouchPointPressed;
--            break;
--        case mir_touch_action_change:
--            touchPoint.state = Qt::TouchPointMoved;
--            break;
--        default:
--            break;
--        }
--
--        touchPoints.append(touchPoint);
++    QWindow *window = nullptr;
++
++    if (kPointerCount > 0) {
++        window = mQtWindowSystem->getWindowForTouchPoint(
++                    QPoint(mir_touch_event_axis_value(tev, 0, mir_touch_axis_x),
++                           mir_touch_event_axis_value(tev, 0, mir_touch_axis_y)));
++
++        if (!window) {
++            qCDebug(QTMIR_MIR_INPUT) << "REJECTING INPUT EVENT, no matching window";
++            return;
++        }
++
++        const QRect kWindowGeometry = window->geometry();
++
++        // TODO: Is it worth setting the Qt::TouchPointStationary ones? Currently they are left
++        //       as Qt::TouchPointMoved
++        for (int i = 0; i < kPointerCount; ++i) {
++            QWindowSystemInterface::TouchPoint touchPoint;
++
++            const float kX = mir_touch_event_axis_value(tev, i, mir_touch_axis_x);
++            const float kY = mir_touch_event_axis_value(tev, i, mir_touch_axis_y);
++            const float kW = mir_touch_event_axis_value(tev, i, mir_touch_axis_touch_major);
++            const float kH = mir_touch_event_axis_value(tev, i, mir_touch_axis_touch_minor);
++            const float kP = mir_touch_event_axis_value(tev, i, mir_touch_axis_pressure);
++            touchPoint.id = mir_touch_event_id(tev, i);
++
++            touchPoint.normalPosition = QPointF(kX / kWindowGeometry.width(), kY / kWindowGeometry.height());
++            touchPoint.area = QRectF(kX - (kW / 2.0), kY - (kH / 2.0), kW, kH);
++            touchPoint.pressure = kP / kMaxPressure;
++            switch (mir_touch_event_action(tev, i))
++            {
++            case mir_touch_action_up:
++                touchPoint.state = Qt::TouchPointReleased;
++                break;
++            case mir_touch_action_down:
++                touchPoint.state = Qt::TouchPointPressed;
++                break;
++            case mir_touch_action_change:
++                touchPoint.state = Qt::TouchPointMoved;
++                break;
++            default:
++                break;
++            }
++
++            touchPoints.append(touchPoint);
++        }
+     }
      // Qt needs a happy, sane stream of touch events. So let's make sure we're not forwarding
      // any insanity.
--    validateTouches(mir_input_event_get_event_time(event) / 1000000, touchPoints);
++    validateTouches(window, mir_input_event_get_event_time(event) / 1000000, touchPoints);
      // Touch event propagation.
      qCDebug(QTMIR_MIR_INPUT) << "Sending to Qt" << qPrintable(touchesToString(touchPoints));
--    mQtWindowSystem->handleTouchEvent(
++    mQtWindowSystem->handleTouchEvent(window,
          //scales down the nsec_t (int64) to fit a ulong, precision lost but time difference suitable
          mir_input_event_get_event_time(event) / 1000000,
          mTouchDevice,
@@ -661,7 +680,7 @@
      // not used
+ }
--void QtEventFeeder::validateTouches(ulong timestamp,
++void QtEventFeeder::validateTouches(QWindow *window, ulong timestamp,
          QList<QWindowSystemInterface::TouchPoint> &touchPoints)
+ {
      QSet<int> updatedTouches;
@@ -685,7 +704,7 @@
          if (!updatedTouches.contains(it.key())) {
              qCWarning(QTMIR_MIR_INPUT)
                  << "There's a touch (id =" << it.key() << ") missing. Releasing it.";
--            sendActiveTouchRelease(timestamp, it.key());
++            sendActiveTouchRelease(window, timestamp, it.key());
              it = mActiveTouches.erase(it);
          } else {
              ++it;
@@ -703,7 +722,7 @@
+     }
+ }
--void QtEventFeeder::sendActiveTouchRelease(ulong timestamp, int id)
++void QtEventFeeder::sendActiveTouchRelease(QWindow *window, ulong timestamp, int id)
+ {
      QList<QWindowSystemInterface::TouchPoint> touchPoints = mActiveTouches.values();
@@ -717,7 +736,7 @@
+     }
      qCDebug(QTMIR_MIR_INPUT) << "Sending to Qt" << qPrintable(touchesToString(touchPoints));
--    mQtWindowSystem->handleTouchEvent(timestamp, mTouchDevice, touchPoints);
++    mQtWindowSystem->handleTouchEvent(window, timestamp, mTouchDevice, touchPoints);
+ }
  bool QtEventFeeder::validateTouch(QWindowSystemInterface::TouchPoint &touchPoint)
 === modified file 'src/platforms/mirserver/qteventfeeder.h'
 --- src/platforms/mirserver/qteventfeeder.h	2015-10-14 23:14:58 +0000
 +++ src/platforms/mirserver/qteventfeeder.h	2015-10-14 23:14:58 +0000
@@ -23,6 +23,7 @@
  #include <qpa/qwindowsysteminterface.h>
  class QTouchDevice;
++class ScreenController;
  /*
    Fills Qt's event loop with input events from Mir
@@ -33,27 +34,29 @@
      // Interface between QtEventFeeder and the actual QWindowSystemInterface functions
      // and other related Qt methods and objects to enable replacing them with mocks in
      // pure unit tests.
--    // TODO - Make it work with multimonitor scenarios
      class QtWindowSystemInterface {
          public:
          virtual ~QtWindowSystemInterface() {}
--        virtual bool hasTargetWindow() = 0;
--        virtual QRect targetWindowGeometry() = 0;
++        virtual void setScreenController(const QSharedPointer<ScreenController> &sc) = 0;
++        virtual QWindow* getWindowForTouchPoint(const QPoint &point) = 0;
++        virtual QWindow* focusedWindow() = 0;
          virtual void registerTouchDevice(QTouchDevice *device) = 0;
--        virtual void handleExtendedKeyEvent(ulong timestamp, QEvent::Type type, int key,
++        virtual void handleExtendedKeyEvent(QWindow *window, ulong timestamp, QEvent::Type type, int key,
                  Qt::KeyboardModifiers modifiers,
                  quint32 nativeScanCode, quint32 nativeVirtualKey,
                  quint32 nativeModifiers,
                  const QString& text = QString(), bool autorep = false,
                  ushort count = 1) = 0;
--        virtual void handleTouchEvent(ulong timestamp, QTouchDevice *device,
++        virtual void handleTouchEvent(QWindow *window, ulong timestamp, QTouchDevice *device,
                  const QList<struct QWindowSystemInterface::TouchPoint> &points,
                  Qt::KeyboardModifiers mods = Qt::NoModifier) = 0;
          virtual void handleMouseEvent(ulong timestamp, QPointF movement, Qt::MouseButtons buttons,
                                        Qt::KeyboardModifiers modifiers) = 0;
      };
--    QtEventFeeder(QtWindowSystemInterface *windowSystem = nullptr);
++    QtEventFeeder(const QSharedPointer<ScreenController> &screenController);
++    QtEventFeeder(const QSharedPointer<ScreenController> &screenController,
++                  QtWindowSystemInterface *windowSystem);
      virtual ~QtEventFeeder();
      static const int MirEventActionMask;
@@ -68,9 +71,9 @@
      void dispatchKey(MirInputEvent const* event);
      void dispatchTouch(MirInputEvent const* event);
      void dispatchPointer(MirInputEvent const* event);
--    void validateTouches(ulong timestamp, QList<QWindowSystemInterface::TouchPoint> &touchPoints);
++    void validateTouches(QWindow *window, ulong timestamp, QList<QWindowSystemInterface::TouchPoint> &touchPoints);
      bool validateTouch(QWindowSystemInterface::TouchPoint &touchPoint);
--    void sendActiveTouchRelease(ulong timestamp, int id);
++    void sendActiveTouchRelease(QWindow *window, ulong timestamp, int id);
      QString touchesToString(const QList<struct QWindowSystemInterface::TouchPoint> &points);
 === modified file 'src/platforms/mirserver/screen.cpp'
 --- src/platforms/mirserver/screen.cpp	2015-10-14 23:14:58 +0000
 +++ src/platforms/mirserver/screen.cpp	2015-10-14 23:14:58 +0000
@@ -20,12 +20,14 @@
  // Mir
  #include "mir/geometry/size.h"
++#include "mir/graphics/buffer.h"
++#include "mir/graphics/display_buffer.h"
++#include "mir/graphics/display.h"
++#include <mir/renderer/gl/render_target.h>
  // Qt
  #include <QCoreApplication>
  #include <qpa/qwindowsysteminterface.h>
--#include <QtSensors/QOrientationSensor>
--#include <QtSensors/QOrientationReading>
  #include <QThread>
  // Qt sensors
@@ -42,6 +44,17 @@
      char *c = (char*)&i;
      return *c == 1;
+ }
++static mir::renderer::gl::RenderTarget *as_render_target(
++    mir::graphics::DisplayBuffer *displayBuffer)
++{
++    auto const render_target =
++        dynamic_cast<mir::renderer::gl::RenderTarget*>(
++            displayBuffer->native_display_buffer());
++    if (!render_target)
++        throw std::logic_error("DisplayBuffer does not support GL rendering");
++
++    return render_target;
++}
  enum QImage::Format qImageFormatFromMirPixelFormat(MirPixelFormat mirPixelFormat) {
      switch (mirPixelFormat) {
@@ -102,12 +115,15 @@
  bool Screen::skipDBusRegistration = false;
--Screen::Screen(mir::graphics::DisplayConfigurationOutput const &screen)
++Screen::Screen(const mir::graphics::DisplayConfigurationOutput &screen)
      : QObject(nullptr)
++    , m_renderTarget(nullptr)
++    , m_displayGroup(nullptr)
      , m_orientationSensor(new QOrientationSensor(this))
++    , m_screenWindow(nullptr)
      , m_unityScreen(nullptr)
+ {
--    readMirDisplayConfiguration(screen);
++    setMirDisplayConfiguration(screen);
      // Set the default orientation based on the initial screen dimmensions.
      m_nativeOrientation = (m_geometry.width() >= m_geometry.height())
@@ -139,6 +155,14 @@
+     }
+ }
++Screen::~Screen()
++{
++    //if a ScreenWindow associated with this screen, kill it
++    if (m_screenWindow) {
++        m_screenWindow->window()->destroy(); // ends up destroying m_ScreenWindow
++    }
++}
++
  bool Screen::orientationSensorEnabled()
+ {
      return m_orientationSensor->isActive();
@@ -150,8 +174,15 @@
      toggleSensors(status);
+ }
--void Screen::readMirDisplayConfiguration(mir::graphics::DisplayConfigurationOutput const &screen)
++void Screen::setMirDisplayConfiguration(const mir::graphics::DisplayConfigurationOutput &screen)
+ {
++    // Note: DisplayConfigurationOutput will be destroyed after this function returns
++
++    // Output data - each output has a unique id and corresponding type. Can be multiple cards.
++    m_outputId = screen.id;
++    m_cardId = screen.card_id;
++    m_type = screen.type;
++
      // Physical screen size
      m_physicalSize.setWidth(screen.physical_size_mm.width.as_float());
      m_physicalSize.setHeight(screen.physical_size_mm.height.as_float());
@@ -162,12 +193,34 @@
      // Pixel depth
      m_depth = 8 * MIR_BYTES_PER_PIXEL(screen.current_format);
--    // Mode = Resolution & refresh rate
++    // Power mode
++    m_powerMode = screen.power_mode;
++
++    QRect oldGeometry = m_geometry;
++    // Position of screen in virtual desktop coordinate space
++    m_geometry.setTop(screen.top_left.y.as_int());
++    m_geometry.setLeft(screen.top_left.x.as_int());
++
++    // Mode = current resolution & refresh rate
      mir::graphics::DisplayConfigurationMode mode = screen.modes.at(screen.current_mode_index);
      m_geometry.setWidth(mode.size.width.as_int());
      m_geometry.setHeight(mode.size.height.as_int());
--    m_refreshRate = mode.vrefresh_hz;
++    // DPI - unnecessary to calculate, default implementation in QPlatformScreen is sufficient
++
++    // Check for Screen geometry change
++    if (m_geometry != oldGeometry) {
++        QWindowSystemInterface::handleScreenGeometryChange(this->screen(), m_geometry, m_geometry);
++        if (m_screenWindow) { // resize corresponding window immediately
++            m_screenWindow->setGeometry(m_geometry);
++        }
++    }
++
++    // Refresh rate
++    if (m_refreshRate != mode.vrefresh_hz) {
++        m_refreshRate = mode.vrefresh_hz;
++        QWindowSystemInterface::handleScreenRefreshRateChange(this->screen(), mode.vrefresh_hz);
++    }
+ }
  void Screen::toggleSensors(const bool enable) const
@@ -232,3 +285,52 @@
      const QPlatformCursor *platformCursor = &m_cursor;
      return const_cast<QPlatformCursor *>(platformCursor);
+ }
++
++ScreenWindow *Screen::window() const
++{
++    return m_screenWindow;
++}
++
++void Screen::setWindow(ScreenWindow *window)
++{
++    if (window && m_screenWindow) {
++        qCDebug(QTMIR_SENSOR_MESSAGES) << "Screen::setWindow - overwriting existing ScreenWindow";
++    }
++    m_screenWindow = window;
++}
++
++void Screen::setMirDisplayBuffer(mir::graphics::DisplayBuffer *buffer, mir::graphics::DisplaySyncGroup *group)
++{
++    qCDebug(QTMIR_SCREENS) << "Screen::setMirDisplayBuffer" << buffer << group;
++    // This operation should only be performed while rendering is stopped
++    m_renderTarget = as_render_target(buffer);
++    m_displayGroup = group;
++}
++
++void Screen::swapBuffers()
++{
++    m_renderTarget->swap_buffers();
++
++    /* FIXME this exposes a QtMir architecture problem, as Screen is supposed to wrap a mg::DisplayBuffer.
++     * We use Qt's multithreaded renderer, where each Screen is rendered to relatively independently, and
++     * post() called also individually.
++     *
++     * But if this is a native server on Android, in the multimonitor case a DisplaySyncGroup can contain
++     * 2+ DisplayBuffers, one post() call will submit all mg::DisplayBuffers in the group for flipping.
++     * This will cause just one Screen to be updated, blocking the swap call for the other Screens, which
++     * will slow rendering dramatically.
++     *
++     * Integrating the Qt Scenegraph renderer as a Mir renderer should solve this issue.
++     */
++    m_displayGroup->post();
++}
++
++void Screen::makeCurrent()
++{
++    m_renderTarget->make_current();
++}
++
++void Screen::doneCurrent()
++{
++    m_renderTarget->release_current();
++}
 === modified file 'src/platforms/mirserver/screen.h'
 --- src/platforms/mirserver/screen.h	2015-10-14 23:14:58 +0000
 +++ src/platforms/mirserver/screen.h	2015-10-14 23:14:58 +0000
@@ -17,22 +17,31 @@
  #ifndef SCREEN_H
  #define SCREEN_H
++// Qt
  #include <QObject>
  #include <QTimer>
  #include <QtDBus/QDBusInterface>
  #include <qpa/qplatformscreen.h>
++// Mir
  #include <mir/graphics/display_configuration.h>
++// local
  #include "cursor.h"
++#include "screenwindow.h"
  class QOrientationSensor;
++namespace mir {
++    namespace graphics { class DisplayBuffer; class DisplaySyncGroup; }
++    namespace renderer { namespace gl { class RenderTarget; }}
++}
  class Screen : public QObject, public QPlatformScreen
+ {
      Q_OBJECT
  public:
--    Screen(mir::graphics::DisplayConfigurationOutput const&);
++    Screen(const mir::graphics::DisplayConfigurationOutput &);
++    ~Screen();
      // QPlatformScreen methods.
      QRect geometry() const override { return m_geometry; }
@@ -45,6 +54,9 @@
      QPlatformCursor *cursor() const override;
      void toggleSensors(const bool enable) const;
++    mir::graphics::DisplayConfigurationOutputType outputType() const { return m_type; }
++
++    ScreenWindow* window() const;
      // QObject methods.
      void customEvent(QEvent* event) override;
@@ -57,22 +69,40 @@
     void onDisplayPowerStateChanged(int, int);
     void onOrientationReadingChanged();
++protected:
++    void setWindow(ScreenWindow *window);
++
++    void setMirDisplayConfiguration(const mir::graphics::DisplayConfigurationOutput &);
++    void setMirDisplayBuffer(mir::graphics::DisplayBuffer *, mir::graphics::DisplaySyncGroup *);
++    void swapBuffers();
++    void makeCurrent();
++    void doneCurrent();
++
  private:
--    void readMirDisplayConfiguration(mir::graphics::DisplayConfigurationOutput const&);
--
      QRect m_geometry;
      int m_depth;
      QImage::Format m_format;
      QSizeF m_physicalSize;
      qreal m_refreshRate;
++    mir::renderer::gl::RenderTarget *m_renderTarget;
++    mir::graphics::DisplaySyncGroup *m_displayGroup;
++    mir::graphics::DisplayConfigurationOutputId m_outputId;
++    mir::graphics::DisplayConfigurationCardId m_cardId;
++    mir::graphics::DisplayConfigurationOutputType m_type;
++    MirPowerMode m_powerMode;
++
      Qt::ScreenOrientation m_nativeOrientation;
      Qt::ScreenOrientation m_currentOrientation;
      QOrientationSensor *m_orientationSensor;
++    ScreenWindow *m_screenWindow;
      QDBusInterface *m_unityScreen;
      qtmir::Cursor m_cursor;
++
++    friend class ScreenController;
++    friend class ScreenWindow;
  };
  #endif // SCREEN_H
 === added file 'src/platforms/mirserver/screencontroller.cpp'
 --- src/platforms/mirserver/screencontroller.cpp	1970-01-01 00:00:00 +0000
 +++ src/platforms/mirserver/screencontroller.cpp	2015-10-14 23:14:58 +0000
@@ -0,0 +1,258 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#include "screencontroller.h"
++
++#include "screenwindow.h"
++#include "qtcompositor.h"
++#include "logging.h"
++#include "mirserverintegration.h"
++#include "screen.h"
++
++// Mir
++#include <mir/graphics/display.h>
++#include <mir/graphics/display_buffer.h>
++
++// Qt
++#include <QScreen>
++#include <QQuickWindow>
++#include <qpa/qwindowsysteminterface.h>
++
++// std
++#include <memory>
++
++Q_LOGGING_CATEGORY(QTMIR_SCREENS, "qtmir.screens")
++
++namespace mg = mir::graphics;
++
++
++ScreenController::ScreenController(QObject *parent)
++    : QObject(parent)
++    , m_compositing(false)
++{
++    qCDebug(QTMIR_SCREENS) << "ScreenController::ScreenController";
++}
++
++// init only after MirServer has initialized - runs on MirServerThread!!!
++void ScreenController::init(const std::shared_ptr<mir::graphics::Display> &display,
++                            const std::shared_ptr<mir::compositor::Compositor> &compositor)
++{
++    m_display = display;
++    m_compositor = compositor;
++
++    // Use a Blocking Queued Connection to enforce synchronization of Qt GUI thread with Mir thread(s)
++    // on compositor shutdown. Compositor startup can be lazy.
++    // Queued connections work because the thread affinity of this class is with the Qt GUI thread.
++    auto qtCompositor = static_cast<QtCompositor *>(compositor.get());
++    connect(qtCompositor, &QtCompositor::starting,
++            this, &ScreenController::onCompositorStarting);
++    connect(qtCompositor, &QtCompositor::stopping,
++            this, &ScreenController::onCompositorStopping, Qt::BlockingQueuedConnection);
++}
++
++// terminate before shutting down the Mir server, or else liable to deadlock with the blocking connection above
++// Runs on MirServerThread!!!
++void ScreenController::terminate()
++{
++    auto qtCompositor = static_cast<QtCompositor *>(m_compositor.get());
++    qtCompositor->disconnect();
++}
++
++void ScreenController::onCompositorStarting()
++{
++    qCDebug(QTMIR_SCREENS) << "ScreenController::onCompositorStarting";
++    m_compositing = true;
++
++    update();
++
++    // (Re)Start Qt's render thread by setting all windows with a corresponding screen to exposed.
++    for (auto screen : m_screenList) {
++        auto window = static_cast<ScreenWindow *>(screen->window());
++        if (window && window->window()) {
++            window->setExposed(true);
++        }
++    }
++}
++
++void ScreenController::onCompositorStopping()
++{
++    qCDebug(QTMIR_SCREENS) << "ScreenController::onCompositorStopping";
++    m_compositing = false;
++
++    // Stop Qt's render threads by setting all its windows it obscured. Must
++    // block until all windows have their GL contexts released.
++    for (auto screen : m_screenList) {
++        auto window = static_cast<ScreenWindow *>(screen->window());
++        if (window && window->window()) {
++            window->setExposed(false);
++        }
++    }
++
++    update();
++}
++
++void ScreenController::update()
++{
++    qCDebug(QTMIR_SCREENS) << "ScreenController::update";
++    auto display = m_display.lock();
++    if (!display)
++        return;
++    auto displayConfig = display->configuration();
++
++    // Mir only tells us something changed, it is up to us to figure out what.
++    QList<Screen*> newScreenList;
++    QList<Screen*> oldScreenList = m_screenList;
++    m_screenList.clear();
++
++    displayConfig->for_each_output(
++        [this, &oldScreenList, &newScreenList](const mg::DisplayConfigurationOutput &output) {
++            if (output.used && output.connected) {
++                Screen *screen = findScreenWithId(oldScreenList, output.id);
++                if (screen) { // we've already set up this display before, refresh its internals
++                    screen->setMirDisplayConfiguration(output);
++                    oldScreenList.removeAll(screen);
++                } else {
++                    // new display, so create Screen for it
++                    screen = this->createScreen(output);
++                    newScreenList.append(screen);
++                    qCDebug(QTMIR_SCREENS) << "Added Screen with id" << output.id.as_value()
++                                           << "and geometry" << screen->geometry();
++                }
++                m_screenList.append(screen);
++            }
++        }
++    );
++
++    // Delete any old & unused Screens
++    for (auto screen: oldScreenList) {
++        qCDebug(QTMIR_SCREENS) << "Removed Screen with id" << screen->m_outputId.as_value()
++                               << "and geometry" << screen->geometry();
++        // The screen is automatically removed from Qt's internal list by the QPlatformScreen destructor.
++        auto window = static_cast<ScreenWindow *>(screen->window());
++        if (window && window->window() && window->isExposed()) {
++            window->window()->hide();
++        }
++        delete screen;
++    }
++
++    // Match up the new Mir DisplayBuffers with each Screen
++    display->for_each_display_sync_group([&](mg::DisplaySyncGroup &group) {
++        group.for_each_display_buffer([&](mg::DisplayBuffer &buffer) {
++            // only way to match Screen to a DisplayBuffer is by matching the geometry
++            QRect dbGeom(buffer.view_area().top_left.x.as_int(),
++                         buffer.view_area().top_left.y.as_int(),
++                         buffer.view_area().size.width.as_int(),
++                         buffer.view_area().size.height.as_int());
++
++            for (auto screen : m_screenList) {
++                if (dbGeom == screen->geometry()) {
++                    screen->setMirDisplayBuffer(&buffer, &group);
++                    break;
++                }
++            }
++        });
++    });
++
++    qCDebug(QTMIR_SCREENS) << "=======================================";
++    for (auto screen: m_screenList) {
++        qCDebug(QTMIR_SCREENS) << screen << "- id:" << screen->m_outputId.as_value()
++                               << "geometry:" << screen->geometry()
++                               << "window:" << screen->window()
++                               << "type" << static_cast<int>(screen->outputType());
++    }
++    qCDebug(QTMIR_SCREENS) << "=======================================";
++
++    for (auto screen : newScreenList) {
++        Q_EMIT screenAdded(screen);
++    }
++}
++
++Screen* ScreenController::createScreen(const mir::graphics::DisplayConfigurationOutput &output) const
++{
++    return new Screen(output);
++}
++
++Screen* ScreenController::getUnusedScreen()
++{
++    if (m_screenList.empty()) {
++        return nullptr;
++    } else if (m_screenList.size() == 1) {
++        return m_screenList.at(0);
++    }
++
++    // FIXME: Until we have better way of identifying screens, prioritize outputs based on their output type.
++    // Note the priorities defined here are nothing more than guesses. It tries to select internal displays first,
++    // then digital outputs, and finally analogue.
++    QMap <int, Screen*> priorityList;
++    auto prioritize = [](const mg::DisplayConfigurationOutputType &type) {
++        using out = mg::DisplayConfigurationOutputType;
++        switch(type) {
++        case out::lvds:
++        case out::edp:
++            return 0;
++        case out::displayport:
++        case out::hdmia:
++        case out::hdmib:
++            return 1;
++        case out::dvii:
++        case out::dvid:
++        case out::dvia:
++            return 2;
++        case out::vga:
++            return 3;
++        case out::ninepindin:
++            return 4;
++        case out::component:
++        case out::composite:
++        case out::svideo:
++            return 5;
++        case out::tv:
++            return 6;
++        case out::unknown:
++        default:
++            return 9;
++        }
++    };
++
++    for (auto screen : m_screenList) {
++        if (!screen->window()) {
++            priorityList.insert(prioritize(screen->outputType()), screen);
++        }
++    }
++
++    qCDebug(QTMIR_SCREENS) << "Prioritized list of available outputs:" << priorityList;
++    return priorityList.first(); // Map sorted by key, so first is the key with highest priority.
++}
++
++Screen* ScreenController::findScreenWithId(const QList<Screen *> &list, const mg::DisplayConfigurationOutputId id)
++{
++    for (Screen *screen : list) {
++        if (screen->m_outputId == id) {
++            return screen;
++        }
++    }
++    return nullptr;
++}
++
++QWindow* ScreenController::getWindowForPoint(const QPoint &point) //FIXME - not thread safe & not efficient
++{
++    for (Screen *screen : m_screenList) {
++        if (screen->window() && screen->geometry().contains(point)) {
++            return screen->window()->window();
++        }
++    }
++    return nullptr;
++}
 === added file 'src/platforms/mirserver/screencontroller.h'
 --- src/platforms/mirserver/screencontroller.h	1970-01-01 00:00:00 +0000
 +++ src/platforms/mirserver/screencontroller.h	2015-10-14 23:14:58 +0000
@@ -0,0 +1,96 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#ifndef SCREENCONTROLLER_H
++#define SCREENCONTROLLER_H
++
++#include <QObject>
++#include <QPoint>
++
++// Mir
++#include <mir/graphics/display_configuration.h>
++
++// std
++#include <memory>
++
++namespace mir {
++    namespace graphics { class Display; }
++    namespace compositor { class Compositor; }
++}
++class Screen;
++class QWindow;
++
++/*
++ * ScreenController monitors the Mir display configuration and compositor status, and updates
++ * the relevant QScreen and QWindow states accordingly.
++ *
++ * Primary purposes are:
++ * 1. to update QScreen state on Mir display configuration changes
++ * 2. to stop the Qt renderer by hiding its QWindow when Mir wants to stop all compositing,
++ *    and resume Qt's renderer by showing its QWindow when Mir wants to resume compositing.
++ *
++ *
++ * Threading Note:
++ * This object must have affinity to the main Qt GUI thread, as it creates & destroys Platform
++ * objects which Qt uses internally. However beware as the init() & terminate() methods need to
++ * be called on the MirServerThread thread, as we need to monitor the screen state *after*
++ * Mir has initialized but before Qt's event loop has started, and tear down before Mir terminates.
++ * Also note the MirServerThread does not have an QEventLoop.
++ *
++ * All other methods must be called on the Qt GUI thread.
++ */
++
++class ScreenController : public QObject
++{
++    Q_OBJECT
++public:
++    explicit ScreenController(QObject *parent = 0);
++
++    Screen* getUnusedScreen();
++    QList<Screen*> screens() const { return m_screenList; }
++    bool compositing() const { return m_compositing; }
++
++    QWindow* getWindowForPoint(const QPoint &point);
++
++Q_SIGNALS:
++    void screenAdded(Screen *screen);
++
++public Q_SLOTS:
++    void update();
++
++public:
++    // called by MirServer
++    void init(const std::shared_ptr<mir::graphics::Display> &display,
++              const std::shared_ptr<mir::compositor::Compositor> &compositor);
++    void terminate();
++
++    // override for testing purposes
++    virtual Screen *createScreen(const mir::graphics::DisplayConfigurationOutput &output) const;
++
++protected Q_SLOTS:
++    void onCompositorStarting();
++    void onCompositorStopping();
++
++private:
++    Screen* findScreenWithId(const QList<Screen*> &list, const mir::graphics::DisplayConfigurationOutputId id);
++
++    std::weak_ptr<mir::graphics::Display> m_display;
++    std::shared_ptr<mir::compositor::Compositor> m_compositor;
++    QList<Screen*> m_screenList;
++    bool m_compositing;
++};
++
++#endif // SCREENCONTROLLER_H
 === renamed file 'src/platforms/mirserver/displaywindow.cpp' => 'src/platforms/mirserver/screenwindow.cpp'
 --- src/platforms/mirserver/displaywindow.cpp	2015-10-07 14:38:44 +0000
 +++ src/platforms/mirserver/screenwindow.cpp	2015-10-14 23:14:58 +0000
@@ -14,15 +14,22 @@
   * along with this program.  If not, see <http://www.gnu.org/licenses/>.
   */
--#include "displaywindow.h"
--
--#include "mir/geometry/size.h"
--
++#include "screenwindow.h"
++#include "screen.h"
++
++// Mir
++#include <mir/geometry/size.h>
++#include <mir/graphics/display_buffer.h>
++
++// Qt
  #include <qpa/qwindowsysteminterface.h>
  #include <qpa/qplatformscreen.h>
--
++#include <QQuickWindow>
++#include <QtQuick/private/qsgrenderloop_p.h>
  #include <QDebug>
++#include "logging.h"
++
  static WId newWId()
+ {
      static WId id = 0;
@@ -33,34 +40,22 @@
      return ++id;
+ }
--static mir::renderer::gl::RenderTarget *as_render_target(
--    mir::graphics::DisplayBuffer *displayBuffer)
--{
--    auto const render_target =
--        dynamic_cast<mir::renderer::gl::RenderTarget*>(
--            displayBuffer->native_display_buffer());
--    if (!render_target)
--        throw std::logic_error("DisplayBuffer does not support GL rendering");
--
--    return render_target;
--}
--
--DisplayWindow::DisplayWindow(
--    QWindow *window,
--    mir::graphics::DisplaySyncGroup *displayGroup,
--    mir::graphics::DisplayBuffer *displayBuffer)
--    : QObject(nullptr), QPlatformWindow(window)
--    , m_isExposed(true)
++ScreenWindow::ScreenWindow(QWindow *window)
++    : QPlatformWindow(window)
++    , m_exposed(false)
      , m_winId(newWId())
--    , m_displayGroup(displayGroup)
--    , m_renderTarget(as_render_target(displayBuffer))
+ {
--    qDebug() << "DisplayWindow::DisplayWindow";
--    qWarning("Window %p: %p 0x%x\n", this, window, uint(m_winId));
++    // Register with the Screen it is associated with
++    auto myScreen = static_cast<Screen *>(screen());
++    Q_ASSERT(myScreen);
++    myScreen->setWindow(this);
++
++    qCDebug(QTMIR_SCREENS) << "ScreenWindow" << this << "with window ID" << uint(m_winId) << "backed by" << myScreen;
      QRect screenGeometry(screen()->availableGeometry());
      if (window->geometry() != screenGeometry) {
          setGeometry(screenGeometry);
++        window->setGeometry(screenGeometry);
+     }
      window->setSurfaceType(QSurface::OpenGLSurface);
@@ -69,70 +64,54 @@
      requestActivateWindow();
+ }
--QRect DisplayWindow::geometry() const
--{
--    // For yet-to-become-fullscreen windows report the geometry covering the entire
--    // screen. This is particularly important for Quick where the root object may get
--    // sized to some geometry queried before calling create().
--    return screen()->availableGeometry();
--}
--
--void DisplayWindow::setGeometry(const QRect &)
--{
--    // We only support full-screen windows
--    QRect rect(screen()->availableGeometry());
--    QWindowSystemInterface::handleGeometryChange(window(), rect);
--    QPlatformWindow::setGeometry(rect);
--}
--
--bool DisplayWindow::isExposed() const
--{
--    return m_isExposed;
--}
--
--bool DisplayWindow::event(QEvent *event)
--{
--    // Intercept Hide event and convert to Expose event, as Hide causes Qt to release GL
--    // resources, which we don't want. Must intercept Show to un-do hide.
--    if (event->type() == QEvent::Hide) {
--        qDebug() << "DisplayWindow::event got QEvent::Hide";
--        m_isExposed = false;
--        QWindowSystemInterface::handleExposeEvent(window(), QRect());
--        QWindowSystemInterface::flushWindowSystemEvents();
--        return true;
--    } else if (event->type() == QEvent::Show) {
--        qDebug() << "DisplayWindow::event got QEvent::Show";
--        m_isExposed = true;
--        QRect rect(QPoint(), geometry().size());
--        QWindowSystemInterface::handleExposeEvent(window(), rect);
--        QWindowSystemInterface::flushWindowSystemEvents();
--        return true;
++ScreenWindow::~ScreenWindow()
++{
++    qCDebug(QTMIR_SCREENS) << "Destroying ScreenWindow" << this;
++    static_cast<Screen *>(screen())->setWindow(nullptr);
++}
++
++bool ScreenWindow::isExposed() const
++{
++    return m_exposed;
++}
++
++void ScreenWindow::setExposed(const bool exposed)
++{
++    qCDebug(QTMIR_SCREENS) << "ScreenWindow::setExposed" << this << exposed;
++    if (m_exposed == exposed)
++        return;
++
++    m_exposed = exposed;
++    if (!window())
++        return;
++
++    // If backing a QQuickWindow, need to stop/start its renderer immediately
++    auto quickWindow = static_cast<QQuickWindow *>(window());
++    if (!quickWindow)
++        return;
++
++    auto renderer = QSGRenderLoop::instance();
++    if (exposed) {
++        renderer->show(quickWindow);
++        QWindowSystemInterface::handleExposeEvent(window(), QRegion()); // else it won't redraw
++    } else {
++        quickWindow->setPersistentOpenGLContext(false);
++        quickWindow->setPersistentSceneGraph(false);
++        renderer->hide(quickWindow); // ExposeEvent will arrive too late, need to stop compositor immediately
+     }
--    return QObject::event(event);
--}
--
--void DisplayWindow::swapBuffers()
--{
--    m_renderTarget->swap_buffers();
--
--    // FIXME this exposes a QtMir architecture problem now, as DisplayWindow
--    // is supposed to wrap a mg::DisplayBuffer. We use Qt's multithreaded
--    // renderer, where each DisplayWindow is rendered to relatively
--    // independently, and post() called also individually.
--    //
--    // But in multimonitor case where a DisplaySyncGroup contains 2
--    // DisplayBuffers, one post() call will submit both
--    // mg::DisplayBuffers for flipping, which can happen before the other
--    // DisplayWindow has been rendered to, causing visual artifacts
--    m_displayGroup->post();
--}
--
--void DisplayWindow::makeCurrent()
--{
--    m_renderTarget->make_current();
--}
--
--void DisplayWindow::doneCurrent()
--{
--    m_renderTarget->release_current();
++}
++
++void ScreenWindow::swapBuffers()
++{
++    static_cast<Screen *>(screen())->swapBuffers();
++}
++
++void ScreenWindow::makeCurrent()
++{
++    static_cast<Screen *>(screen())->makeCurrent();
++}
++
++void ScreenWindow::doneCurrent()
++{
++    static_cast<Screen *>(screen())->doneCurrent();
+ }
 === renamed file 'src/platforms/mirserver/displaywindow.h' => 'src/platforms/mirserver/screenwindow.h'
 --- src/platforms/mirserver/displaywindow.h	2015-10-07 14:38:44 +0000
 +++ src/platforms/mirserver/screenwindow.h	2015-10-14 23:14:58 +0000
@@ -14,44 +14,33 @@
   * along with this program.  If not, see <http://www.gnu.org/licenses/>.
   */
--#ifndef DISPLAYWINDOW_H
--#define DISPLAYWINDOW_H
++#ifndef SCREENWINDOW_H
++#define SCREENWINDOW_H
  #include <qpa/qplatformwindow.h>
--#include <mir/graphics/display.h>
--#include <mir/graphics/display_buffer.h>
--#include <mir/renderer/gl/render_target.h>
--
--#include <QObject>
--
--// DisplayWindow wraps the whatever implementation Mir creates of a DisplayBuffer,
--// which is the buffer output for an individual display.
--
--class DisplayWindow : public QObject, public QPlatformWindow
++// ScreenWindow implements the basics of a QPlatformWindow.
++// QtMir enforces one Window per Screen, so Window and Screen are tightly coupled.
++// All Mir specifics live in the associated Screen object.
++
++class ScreenWindow : public QPlatformWindow
+ {
--    Q_OBJECT
  public:
--    explicit DisplayWindow(QWindow *window, mir::graphics::DisplaySyncGroup*, mir::graphics::DisplayBuffer*);
++    explicit ScreenWindow(QWindow *window);
++    virtual ~ScreenWindow();
--    QRect geometry() const override;
--    void setGeometry(const QRect &rect) override;
++    bool isExposed() const override;
++    void setExposed(const bool exposed);
      WId winId() const override { return m_winId; }
--    bool isExposed() const override;
--
--    bool event(QEvent *event) override;
--
      void swapBuffers();
      void makeCurrent();
      void doneCurrent();
  private:
--    bool m_isExposed;
++    bool m_exposed;
      WId m_winId;
--    mir::graphics::DisplaySyncGroup *m_displayGroup;
--    mir::renderer::gl::RenderTarget *m_renderTarget;
  };
--#endif // DISPLAYWINDOW_H
++#endif // SCREENWINDOW_H
 === added file 'src/platforms/mirserver/tileddisplayconfigurationpolicy.cpp'
 --- src/platforms/mirserver/tileddisplayconfigurationpolicy.cpp	1970-01-01 00:00:00 +0000
 +++ src/platforms/mirserver/tileddisplayconfigurationpolicy.cpp	2015-10-14 23:14:58 +0000
@@ -0,0 +1,44 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#include "tileddisplayconfigurationpolicy.h"
++
++#include <mir/graphics/display_configuration.h>
++#include <mir/geometry/point.h>
++
++namespace mg = mir::graphics;
++
++TiledDisplayConfigurationPolicy::TiledDisplayConfigurationPolicy(
++        const std::shared_ptr<mir::graphics::DisplayConfigurationPolicy> &wrapped)
++    : m_wrapped(wrapped)
++{
++}
++
++void TiledDisplayConfigurationPolicy::apply_to(mg::DisplayConfiguration& conf)
++{
++    int nextTopLeftPosition = 0;
++
++    m_wrapped->apply_to(conf);
++
++    conf.for_each_output(
++        [&](mg::UserDisplayConfigurationOutput& output)
++        {
++            if (output.connected && output.used) {
++                output.top_left = mir::geometry::Point{nextTopLeftPosition, 0};
++                nextTopLeftPosition += output.modes[output.preferred_mode_index].size.width.as_int();
++            }
++        });
++}
 === added file 'src/platforms/mirserver/tileddisplayconfigurationpolicy.h'
 --- src/platforms/mirserver/tileddisplayconfigurationpolicy.h	1970-01-01 00:00:00 +0000
 +++ src/platforms/mirserver/tileddisplayconfigurationpolicy.h	2015-10-14 23:14:58 +0000
@@ -0,0 +1,35 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#ifndef TILEDDISPLAYCONFIGURATIONPOLICY_H
++#define TILEDDISPLAYCONFIGURATIONPOLICY_H
++
++#include <mir/graphics/display_configuration_policy.h>
++
++#include <memory>
++
++class TiledDisplayConfigurationPolicy : public mir::graphics::DisplayConfigurationPolicy
++{
++public:
++    TiledDisplayConfigurationPolicy(const std::shared_ptr<mir::graphics::DisplayConfigurationPolicy> &wrapped);
++
++    void apply_to(mir::graphics::DisplayConfiguration& conf) override;
++
++private:
++    const std::shared_ptr<mir::graphics::DisplayConfigurationPolicy> m_wrapped;
++};
++
++#endif // TILEDDISPLAYCONFIGURATIONPOLICY_H
 === added directory 'tests/common'
 === added file 'tests/common/fake_displayconfigurationoutput.h'
 --- tests/common/fake_displayconfigurationoutput.h	1970-01-01 00:00:00 +0000
 +++ tests/common/fake_displayconfigurationoutput.h	2015-10-14 23:14:58 +0000
@@ -0,0 +1,77 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#ifndef FAKE_DISPLAYCONFIGURATIONOUTPUT_H
++#define FAKE_DISPLAYCONFIGURATIONOUTPUT_H
++
++#include <mir/graphics/display_configuration.h>
++
++namespace mg = mir::graphics;
++namespace geom = mir::geometry;
++
++const mg::DisplayConfigurationOutput fakeOutput1
++{
++    mg::DisplayConfigurationOutputId{3},
++    mg::DisplayConfigurationCardId{2},
++    mg::DisplayConfigurationOutputType::dvid,
++    {
++        mir_pixel_format_abgr_8888
++    },
++    {
++        {geom::Size{100, 200}, 60.0},
++        {geom::Size{100, 200}, 59.0},
++        {geom::Size{150, 200}, 59.0}
++    },
++    0,
++    geom::Size{1111, 2222},
++    true,
++    true,
++    geom::Point(),
++    2,
++    mir_pixel_format_abgr_8888,
++    mir_power_mode_on,
++    mir_orientation_normal,
++    1.0f,
++    mir_form_factor_unknown
++};
++
++const mg::DisplayConfigurationOutput fakeOutput2
++{
++    mg::DisplayConfigurationOutputId{2},
++    mg::DisplayConfigurationCardId{4},
++    mg::DisplayConfigurationOutputType::lvds,
++    {
++        mir_pixel_format_xbgr_8888
++    },
++    {
++        {geom::Size{800, 1200}, 90.0},
++        {geom::Size{1600, 2400}, 60.0},
++        {geom::Size{1500, 2000}, 75.0}
++    },
++    0,
++    geom::Size{1000, 2000},
++    true,
++    true,
++    geom::Point(500, 600),
++    2,
++    mir_pixel_format_xbgr_8888,
++    mir_power_mode_on,
++    mir_orientation_left,
++    1.0f,
++    mir_form_factor_unknown
++};
++
++#endif // FAKE_DISPLAYCONFIGURATIONOUTPUT_H
 === added file 'tests/common/gmock_fixes.h'
 --- tests/common/gmock_fixes.h	1970-01-01 00:00:00 +0000
 +++ tests/common/gmock_fixes.h	2015-10-14 23:14:58 +0000
@@ -0,0 +1,124 @@
++//
++// Copyright © 2012 Canonical Ltd. Copyright 2007, Google Inc.
++//
++// All rights reserved.
++//
++// Redistribution and use in source and binary forms, with or without
++// modification, are permitted provided that the following conditions are
++// met:
++//
++//     * Redistributions of source code must retain the above copyright
++// notice, this list of conditions and the following disclaimer.
++//     * Redistributions in binary form must reproduce the above
++// copyright notice, this list of conditions and the following disclaimer
++// in the documentation and/or other materials provided with the
++// distribution.
++//     * Neither the name of Google Inc. nor the names of its
++// contributors may be used to endorse or promote products derived from
++// this software without specific prior written permission.
++//
++// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
++// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
++// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
++// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
++// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
++// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
++// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
++// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
++// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
++// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
++// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
++//
++// Author: wan@google.com (Zhanyong Wan)
++// Authored by: Alan Griffiths <alan@octopull.co.uk>
++
++#ifndef MIR_TEST_GMOCK_FIXES_H_
++#define MIR_TEST_GMOCK_FIXES_H_
++
++#include <memory>
++#include <gmock/gmock.h>
++
++namespace testing
++{
++namespace internal
++{
++
++template<typename T>
++class ActionResultHolder<std::unique_ptr<T>>
++: public UntypedActionResultHolderBase {
++ public:
++  explicit ActionResultHolder(std::unique_ptr<T>&& a_value) :
++  value_(std::move(a_value)) {}
++
++  // The compiler-generated copy constructor and assignment operator
++  // are exactly what we need, so we don't need to define them.
++
++  // Returns the held value and deletes this object.
++  std::unique_ptr<T> GetValueAndDelete() const {
++      std::unique_ptr<T> retval(std::move(value_));
++    delete this;
++    return retval;
++  }
++
++  // Prints the held value as an action's result to os.
++  virtual void PrintAsActionResult(::std::ostream* os) const {
++    *os << "\n          Returns: ";
++    // T may be a reference type, so we don't use UniversalPrint().
++    UniversalPrinter<std::unique_ptr<T>>::Print(value_, os);
++  }
++
++  // Performs the given mock function's default action and returns the
++  // result in a new-ed ActionResultHolder.
++  template <typename F>
++  static ActionResultHolder* PerformDefaultAction(
++      const FunctionMockerBase<F>* func_mocker,
++      const typename Function<F>::ArgumentTuple& args,
++      const string& call_description) {
++    return new ActionResultHolder(
++        func_mocker->PerformDefaultAction(args, call_description));
++  }
++
++  // Performs the given action and returns the result in a new-ed
++  // ActionResultHolder.
++  template <typename F>
++  static ActionResultHolder*
++  PerformAction(const Action<F>& action,
++                const typename Function<F>::ArgumentTuple& args) {
++    return new ActionResultHolder(action.Perform(args));
++  }
++
++ private:
++  std::unique_ptr<T> mutable value_;
++
++  // T could be a reference type, so = isn't supported.
++  GTEST_DISALLOW_ASSIGN_(ActionResultHolder);
++};
++
++}
++
++template<typename T>
++class DefaultValue<std::unique_ptr<T>> {
++ public:
++  // Unsets the default value for type T.
++  static void Clear() {}
++
++  // Returns true iff the user has set the default value for type T.
++  static bool IsSet() { return false; }
++
++  // Returns true if T has a default return value set by the user or there
++  // exists a built-in default value.
++  static bool Exists() {
++    return true;
++  }
++
++  // Returns the default value for type T if the user has set one;
++  // otherwise returns the built-in default value if there is one;
++  // otherwise aborts the process.
++  static std::unique_ptr<T> Get() {
++    return std::unique_ptr<T>();
++  }
++};
++
++}
++
++#endif /* MIR_TEST_GMOCK_FIXES_H_ */
 === added file 'tests/common/mock_display.h'
 --- tests/common/mock_display.h	1970-01-01 00:00:00 +0000
 +++ tests/common/mock_display.h	2015-10-14 23:14:58 +0000
@@ -0,0 +1,53 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#ifndef MOCKDISPLAY_H
++#define MOCKDISPLAY_H
++
++#include <mir/graphics/display.h>
++#include <mir/graphics/gl_context.h>
++
++#include <gmock/gmock.h>
++#include "gmock_fixes.h"
++
++class MockDisplaySyncGroup : public mir::graphics::DisplaySyncGroup
++{
++public:
++    MOCK_METHOD1(for_each_display_buffer, void(std::function<void(mir::graphics::DisplayBuffer&)> const& f));
++    MOCK_METHOD0(post, void());
++};
++
++struct MockDisplay : public mir::graphics::Display
++{
++public:
++    MOCK_METHOD1(for_each_display_sync_group, void(std::function<void(mir::graphics::DisplaySyncGroup&)> const&));
++    MOCK_CONST_METHOD0(configuration, std::unique_ptr<mir::graphics::DisplayConfiguration>());
++    MOCK_METHOD1(configure, void(mir::graphics::DisplayConfiguration const&));
++    MOCK_METHOD2(register_configuration_change_handler,
++                 void(mir::graphics::EventHandlerRegister&, mir::graphics::DisplayConfigurationChangeHandler const&));
++
++    MOCK_METHOD3(register_pause_resume_handlers, void(mir::graphics::EventHandlerRegister&,
++                                                      mir::graphics::DisplayPauseHandler const&,
++                                                      mir::graphics::DisplayResumeHandler const&));
++    MOCK_METHOD0(pause, void());
++    MOCK_METHOD0(resume, void());
++    MOCK_METHOD1(create_hardware_cursor, std::shared_ptr<mir::graphics::Cursor>(std::shared_ptr<mir::graphics::CursorImage> const&));
++    MOCK_METHOD0(create_gl_context, std::unique_ptr<mir::graphics::GLContext>());
++};
++
++
++
++#endif // MOCKDISPLAY_H
 === added file 'tests/common/mock_display_configuration.h'
 --- tests/common/mock_display_configuration.h	1970-01-01 00:00:00 +0000
 +++ tests/common/mock_display_configuration.h	2015-10-14 23:14:58 +0000
@@ -0,0 +1,35 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#ifndef MOCK_DISPLAY_CONFIGURATION_H
++#define MOCK_DISPLAY_CONFIGURATION_H
++
++#include <mir/graphics/display_configuration.h>
++
++#include <gmock/gmock.h>
++#include "gmock_fixes.h"
++
++class MockDisplayConfiguration : public mir::graphics::DisplayConfiguration
++{
++public:
++    MOCK_CONST_METHOD1(for_each_card, void(std::function<void(mir::graphics::DisplayConfigurationCard const&)>));
++
++    MOCK_CONST_METHOD1(for_each_output, void(std::function<void(mir::graphics::DisplayConfigurationOutput const&)>));
++    MOCK_METHOD1(for_each_output, void(std::function<void(mir::graphics::UserDisplayConfigurationOutput&)>));
++
++    MOCK_CONST_METHOD0(valid, bool());
++};
++#endif // MOCK_DISPLAY_CONFIGURATION_H
 === added file 'tests/common/mock_gl_display_buffer.h'
 --- tests/common/mock_gl_display_buffer.h	1970-01-01 00:00:00 +0000
 +++ tests/common/mock_gl_display_buffer.h	2015-10-14 23:14:58 +0000
@@ -0,0 +1,49 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#ifndef MOCK_GL_DISPLAY_BUFFER_H
++#define MOCK_GL_DISPLAY_BUFFER_H
++
++#include <mir/graphics/display_buffer.h>
++#include <mir/renderer/gl/render_target.h>
++
++#include <gmock/gmock.h>
++
++class MockGLDisplayBuffer : public mir::graphics::DisplayBuffer,
++                            public mir::renderer::gl::RenderTarget,
++                            public mir::graphics::NativeDisplayBuffer
++{
++public:
++    MockGLDisplayBuffer()
++    {
++        using namespace testing;
++        ON_CALL(*this, view_area())
++            .WillByDefault(Return(mir::geometry::Rectangle{{0,0},{0,0}}));
++        ON_CALL(*this, native_display_buffer())
++            .WillByDefault(Return(dynamic_cast<mir::graphics::NativeDisplayBuffer*>(this)));
++    }
++    MOCK_CONST_METHOD0(view_area, mir::geometry::Rectangle());
++    MOCK_METHOD1(post_renderables_if_optimizable, bool(mir::graphics::RenderableList const&));
++    MOCK_CONST_METHOD0(orientation, MirOrientation());
++    MOCK_METHOD0(native_display_buffer, mir::graphics::NativeDisplayBuffer*());
++
++    MOCK_METHOD0(make_current, void());
++    MOCK_METHOD0(release_current, void());
++    MOCK_METHOD0(swap_buffers, void());
++};
++
++
++#endif // MOCK_GL_DISPLAY_BUFFER_H
 === added file 'tests/common/mock_main_loop.h'
 --- tests/common/mock_main_loop.h	1970-01-01 00:00:00 +0000
 +++ tests/common/mock_main_loop.h	2015-10-14 23:14:58 +0000
@@ -0,0 +1,53 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#ifndef MOCKMAINLOOP_H
++#define MOCKMAINLOOP_H
++
++#include <gmock/gmock.h>
++
++#include <mir/main_loop.h>
++
++#include <memory>
++
++class MockMainLoop : public mir::MainLoop
++{
++public:
++    ~MockMainLoop() noexcept {}
++
++    void run() override {}
++    void stop() override {}
++
++    MOCK_METHOD2(register_signal_handler,
++                 void(std::initializer_list<int>,
++                      std::function<void(int)> const&));
++
++    MOCK_METHOD3(register_fd_handler,
++                 void(std::initializer_list<int>, void const*,
++                      std::function<void(int)> const&));
++
++    MOCK_METHOD1(unregister_fd_handler, void(void const*));
++
++    MOCK_METHOD2(enqueue, void(void const*, mir::ServerAction const&));
++    MOCK_METHOD1(pause_processing_for,void (void const*));
++    MOCK_METHOD1(resume_processing_for,void (void const*));
++
++    MOCK_METHOD1(create_alarm, std::unique_ptr<mir::time::Alarm>(std::function<void()> const& callback));
++    MOCK_METHOD1(create_alarm, std::unique_ptr<mir::time::Alarm>(std::shared_ptr<mir::LockableCallback> const& callback));
++};
++
++
++#endif // MOCKMAINLOOP_H
 === modified file 'tests/mirserver/CMakeLists.txt'
 --- tests/mirserver/CMakeLists.txt	2014-11-13 15:47:30 +0000
 +++ tests/mirserver/CMakeLists.txt	2015-10-14 23:14:58 +0000
@@ -1,3 +1,4 @@
  add_subdirectory(QtEventFeeder)
  add_subdirectory(Clipboard)
  add_subdirectory(Screen)
++add_subdirectory(ScreenController)
 === modified file 'tests/mirserver/QtEventFeeder/mock_qtwindowsystem.h'
 --- tests/mirserver/QtEventFeeder/mock_qtwindowsystem.h	2015-10-14 23:14:58 +0000
 +++ tests/mirserver/QtEventFeeder/mock_qtwindowsystem.h	2015-10-14 23:14:58 +0000
@@ -19,19 +19,26 @@
  #define MOCK_QTWINDOWSYSTEM_H
  #include <qteventfeeder.h>
++#include <QWindow>
  class MockQtWindowSystem : public QtEventFeeder::QtWindowSystemInterface {
  public:
--    MOCK_METHOD0(hasTargetWindow, bool());
--    MOCK_METHOD0(targetWindowGeometry, QRect());
++    MOCK_CONST_METHOD0(ready, bool());
++    MOCK_METHOD1(setScreenController, void(const QSharedPointer<ScreenController> &));
++    MOCK_METHOD1(getWindowForTouchPoint, QWindow*(const QPoint &point));
++    MOCK_METHOD0(lastWindow, QWindow*());
++    MOCK_METHOD0(focusedWindow, QWindow*());
      MOCK_METHOD1(registerTouchDevice, void(QTouchDevice* device));
--    MOCK_METHOD10(handleExtendedKeyEvent, void(ulong timestamp, QEvent::Type type, int key,
--            Qt::KeyboardModifiers modifiers,
--            quint32 nativeScanCode, quint32 nativeVirtualKey,
--            quint32 nativeModifiers,
--            const QString& text, bool autorep,
--            ushort count));
--    MOCK_METHOD4(handleTouchEvent, void(ulong timestamp, QTouchDevice *device,
++
++    // Wanted to use GMock, but MOCK_METHOD11 not implemented
++    void handleExtendedKeyEvent(QWindow */*window*/, ulong /*timestamp*/, QEvent::Type /*type*/, int /*key*/,
++            Qt::KeyboardModifiers /*modifiers*/,
++            quint32 /*nativeScanCode*/, quint32 /*nativeVirtualKey*/,
++            quint32 /*nativeModifiers*/,
++            const QString& /*text*/ = QString(), bool /*autorep*/ = false,
++            ushort /*count*/ = 1) {}
++
++    MOCK_METHOD5(handleTouchEvent, void(QWindow *window, ulong timestamp, QTouchDevice *device,
              const QList<struct QWindowSystemInterface::TouchPoint> &points,
              Qt::KeyboardModifiers mods));
      MOCK_METHOD4(handleMouseEvent, void(ulong, QPointF, Qt::MouseButtons, Qt::KeyboardModifiers));
 === modified file 'tests/mirserver/QtEventFeeder/qteventfeeder_test.cpp'
 --- tests/mirserver/QtEventFeeder/qteventfeeder_test.cpp	2015-09-18 16:33:06 +0000
 +++ tests/mirserver/QtEventFeeder/qteventfeeder_test.cpp	2015-10-14 23:14:58 +0000
@@ -69,33 +69,44 @@
      MockQtWindowSystem *mockWindowSystem;
      QtEventFeeder *qtEventFeeder;
++    QWindow *window;
++    QGuiApplication *app;
  };
  void QtEventFeederTest::SetUp()
+ {
      mockWindowSystem = new MockQtWindowSystem;
++    auto screens = QSharedPointer<ScreenController>();
      EXPECT_CALL(*mockWindowSystem, registerTouchDevice(_));
--    qtEventFeeder = new QtEventFeeder(mockWindowSystem);
++    qtEventFeeder = new QtEventFeeder(screens, mockWindowSystem);
      ASSERT_TRUE(Mock::VerifyAndClearExpectations(mockWindowSystem));
++
++    int argc = 0;
++    char **argv = nullptr;
++    setenv("QT_QPA_PLATFORM", "minimal", 1);
++    app = new QGuiApplication(argc, argv);
++    window = new QWindow;
+ }
  void QtEventFeederTest::TearDown()
+ {
      // mockWindowSystem will be deleted by QtEventFeeder
      delete qtEventFeeder;
++    delete window;
++    delete app;
+ }
  void QtEventFeederTest::setIrrelevantMockWindowSystemExpectations()
+ {
--    EXPECT_CALL(*mockWindowSystem, hasTargetWindow())
--        .Times(AnyNumber())
--        .WillRepeatedly(Return(true));
--    EXPECT_CALL(*mockWindowSystem, targetWindowGeometry())
--        .Times(AnyNumber())
--        .WillRepeatedly(Return(QRect(0,0,100,100)));
++    EXPECT_CALL(*mockWindowSystem, getWindowForTouchPoint(_))
++        .Times(AnyNumber())
++        .WillRepeatedly(Return(window));
++    EXPECT_CALL(*mockWindowSystem, focusedWindow())
++        .Times(AnyNumber())
++        .WillRepeatedly(Return(window));
+ }
@@ -113,7 +124,7 @@
      setIrrelevantMockWindowSystemExpectations();
--    EXPECT_CALL(*mockWindowSystem, handleTouchEvent(_,_,AllOf(SizeIs(1),
++    EXPECT_CALL(*mockWindowSystem, handleTouchEvent(_,_,_,AllOf(SizeIs(1),
                                                                Contains(AllOf(HasId(0),
                                                                               IsPressed()))),_)).Times(1);
@@ -132,12 +143,12 @@
          InSequence sequence;
          EXPECT_CALL(*mockWindowSystem,
--                    handleTouchEvent(_,_,AllOf(SizeIs(1),
++                    handleTouchEvent(_,_,_,AllOf(SizeIs(1),
                                                 Contains(AllOf(HasId(0),IsReleased()))
                                                 ),_)).Times(1);
          EXPECT_CALL(*mockWindowSystem,
--                    handleTouchEvent(_,_,AllOf(SizeIs(1),
++                    handleTouchEvent(_,_,_,AllOf(SizeIs(1),
                                                 Contains(AllOf(HasId(1),IsPressed()))
                                                 ),_)).Times(1);
+     }
@@ -161,7 +172,7 @@
 , 10, 10 /* x, y, pressure*/,
 , 1, 10 /* touch major, minor, size */);
--    EXPECT_CALL(*mockWindowSystem, handleTouchEvent(_,_,AllOf(SizeIs(1),
++    EXPECT_CALL(*mockWindowSystem, handleTouchEvent(_,_,_,AllOf(SizeIs(1),
                                                                Contains(AllOf(HasId(0),
                                                                               IsPressed()))),_)).Times(1);
      qtEventFeeder->dispatch(*ev1);
@@ -181,7 +192,7 @@
 , 1, 10 /* touch major, minor, size */);
      EXPECT_CALL(*mockWindowSystem,
--        handleTouchEvent(_,_,AllOf(SizeIs(2),
++        handleTouchEvent(_,_,_,AllOf(SizeIs(2),
                                     Contains(AllOf(HasId(0), StateIsMoved())),
                                     Contains(AllOf(HasId(1), IsPressed()))
                                     ),_)).Times(1);
@@ -208,14 +219,14 @@
          // first release touch 0
          EXPECT_CALL(*mockWindowSystem,
--            handleTouchEvent(_,_,AllOf(SizeIs(2),
++            handleTouchEvent(_,_,_,AllOf(SizeIs(2),
                                         Contains(AllOf(HasId(0), IsReleased())),
                                         Contains(AllOf(HasId(1), IsStationary()))
                                         ),_)).Times(1);
          // then press touch 2
          EXPECT_CALL(*mockWindowSystem,
--            handleTouchEvent(_,_,AllOf(SizeIs(2),
++            handleTouchEvent(_,_,_,AllOf(SizeIs(2),
                                         Contains(AllOf(HasId(1), StateIsMoved())),
                                         Contains(AllOf(HasId(2), IsPressed()))
                                         ),_)).Times(1);
@@ -230,7 +241,7 @@
+ {
      setIrrelevantMockWindowSystemExpectations();
--    EXPECT_CALL(*mockWindowSystem, handleTouchEvent(_,_,AllOf(SizeIs(1),
++    EXPECT_CALL(*mockWindowSystem, handleTouchEvent(_,_,_,AllOf(SizeIs(1),
                                                                Contains(AllOf(HasId(0),
                                                                               IsPressed()))),_)).Times(1);
@@ -243,7 +254,7 @@
      setIrrelevantMockWindowSystemExpectations();
--    EXPECT_CALL(*mockWindowSystem, handleTouchEvent(_,_,AllOf(SizeIs(1),
++    EXPECT_CALL(*mockWindowSystem, handleTouchEvent(_,_,_,AllOf(SizeIs(1),
                                                                Contains(AllOf(HasId(0), StateIsMoved()))
                                                               ),_)).Times(1);
 === modified file 'tests/mirserver/Screen/CMakeLists.txt'
 --- tests/mirserver/Screen/CMakeLists.txt	2014-12-03 08:56:35 +0000
 +++ tests/mirserver/Screen/CMakeLists.txt	2015-10-14 23:14:58 +0000
@@ -5,6 +5,7 @@
+ )
  include_directories(
++  ${CMAKE_SOURCE_DIR}/tests/common
    ${CMAKE_SOURCE_DIR}/src/platforms/mirserver
    ${CMAKE_SOURCE_DIR}/src/common
    ${Qt5Gui_PRIVATE_INCLUDE_DIRS}
 === modified file 'tests/mirserver/Screen/screen_test.cpp'
 --- tests/mirserver/Screen/screen_test.cpp	2015-10-08 12:33:06 +0000
 +++ tests/mirserver/Screen/screen_test.cpp	2015-10-14 23:14:58 +0000
@@ -18,39 +18,21 @@
  #include <gtest/gtest.h>
  #include "mir/graphics/display_configuration.h"
++#include "fake_displayconfigurationoutput.h"
  #include <screen.h>
++using namespace ::testing;
++
  namespace mg = mir::graphics;
  namespace geom = mir::geometry;
--mg::DisplayConfigurationOutput const fake_output
--{
--    mg::DisplayConfigurationOutputId{3},
--    mg::DisplayConfigurationCardId{2},
--    mg::DisplayConfigurationOutputType::dvid,
--    {
--        mir_pixel_format_abgr_8888
--    },
--    {
--        {geom::Size{10, 20}, 60.0},
--        {geom::Size{10, 20}, 59.0},
--        {geom::Size{15, 20}, 59.0}
--    },
--    0,
--    geom::Size{10, 20},
--    true,
--    true,
--    geom::Point(),
--    2,
--    mir_pixel_format_abgr_8888,
--    mir_power_mode_on,
--    mir_orientation_normal,
--    1.0f,
--    mir_form_factor_unknown
++class ScreenTest : public ::testing::Test {
++protected:
++    void SetUp() override;
  };
--TEST(ScreenTest, OrientationSensor)
++void ScreenTest::SetUp()
+ {
      if (!qEnvironmentVariableIsSet("QT_ACCEL_FILEPATH")) {
          // Trick Qt >= 5.4.1 to load the generic sensors
@@ -58,7 +40,11 @@
+     }
      Screen::skipDBusRegistration = true;
--    Screen *screen = new Screen(fake_output);
++}
++
++TEST_F(ScreenTest, OrientationSensor)
++{
++    Screen *screen = new Screen(fakeOutput1);
      // Default state should be active
      ASSERT_TRUE(screen->orientationSensorEnabled());
@@ -69,3 +55,29 @@
      screen->onDisplayPowerStateChanged(1,0);
      ASSERT_TRUE(screen->orientationSensorEnabled());
+ }
++
++TEST_F(ScreenTest, ReadConfigurationFromDisplayConfig)
++{
++    Screen *screen = new Screen(fakeOutput1);
++
++    EXPECT_EQ(screen->geometry(), QRect(0, 0, 150, 200));
++    EXPECT_EQ(screen->availableGeometry(), QRect(0, 0, 150, 200));
++    EXPECT_EQ(screen->depth(), 32);
++    EXPECT_EQ(screen->format(), QImage::Format_RGBA8888);
++    EXPECT_EQ(screen->refreshRate(), 59);
++    EXPECT_EQ(screen->physicalSize(), QSize(1111, 2222));
++    EXPECT_EQ(screen->outputType(), mg::DisplayConfigurationOutputType::dvid);
++}
++
++TEST_F(ScreenTest, ReadDifferentConfigurationFromDisplayConfig)
++{
++    Screen *screen = new Screen(fakeOutput2);
++
++    EXPECT_EQ(screen->geometry(), QRect(500, 600, 1500, 2000));
++    EXPECT_EQ(screen->availableGeometry(), QRect(500, 600, 1500, 2000));
++    EXPECT_EQ(screen->depth(), 32);
++    EXPECT_EQ(screen->format(), QImage::Format_RGBX8888);
++    EXPECT_EQ(screen->refreshRate(), 75);
++    EXPECT_EQ(screen->physicalSize(), QSize(1000, 2000));
++    EXPECT_EQ(screen->outputType(), mg::DisplayConfigurationOutputType::lvds);
++}
 === added directory 'tests/mirserver/ScreenController'
 === added file 'tests/mirserver/ScreenController/CMakeLists.txt'
 --- tests/mirserver/ScreenController/CMakeLists.txt	1970-01-01 00:00:00 +0000
 +++ tests/mirserver/ScreenController/CMakeLists.txt	2015-10-14 23:14:58 +0000
@@ -0,0 +1,29 @@
++set(
++  SCREENCONTROLLER_TEST_SOURCES
++  screencontroller_test.cpp
++  ${CMAKE_SOURCE_DIR}/src/common/debughelpers.cpp
++  # to be moc-ed
++  stub_screen.h
++  testable_screencontroller.h
++)
++
++include_directories(
++  ${CMAKE_SOURCE_DIR}/tests/common
++  ${CMAKE_SOURCE_DIR}/src/platforms/mirserver
++  ${CMAKE_SOURCE_DIR}/src/common
++  ${Qt5Gui_PRIVATE_INCLUDE_DIRS}
++  ${MIRSERVER_INCLUDE_DIRS}
++  ${MIRRENDERERGLDEV_INCLUDE_DIRS}
++)
++
++add_executable(ScreenControllerTest ${SCREENCONTROLLER_TEST_SOURCES})
++
++target_link_libraries(
++  ScreenControllerTest
++  qpa-mirserver
++
++  ${GTEST_BOTH_LIBRARIES}
++  ${GMOCK_LIBRARIES}
++)
++
++add_test(ScreenController, ScreenControllerTest)
 === added file 'tests/mirserver/ScreenController/screencontroller_test.cpp'
 --- tests/mirserver/ScreenController/screencontroller_test.cpp	1970-01-01 00:00:00 +0000
 +++ tests/mirserver/ScreenController/screencontroller_test.cpp	2015-10-14 23:14:58 +0000
@@ -0,0 +1,189 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#include <gtest/gtest.h>
++#include "gmock_fixes.h"
++
++#include "stub_display.h"
++#include "mock_main_loop.h"
++#include "qtcompositor.h"
++#include "fake_displayconfigurationoutput.h"
++
++#include "testable_screencontroller.h"
++#include "screen.h"
++#include "screenwindow.h"
++
++#include <QGuiApplication>
++
++using namespace ::testing;
++
++namespace mg = mir::graphics;
++namespace geom = mir::geometry;
++
++class ScreenControllerTest : public ::testing::Test {
++protected:
++    void SetUp() override;
++    void TearDown() override;
++
++    ScreenController *screenController;
++    std::shared_ptr<StubDisplay> display;
++    std::shared_ptr<QtCompositor> compositor;
++    QGuiApplication *app;
++};
++
++void ScreenControllerTest::SetUp()
++{
++    setenv("QT_QPA_PLATFORM", "minimal", 1);
++    Screen::skipDBusRegistration = true;
++
++    screenController = new TestableScreenController;
++    display = std::make_shared<StubDisplay>();
++    compositor = std::make_shared<QtCompositor>();
++
++    static_cast<TestableScreenController*>(screenController)->do_init(display, compositor);
++
++    int argc = 0;
++    char **argv = nullptr;
++    setenv("QT_QPA_PLATFORM", "minimal", 1);
++    app = new QGuiApplication(argc, argv);
++}
++
++void ScreenControllerTest::TearDown()
++{
++    delete screenController;
++}
++
++TEST_F(ScreenControllerTest, SingleScreenFound)
++{
++    // Set up display state
++    std::vector<mg::DisplayConfigurationOutput> config{fakeOutput1};
++    std::vector<MockGLDisplayBuffer*> bufferConfig; // only used to match buffer with display, unecessary here
++    display->setFakeConfiguration(config, bufferConfig);
++
++    screenController->update();
++
++    ASSERT_EQ(1, screenController->screens().count());
++    Screen* screen = screenController->screens().first();
++    EXPECT_EQ(QRect(0, 0, 150, 200), screen->geometry());
++}
++
++TEST_F(ScreenControllerTest, MultipleScreenFound)
++{
++    std::vector<mg::DisplayConfigurationOutput> config{fakeOutput1, fakeOutput2};
++    std::vector<MockGLDisplayBuffer*> bufferConfig; // only used to match buffer with display, unecessary here
++    display->setFakeConfiguration(config, bufferConfig);
++
++    screenController->update();
++
++    ASSERT_EQ(2, screenController->screens().count());
++    EXPECT_EQ(QRect(0, 0, 150, 200), screenController->screens().at(0)->geometry());
++    EXPECT_EQ(QRect(500, 600, 1500, 2000), screenController->screens().at(1)->geometry());
++}
++
++TEST_F(ScreenControllerTest, ScreenAdded)
++{
++    std::vector<mg::DisplayConfigurationOutput> config{fakeOutput1};
++    std::vector<MockGLDisplayBuffer*> bufferConfig; // only used to match buffer with display, unecessary here
++    display->setFakeConfiguration(config, bufferConfig);
++
++    screenController->update();
++
++    config.push_back(fakeOutput2);
++    display->setFakeConfiguration(config, bufferConfig);
++
++    ASSERT_EQ(1, screenController->screens().count());
++    EXPECT_EQ(QRect(0, 0, 150, 200), screenController->screens().at(0)->geometry());
++
++    screenController->update();
++
++    ASSERT_EQ(2, screenController->screens().count());
++    EXPECT_EQ(QRect(0, 0, 150, 200), screenController->screens().at(0)->geometry());
++    EXPECT_EQ(QRect(500, 600, 1500, 2000), screenController->screens().at(1)->geometry());
++}
++
++TEST_F(ScreenControllerTest, ScreenRemoved)
++{
++    std::vector<mg::DisplayConfigurationOutput> config{fakeOutput2, fakeOutput1};
++    std::vector<MockGLDisplayBuffer*> bufferConfig; // only used to match buffer with display, unecessary here
++    display->setFakeConfiguration(config, bufferConfig);
++
++    screenController->update();
++
++    config.pop_back();
++    display->setFakeConfiguration(config, bufferConfig);
++
++    ASSERT_EQ(2, screenController->screens().count());
++    EXPECT_EQ(QRect(500, 600, 1500, 2000), screenController->screens().at(0)->geometry());
++    EXPECT_EQ(QRect(0, 0, 150, 200), screenController->screens().at(1)->geometry());
++
++    screenController->update();
++
++    ASSERT_EQ(1, screenController->screens().count());
++    EXPECT_EQ(QRect(500, 600, 1500, 2000), screenController->screens().at(0)->geometry());
++}
++
++TEST_F(ScreenControllerTest, CheckPrioritizedGetUnusedScreen)
++{
++    std::vector<mg::DisplayConfigurationOutput> config{fakeOutput2, fakeOutput1};
++    std::vector<MockGLDisplayBuffer*> bufferConfig; // only used to match buffer with display, unecessary here
++    display->setFakeConfiguration(config, bufferConfig);
++
++    screenController->update();
++
++    auto screen = screenController->getUnusedScreen();
++    EXPECT_EQ(mg::DisplayConfigurationOutputType::lvds, screen->outputType());
++}
++
++TEST_F(ScreenControllerTest, MatchBufferWithDisplay)
++{
++    std::vector<mg::DisplayConfigurationOutput> config{fakeOutput1};
++    MockGLDisplayBuffer buffer1;
++    std::vector<MockGLDisplayBuffer*> buffers {&buffer1};
++
++    geom::Rectangle buffer1Geom{{0, 0}, {150, 200}};
++    EXPECT_CALL(buffer1, view_area())
++            .WillRepeatedly(Return(buffer1Geom));
++
++    display->setFakeConfiguration(config, buffers);
++    screenController->update();
++
++    ASSERT_EQ(1, screenController->screens().count());
++    EXPECT_CALL(buffer1, make_current());
++    static_cast<StubScreen*>(screenController->screens().at(0))->makeCurrent();
++}
++
++TEST_F(ScreenControllerTest, MultipleMatchBuffersWithDisplays)
++{
++    std::vector<mg::DisplayConfigurationOutput> config{fakeOutput1, fakeOutput2};
++    MockGLDisplayBuffer buffer1, buffer2;
++    std::vector<MockGLDisplayBuffer*> buffers {&buffer1, &buffer2};
++
++    geom::Rectangle buffer1Geom{{500, 600}, {1500, 2000}};
++    geom::Rectangle buffer2Geom{{0, 0}, {150, 200}};
++    EXPECT_CALL(buffer1, view_area())
++            .WillRepeatedly(Return(buffer1Geom));
++    EXPECT_CALL(buffer2, view_area())
++            .WillRepeatedly(Return(buffer2Geom));
++
++    display->setFakeConfiguration(config, buffers);
++    screenController->update();
++
++    ASSERT_EQ(2, screenController->screens().count());
++    EXPECT_CALL(buffer1, make_current());
++    EXPECT_CALL(buffer2, make_current());
++    static_cast<StubScreen*>(screenController->screens().at(0))->makeCurrent();
++    static_cast<StubScreen*>(screenController->screens().at(1))->makeCurrent();
++}
 === added file 'tests/mirserver/ScreenController/stub_display.h'
 --- tests/mirserver/ScreenController/stub_display.h	1970-01-01 00:00:00 +0000
 +++ tests/mirserver/ScreenController/stub_display.h	2015-10-14 23:14:58 +0000
@@ -0,0 +1,96 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#ifndef STUB_DISPLAY_H
++#define STUB_DISPLAY_H
++
++#include "mock_display.h"
++#include "mock_gl_display_buffer.h"
++#include "mock_display_configuration.h"
++
++namespace mg = mir::graphics;
++namespace geom = mir::geometry;
++
++class StubDisplayConfiguration : public MockDisplayConfiguration
++{
++public:
++    StubDisplayConfiguration(const std::vector<mg::DisplayConfigurationOutput> &config)
++        : m_config(config)
++    {}
++
++    void for_each_output(std::function<void(mg::DisplayConfigurationOutput const&)> f) const override
++    {
++        for (auto config : m_config) {
++            f(config);
++        }
++    }
++
++private:
++    const std::vector<mg::DisplayConfigurationOutput> m_config;
++};
++
++
++class StubDisplaySyncGroup : public MockDisplaySyncGroup
++{
++public:
++    StubDisplaySyncGroup(MockGLDisplayBuffer *buffer) : buffer(buffer) {}
++
++    void for_each_display_buffer(std::function<void(mg::DisplayBuffer&)> const& f) override
++    {
++        f(*buffer);
++    }
++    std::chrono::milliseconds recommended_sleep() const
++    {
++        std::chrono::milliseconds one{1};
++        return one;
++    }
++private:
++    MockGLDisplayBuffer *buffer;
++};
++
++
++class StubDisplay : public MockDisplay
++{
++public:
++    // Note, GMock cannot mock functions which return non-copyable objects, so stubbing needed
++    std::unique_ptr<mg::DisplayConfiguration> configuration() const override
++    {
++        return std::unique_ptr<mg::DisplayConfiguration>(
++            new StubDisplayConfiguration(m_config)
++        );
++    }
++
++    void for_each_display_sync_group(std::function<void(mg::DisplaySyncGroup&)> const& f) override
++    {
++        for (auto displayBuffer : m_displayBuffers) {
++            StubDisplaySyncGroup b(displayBuffer);
++            f(b);
++        }
++    }
++
++    void setFakeConfiguration(std::vector<mg::DisplayConfigurationOutput> &config,
++                              std::vector<MockGLDisplayBuffer*> &displayBuffers)
++    {
++        m_config = config;
++        m_displayBuffers = displayBuffers;
++    }
++
++private:
++    std::vector<mg::DisplayConfigurationOutput> m_config;
++    std::vector<MockGLDisplayBuffer*> m_displayBuffers;
++};
++
++#endif // STUB_DISPLAY_H
 === added file 'tests/mirserver/ScreenController/stub_screen.h'
 --- tests/mirserver/ScreenController/stub_screen.h	1970-01-01 00:00:00 +0000
 +++ tests/mirserver/ScreenController/stub_screen.h	2015-10-14 23:14:58 +0000
@@ -0,0 +1,31 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#ifndef STUBSCREEN_H
++#define STUBSCREEN_H
++
++#include "screen.h"
++
++class StubScreen : public Screen
++{
++    Q_OBJECT
++public:
++    StubScreen(const mir::graphics::DisplayConfigurationOutput &output) : Screen(output) {}
++
++    void makeCurrent() { Screen::makeCurrent(); }
++};
++
++#endif // STUBSCREEN_H
 === added file 'tests/mirserver/ScreenController/testable_screencontroller.h'
 --- tests/mirserver/ScreenController/testable_screencontroller.h	1970-01-01 00:00:00 +0000
 +++ tests/mirserver/ScreenController/testable_screencontroller.h	2015-10-14 23:14:58 +0000
@@ -0,0 +1,37 @@
++/*
++ * Copyright (C) 2015 Canonical, Ltd.
++ *
++ * This program is free software: you can redistribute it and/or modify it under
++ * the terms of the GNU Lesser General Public License version 3, as published by
++ * the Free Software Foundation.
++ *
++ * This program is distributed in the hope that it will be useful, but WITHOUT
++ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
++ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#include "screencontroller.h"
++#include "stub_screen.h"
++
++struct TestableScreenController : public ScreenController
++{
++    Q_OBJECT
++
++public:
++    Screen *createScreen(const mir::graphics::DisplayConfigurationOutput &output) const override
++    {
++        return new StubScreen(output);
++    }
++
++    void do_init(const std::shared_ptr<mir::graphics::Display> &display,
++              const std::shared_ptr<mir::compositor::Compositor> &compositor)
++    {
++        init(display, compositor);
++    }
++
++    void do_terminate() { terminate(); }
++};
 === modified file 'tests/modules/common/qtmir_test.h'
 --- tests/modules/common/qtmir_test.h	2015-08-11 12:08:32 +0000
 +++ tests/modules/common/qtmir_test.h	2015-10-14 23:14:58 +0000
@@ -78,7 +78,7 @@
+ {
  public:
      FakeMirServer()
--    : MirServer(0, argv)
++    : MirServer(0, argv, QSharedPointer<ScreenController>())
+     {
+     }