Launchpad itself

Merge lp:~gmb/launchpad/affects-me-spinner-bug-458766 into lp:launchpad

  1. affects-me-spinner-bug-458766
  2. Merge into devel
Proposed by Graham Binns
Status: Merged
Approved by: Brad Crittenden
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~gmb/launchpad/affects-me-spinner-bug-458766
Merge into: lp:launchpad
Diff against target: 13 lines
1 file modified
lib/canonical/launchpad/javascript/bugs/bugtask-index.js (+2/-1)
To merge this branch: bzr merge lp:~gmb/launchpad/affects-me-spinner-bug-458766
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email: mp+14360@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Graham Binns (gmb) wrote :

This branch fixes bug 458766 by passing a CSS selector for the edit icon
to the MeTooChoiceEdit object that's used to create the "affects me too"
selector. The existing ChoiceEdit code handles turning this into a
spinner whilst actions are being processed and then back to an edit icon
thereafter.

Revision history for this message
Brad Crittenden (bac) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/javascript/bugs/bugtask-index.js'
2--- lib/canonical/launchpad/javascript/bugs/bugtask-index.js 2009-10-29 23:10:29 +0000
3+++ lib/canonical/launchpad/javascript/bugs/bugtask-index.js 2009-11-03 14:45:31 +0000
4@@ -1468,7 +1468,8 @@
5 var me_too_content = Y.get('#affectsmetoo');
6 var me_too_edit = new MeTooChoiceSource({
7 contentBox: me_too_content, value: user_is_affected,
8- elementToFlash: me_too_content
9+ elementToFlash: me_too_content,
10+ editicon: ".dynamic img[src$=/@@/edit]"
11 });
12 me_too_edit.render();
13 };