Launchpad itself

Merge lp:~gmb/launchpad/remove-bug-heat-from-garbo-daily-bug-511283 into lp:launchpad/db-devel

  1. remove-bug-heat-from-garbo-daily-bug-511283
  2. Merge into db-devel
Proposed by Graham Binns
Status: Merged
Approved by: Graham Binns
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~gmb/launchpad/remove-bug-heat-from-garbo-daily-bug-511283
Merge into: lp:launchpad/db-devel
Diff against target: 11 lines (+0/-1)
1 file modified
lib/canonical/launchpad/scripts/garbo.py (+0/-1)
To merge this branch: bzr merge lp:~gmb/launchpad/remove-bug-heat-from-garbo-daily-bug-511283
Reviewer Review Type Date Requested Status
Gary Poster (community) release-critical Approve
Gavin Panella (community) code Approve
Review via email: mp+17912@code.launchpad.net

Commit message

BugHeatUpdater is no longer run as part of garbo-daily.

To post a comment you must log in.
Revision history for this message
Graham Binns (gmb) wrote :

Don't run BugHeatUpdater as part of garbo-daily.

Revision history for this message
Gavin Panella (allenap) :
review: Approve (code)
Revision history for this message
Graham Binns (gmb) wrote :

I've requested a release-critical for this branch since without it there's a good chance that garbo-daily will take well over 30 hours to run after the rollout. That's not so clever an attribute in a daily script.

Note that this would have landed on Friday but for unrelated buildbot failures.

Revision history for this message
Graham Binns (gmb) wrote :

Also note that no tests have been changed; due to the nature of the garbo tests that was unnecessary.

Revision history for this message
Gary Poster (gary) wrote :

Hi Graham. I'm trying for the guideline of "if it would have been a CP, it can be a release-critical". The problem you say it addresses does sound like it would be a CP candidate under non-release circumstances, but could you verify before I pursue further?

Revision history for this message
Gary Poster (gary) wrote :

Graham verified that this is a CP-equivalent, and gave a few more details.

review: Approve (release-critical)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/scripts/garbo.py'
2--- lib/canonical/launchpad/scripts/garbo.py 2010-01-12 16:51:27 +0000
3+++ lib/canonical/launchpad/scripts/garbo.py 2010-01-22 18:08:15 +0000
4@@ -857,7 +857,6 @@
5 PersonEmailAddressLinkChecker,
6 BugNotificationPruner,
7 BranchJobPruner,
8- BugHeatUpdater,
9 ]
10 experimental_tunable_loops = [
11 PersonPruner,

Subscribers

People subscribed via source and target branches

to status/vote changes: