GNOME Calendar

gnome-calendar:fail-in-the-face-of-broken-timezones

  1. Git
  2. lp:gnome-calendar
  3. fail-in-the-face-of-broken-timezones
Last commit made on 2022-10-24
Get this branch:
git clone -b fail-in-the-face-of-broken-timezones https://git.launchpad.net/gnome-calendar

Branch merges

Branch information

Name:
fail-in-the-face-of-broken-timezones
Repository:
lp:gnome-calendar

Recent commits

e5ba935... by Ray Strode <email address hidden>

event: Don't assume UTC if timezone can't be read

glib currently doesn't read the timezone properly from Toolbx
containers. This leads GNOME Calendar to sometimes assuming the
the timezone is UTC.

(See https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2955)

Assuming an arbitrary timezone (even UTC) when the timezone isn't
available isn't great behavior. It's better to fail, I think.

This commit makes it fail in that case.

67d201e... by Yosef Or Boczko <email address hidden>

Update Hebrew translation

fc11c26... by Georges Basile Stavracas Neto

Post-release version bump

54f1ada... by Georges Basile Stavracas Neto

43.1

1fee8ff... by Georges Basile Stavracas Neto

core/recurrence: Port to gatomicrefcount

e3c7a1d... by Georges Basile Stavracas Neto

core/manager: Remove old hack around recurrences

We handle it all before reaching GcalManager now.

502b381... by Georges Basile Stavracas Neto

event-editor/dialog: Properly handle editing recurrent events

When a recurrent event is edited, we now are able to only offer the
MOD_ALL option when it actually will work. However, we're still left
with the problem that we end up applying the instance-specific data
onto the main event, through an old hack.

The views already aren't able to offer the MOD_ALL property, since
they all change the dates of events, but GcalEventEditorDialog can,
and it must handle that properly.

For now, do the simplest possible approach, which is: retrive the
template event and apply all properties that can be applied to it,
without letting the start and end days leak into it. We already only
allow passing MOD_ALL on situations where the dates aren't really
modified, so it should be safe.

Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/882

1023465... by Georges Basile Stavracas Neto

event-editor/dialog: Improve detection of MOD_ALL exclusion cases

679a392... by Georges Basile Stavracas Neto

event-editor/dialog: Don't hide dialog on cancelling operation

If the user clicks the "Cancel" button, it obviously means "cancel",
so let's cancel.

2f1fe2b... by Georges Basile Stavracas Neto

core/event: Fix transfer annotation