Merge lp:~godbyk/ubuntu-docs/raring into lp:ubuntu-docs/saucy

Proposed by Kevin Godby
Status: Merged
Merged at revision: 212
Proposed branch: lp:~godbyk/ubuntu-docs/raring
Merge into: lp:ubuntu-docs/saucy
Diff against target: 11 lines (+1/-1)
1 file modified
html/ubuntu.xsl (+1/-1)
To merge this branch: bzr merge lp:~godbyk/ubuntu-docs/raring
Reviewer Review Type Date Requested Status
Benjamin Kerensa (community) Approve
Review via email: mp+163623@code.launchpad.net

Description of the change

Improved 'file a bug' footer text.

To post a comment you must log in.
Revision history for this message
Benjamin Kerensa (bkerensa) wrote :

Looks good to me! Thanks for the contribution.

Revision history for this message
Benjamin Kerensa (bkerensa) :
review: Approve
Revision history for this message
Doug Smythies (dsmythies) wrote :

The link actually goes to the bug page for Ubuntu (DeskTop) documentation, which then one has to "click" on the "Report a bug" link at the top right of the page to get to the actual "file a bug page".

I would argue that the footer was correct before this change. (I don't actually care either way, I'm just saying is all).

Revision history for this message
Kevin Godby (godbyk) wrote :

Hello, Doug.

On Tue, May 14, 2013 at 11:10 AM, Doug Smythies <email address hidden> wrote:
> The link actually goes to the bug page for Ubuntu (DeskTop) documentation, which then one has to "click" on the "Report a bug" link at the top right of the page to get to the actual "file a bug page".
>
> I would argue that the footer was correct before this change. (I don't actually care either way, I'm just saying is all).

The link itself hasn't changed, only the text surrounding it. Would
you suggest instead that we link directly to the 'Report a bug' link
or did you have something else in mind?

The goal of the change was to try to prevent readers from filing all
bugs under the ubuntu-docs project. I attempted to clarify the
language by specifying that bugs about the documentation itself should
be submitted through that link as opposed to bugs relating to whatever
topic they may be reading about.

I'm definitely open to suggestions for improvement. Thanks!

—Kevin Godby

Revision history for this message
Doug Smythies (dsmythies) wrote :

Somehow I was missing some of the change to the surrounding context. I will make a similar change to the serverguide footer, and I added your name to that bug report, just so that you know about it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'html/ubuntu.xsl'
2--- html/ubuntu.xsl 2013-04-16 02:43:20 +0000
3+++ html/ubuntu.xsl 2013-05-14 00:09:26 +0000
4@@ -704,7 +704,7 @@
5 </div>
6 </div>
7 <div id="footer">
8- <p>The material in this document is available under a free license, see <a href="/legal.html">Legal</a> for details<br /> For information on contributing see the <a href="https://wiki.ubuntu.com/DocumentationTeam">Ubuntu Documentation Team wiki page</a>. To report a problem, visit the <a href="https://bugs.launchpad.net/ubuntu/+source/ubuntu-docs">bug page for Ubuntu Documentation</a></p>
9+ <p>The material in this document is available under a free license, see <a href="/legal.html">Legal</a> for details<br /> For information on contributing see the <a href="https://wiki.ubuntu.com/DocumentationTeam">Ubuntu Documentation Team wiki page</a>. To report errors in this documentation, <a href="https://bugs.launchpad.net/ubuntu/+source/ubuntu-docs">file a bug</a>.</p>
10 </div>
11 </div>
12

Subscribers

People subscribed via source and target branches