lp:~hazmat/juju-gui/readme-update

Branch merges

Propose for merging

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

200. By Kapil Thangavelu on 2012-10-20

update test instructions, and submitting a branch

199. By Kapil Thangavelu on 2012-10-20

update readme to include improv

198. By Gary Poster on 2012-10-20

Separate environment and store charms

On discussion with Kapil, a significant problem from a previous refactoring of mine became clear. Charm ids are only reliably unique within a given context, such as juju environment vs charm store. Therefore, charms from the two sources need to be stored separately.

We discussed some approaches. He suggested storing environment charms in the database and store charms in the browser, and I liked that idea. He also requested that I factor out the charm model code into a separate file, even while keeping it in the juju.models package. Finally, he suggested that charm ids should always include revisions in order to guarantee uniqueness, and to make it possible to consider whether charms from the different sources are identical.

I wrote a long explanation of this in the app/models/charms.js file, including additional considerations.

The charm store needed to send the revision itself, which Kapil changed it to do.

I ended up also factoring out a charm store object, with the ability to get the data from a search, organized as we like it; and to get the data for a specific charm. A nice fall out from the tests of this code is that it exposed some pre-existing problems with sorting code, which I addressed.

The change is quite large because it touches so many of the files. On the bright side, many of the test changes are mechanical, and much of the code is moved and only slightly refactored and changed from other sources, so deletions and moves account for much of the churn.

Kapil made some great changes to the charm store after reviewing this branch that will let us simplify this branch's code in a follow on.

R=hazmat
CC=
https://codereview.appspot.com/6749046

197. By Madison Scott-Clary on 2012-10-19

Fix for rounding error on drag-relation.

New service blocks have integer x/y coordinates, leading to mouseenter failing at the d.containsPoint() test when one of the mouse coordinates matched exactly with one of the edges of the service block. To reproduce, create two new services (say varnish and node-app) and, without navigating away from the environment view, drag them to be diagonal relative to each other, then try to drag a relation from one to the other through the corner of the service node. Correct behavior (this branch) should be for the drag line to snap to the two nearest connectors (as opposed to passing through the service without recognizing that it had entered).

R=
CC=
https://codereview.appspot.com/6741047

196. By Gary Poster on 2012-10-18

Quick fix for bug 1068035

Looks like we lost some small styling in the move over to the new location. This reinstates it, and fixes some lint on trunk.

195. By Madison Scott-Clary on 2012-10-18

Rel drag creation w/ attach point improvements

194. By Thiago Veronezi on 2012-10-18

Service details footer matches design.

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/6698043

193. By Thiago Veronezi on 2012-10-18

Service expose should use on-off slider

R=francesco.banconi, gary.poster
CC=
https://codereview.appspot.com/6693043

192. By Francesco Banconi on 2012-10-18

Preserve environment view zoom during redraw.

The zoom scale and translate are preserved after a scene redraw
(e.g. when adding/removing relations, destroying services,
navigating to the service view and back to the front page).

R=matthew.scott, benjamin.saller
CC=
https://codereview.appspot.com/6720048

191. By Madison Scott-Clary on 2012-10-18

Service health graphs rendered consistently.