Merge lp:~henninge/launchpad/devel-bug-666660-poimport-oops into lp:launchpad
| Status: | Merged |
|---|---|
| Approved by: | Henning Eggers |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 11834 |
| Proposed branch: | lp:~henninge/launchpad/devel-bug-666660-poimport-oops |
| Merge into: | lp:launchpad |
| Diff against target: |
25 lines (+1/-3) 2 files modified
lib/lp/translations/doc/potmsgset.txt (+0/-2) lib/lp/translations/model/potmsgset.py (+1/-1) |
| To merge this branch: | bzr merge lp:~henninge/launchpad/devel-bug-666660-poimport-oops |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jonathan Lange (community) | Approve | ||
| Steve Kowalik (community) | code* | Approve | |
| Launchpad code reviewers | code | Pending | |
|
Review via email:
|
|||
Commit message
Lower log level for "Translations ... match n existing translations." to INFO to avoid it being turned into an OOPS.
Description of the change
= Bug 666660 =
This bug is about OOPSes being generated for logging messages that are not severe enough to warrant that. The code deals with the situation nicely and simply means to leave a notice for statistical purposes. There really is nothing we could do about the situation that it is reporting, anyway.
== Proposed fix ==
Lower the logging level of the message to INFO because they won't get generate OOPSes then.
== Test ==
bin/test -vvct potmsgset.txt
== QA ==
Watch the error reports for the poimport script for OOPSes as described in the bug. They should not appear any more. But this is not really QA'able because of the sporadic nature of the occurrences.
No lint.
| Jonathan Lange (jml) | # |
This looks great!