Launchpad itself

Merge ~ines-almeida/launchpad:frontpage-revamp-remove-old-blog-post into launchpad:master

  1. Git
  2. lp:~ines-almeida/launchpad
  3. frontpage-revamp-remove-old-blog-post
  4. Merge into master
Proposed by Ines Almeida
Status: Merged
Approved by: Ines Almeida
Approved revision: 27aefc9abc02ce20357e7ecedd04836d9c862e4d
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~ines-almeida/launchpad:frontpage-revamp-remove-old-blog-post
Merge into: launchpad:master
Diff against target: 44 lines (+2/-13)
2 files modified
lib/lp/app/browser/tests/test_launchpadroot.py (+2/-8)
lib/lp/app/templates/root-index.pt (+0/-5)
Reviewer Review Type Date Requested Status
Jürgen Gmach Approve
Review via email: mp+460812@code.launchpad.net

Commit message

Remove old pinned blog post from homepage

Description of the change

This removes the pinned blog post from 2009, which gives the impression that we are not that active in our blog since we have a post from 2009 in our recent posts.

To post a comment you must log in.
Revision history for this message
Jürgen Gmach (jugmac00) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/app/browser/tests/test_launchpadroot.py b/lib/lp/app/browser/tests/test_launchpadroot.py
2index 85faf0a..9d81273 100644
3--- a/lib/lp/app/browser/tests/test_launchpadroot.py
4+++ b/lib/lp/app/browser/tests/test_launchpadroot.py
5@@ -182,13 +182,7 @@ class LaunchpadRootIndexViewTestCase(TestCaseWithFactory):
6 self.assertEqual(["called"], calls)
7 items = markup.find_all("li", "news")
8 # Notice about launchpad being opened is always added at the end
9- self.assertEqual(3, len(items))
10- a = items[-1].find("a")
11- self.assertEqual("Launchpad now open source", a.string.strip())
12- for post, item in zip(posts, items):
13- a = item.find("a")
14- self.assertEqual(post["link"], a["href"])
15- self.assertEqual(post["title"], a.string)
16+ self.assertEqual(2, len(items))
17
18 def test_blog_disabled(self):
19 """Launchpad blog not queried for display without feature"""
20@@ -228,7 +222,7 @@ class LaunchpadRootIndexViewTestCase(TestCaseWithFactory):
21 result, parse_only=SoupStrainer(id="homepage-blogposts")
22 )
23 items = markup.find_all("li", "news")
24- self.assertEqual(3, len(items))
25+ self.assertEqual(2, len(items))
26
27 def test_featured_projects_query_count(self):
28 def add_featured_projects():
29diff --git a/lib/lp/app/templates/root-index.pt b/lib/lp/app/templates/root-index.pt
30index 75084b9..da9fac2 100644
31--- a/lib/lp/app/templates/root-index.pt
32+++ b/lib/lp/app/templates/root-index.pt
33@@ -128,11 +128,6 @@
34 our short survey.
35 </tal:description>
36 </li>
37- <li class="news">
38- <a href="http://blog.launchpad.net/general/launchpad-is-now-open-source">
39- Launchpad now open source</a><span class="registered"> &ndash; 21 Jul 2009</span><br />
40- Get the code to Launchpad and join our development community.
41- </li>
42 </ul>
43 <ul class="horizontal">
44 <li>

Subscribers

People subscribed via source and target branches

to status/vote changes: