Launchpad itself

Merge ~ines-almeida/launchpad:upgrade-pkginfo-dependency into launchpad:master

  1. Git
  2. lp:~ines-almeida/launchpad
  3. upgrade-pkginfo-dependency
  4. Merge into master
Proposed by Ines Almeida
Status: Merged
Approved by: Ines Almeida
Approved revision: 14161099eec697563a963d69cc7559380a52851c
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~ines-almeida/launchpad:upgrade-pkginfo-dependency
Merge into: launchpad:master
Diff against target: 13 lines (+1/-1)
1 file modified
requirements/launchpad.txt (+1/-1)
Reviewer Review Type Date Requested Status
Simone Pelosi Approve
Review via email: mp+465595@code.launchpad.net

Commit message

Bump pkginfo==1.10.0

Description of the change

Related to: https://code.launchpad.net/~ines-almeida/lp-source-dependencies/+git/lp-source-dependencies/+merge/465593

The current pkginfo (1.8.2) is not able to read Metadata 2.3 - this is added in this more recent version.
Not being able to read Metadata 2.3 seems to cause issues where launchpad is not able to read the SDist version which leads to an error because we don't allow the `SourcePackageRelease.version` column to be None.

To post a comment you must log in.
Revision history for this message
Simone Pelosi (pelpsi) wrote :

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/requirements/launchpad.txt b/requirements/launchpad.txt
2index b7b7957..59dd615 100644
3--- a/requirements/launchpad.txt
4+++ b/requirements/launchpad.txt
5@@ -121,7 +121,7 @@ patiencediff==0.2.2
6 pexpect==4.8.0
7 pgbouncer==0.0.9
8 pickleshare==0.7.5
9-pkginfo==1.8.2
10+pkginfo==1.10.0
11 prettytable==0.7.2
12 prompt-toolkit==2.0.10
13 psutil==5.4.2

Subscribers

People subscribed via source and target branches

to status/vote changes: