~ines-almeida/launchpad:fix-social-accounts-class-to-not-trigger-adblocker

Branch merges

Propose for merging

Merged into launchpad:master

Simone Pelosi: Approve on 2024-01-24

Diff: 146 lines (+19/-19)

7 files modified

lib/canonical/launchpad/icing/css/components/social_accounts.scss (+1/-1)
lib/lp/app/browser/tales.py (+1/-1)
lib/lp/app/tests/test_tales.py (+1/-1)
lib/lp/registry/stories/person/xx-person-edit-jabber-ids.rst (+1/-1)
lib/lp/registry/stories/person/xx-person-edit-matrix-accounts.rst (+1/-1)
lib/lp/registry/stories/person/xx-person-home.rst (+2/-2)
lib/lp/registry/templates/person-portlet-contact-details.pt (+12/-12)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

c53c249... by Ines Almeida on 2024-01-23

ui: update social accounts class names to use hyphens instead of underscores

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

1d2507c... by Guruprasad on 2024-01-23

Update social accounts' elements' class names

The previous 'social_accounts*' class names were getting blocked by the
ad blockers.

c332267... by Guruprasad on 2024-01-23

Fix the matrix homeserver domain validation regex

The previous regex did not allow some valid TLDs like the
2-character-long ones.

Merged from https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/459228

01bdcdf... by Guruprasad on 2024-01-23

Fix the matrix homeserver domain validation regex

The previous regex did not allow some valid TLDs like the
2-character-long ones.

880a4aa... by Guruprasad on 2024-01-23

Fix typo in regex variable name

65bbeec... by Guruprasad on 2024-01-23

Add SOCIAL_PLATFORM_TYPES_MAP to __all__

This fixes an importpedant error.

ff54b70... by Ines Almeida on 2024-01-18

test: remove social accounts test that no longer makes sense

After the API validation was updated to not allow markup in username and domain, this test no longer makes sense as we are not allowing markup in the SocialAccount.identity fields anymore

Merged from https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/458976

fc1d0f0... by Ines Almeida on 2024-01-18

test: fix merge conflict in jabber ui tests

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

2dd6b68... by Ines Almeida on 2024-01-18

test: remove social accounts test that no longer makes sense

After the API validation was updated to not allow markup in username and domain, this test no longer makes sense as we are not allowing markup in the SocialAccount.identity fields anymore

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

527a777... by Ines Almeida on 2024-01-18

Update display social accounts view

Merged from https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/458730