~ines-almeida/launchpad:webhook-patterns/update-models

Branch merges

Propose for merging

Merged into launchpad:master

Colin Watson (community): Approve on 2023-07-19

Diff: 543 lines (+224/-21)

9 files modified

lib/lp/code/interfaces/cibuild.py (+13/-1)
lib/lp/code/model/cibuild.py (+51/-12)
lib/lp/code/model/tests/test_cibuild.py (+53/-2)
lib/lp/services/webhooks/browser.py (+1/-0)
lib/lp/services/webhooks/interfaces.py (+27/-2)
lib/lp/services/webhooks/model.py (+35/-3)
lib/lp/services/webhooks/tests/test_model.py (+41/-1)
lib/lp/services/webhooks/tests/test_webservice.py (+1/-0)
lib/lp/testing/factory.py (+2/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

7b067ca... by Ines Almeida on 2023-07-19

Add git_refs field to CIBuilds

The new field will be used to filter CIBuild webhook events by matching their git_refs against the webhooks git_ref_pattern

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

ef6aa5a... by Ines Almeida on 2023-07-19

Add check_webhook_git_ref_pattern function

Function checks whether a webhook git_ref_pattern matches against a given git reference. To be used when filtering webhooks by git ref patterns

049cc86... by Ines Almeida on 2023-07-19

Add git_ref_pattern field to webhooks

f51768b... by Jürgen Gmach on 2023-07-19

Fix location of `propertycache.rst`

Merged from https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/447105

d943b1f... by Colin Watson on 2023-07-18

Convert Diff to Storm

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/446889

5ee2bf8... by Jürgen Gmach on 2023-07-18

Fix location of `propertycache.rst`

f593bbb... by Colin Watson on 2023-07-18

Start feature controller earlier in Twisted services

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/447085

12c019a... by Colin Watson on 2023-07-18

Start feature controller earlier in Twisted services

After migrating buildd-manager to a charmed deployment, it quite
frequently seems to start up in a bad state, where all its database
operations fail with errors like "permission denied for relation
builder".

I can reproduce this on staging, but only sometimes, and unreliably: it
seems to be a race condition of some kind. My best guess is that it has
something to do with the different database connection arrangements for
charmed deployments, where we switch to the desired database role after
connecting. As such, I guessed that setting up the feature controller
earlier in the service startup sequence might help, since that makes a
database connection, and it would make some sense that it might matter
whether this happens before or after we start a bunch of threads; and
indeed when I try that I don't seem to be able to reproduce the problem
on staging any more.

This isn't entirely satisfactory, and I'd like to understand the problem
better, but perhaps this will do for now.

bbba9fc... by Colin Watson on 2023-07-18

charm: Restart the right buildd-manager service on logrotate

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/447068

d0cbe4c... by Colin Watson on 2023-07-18

charm: Restart the right buildd-manager service on logrotate