Merge lp:~jameinel/bzr/2.0.5-switch-unicode-317778 into lp:bzr
Proposed by
John A Meinel
Status: | Rejected |
---|---|
Rejected by: | Robert Collins |
Proposed branch: | lp:~jameinel/bzr/2.0.5-switch-unicode-317778 |
Merge into: | lp:bzr |
Diff against target: |
13 lines (+3/-0) 1 file modified
bzrlib/builtins.py (+3/-0) |
To merge this branch: | bzr merge lp:~jameinel/bzr/2.0.5-switch-unicode-317778 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Pool | Needs Fixing | ||
Review via email: mp+19121@code.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 4730. By philyoon
-
Escape the to_location for 'bzr switch'
so that it can handle non-ascii sibling branch names.Needs tests. Bug #317778
This is an attempt to propose the patch on bug #317778 as a merge request.
I think it has a lot of stuff missing (needs tests, some manual testing to make sure we haven't regressed for other cases, etc.)
get_transport() has a fair amount of DWIM code to allow users to specify whatever works the best for them, and I don't think that is also in urlutils.escape(). We use that mostly to allow people to specify a Unicode path, while internally we treat things as URLs. But users may also specify the url on the command line.
Anyway, getting this put up as a Merge Proposal in some form seemed better than leaving it as an abandoned patch.