lp:~jameinel/juju-core/api-rpc-reflect-version

Branch merges

Propose for merging

1 branch dependent on this one.

On hold for merging into lp:~go-bot/juju-core/trunk

Juju Engineering: Pending requested 2014-05-15

Diff: 1306 lines (+645/-135)

12 files modified

rpc/jsoncodec/codec.go (+7/-3)
rpc/reflect_test.go (+47/-19)
rpc/registry/package_test.go (+14/-0)
rpc/registry/registry.go (+71/-0)
rpc/registry/registry_test.go (+96/-0)
rpc/rpc_test.go (+266/-47)
rpc/rpcreflect/type.go (+13/-6)
rpc/rpcreflect/value.go (+44/-19)
rpc/server.go (+60/-14)
state/apiserver/root_test.go (+20/-18)
utils/registry/registry.go (+6/-8)
utils/registry/registry_test.go (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

2726. By John A Meinel on 2014-05-22

apply feedback from Dimiter's review.

2724. By John A Meinel on 2014-05-16

merge typed-registry, bringing it trunk and switch to github.com/juju/errors

2723. By John A Meinel on 2014-05-16

add some fullstops for comments in another branch

2722. By John A Meinel on 2014-05-16

address review comments.

2721. By John A Meinel on 2014-05-14

merge in rpc-version.

This gives us all of the functionality for passing Version in the RPC,
and changes the MethodCaller signature so that it can take the version
and the objId.

2720. By John A Meinel on 2014-05-14

Merge trunk r2730

2719. By John A Meinel on 2014-05-12

go fmt.

2718. By John A Meinel on 2014-05-11

export the type so that other places can have a reference to it.

2717. By John A Meinel on 2014-05-11

check that the type can be converted exactly to the version we want

2716. By John A Meinel on 2014-05-11

Create a registry.TypedNameVersion type.

This is meant as a generic Registry implementation, though the Typed
code allows you to ensure that the types of things registered exactly
match what you want.
We use ConvertibleTo and do the Convert internally, which allows you
to specify a named type for your interface, but pass in things
without having to actually cast them ahead of time.

Needs a bit more refinement, but should allow us an easy way to
have a generic Registry while still preserving the Types that we
care about.